aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHanjun Guo <hanjun.guo@linaro.org>2015-05-11 00:17:14 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2015-05-13 17:28:15 -0400
commit16eac059a6800f640423b7b6e2e9fc7091bad102 (patch)
tree4aa2f2fd21f4fa42c988085227c5cc6e2138ec67
parent25956b6612601cf36022392ffa83f6bf97939bcd (diff)
Xen / ACPI / processor: use invalid_logical_cpuid()
Use invalid_logical_cpuid(pr->id) instead of direct comparison. Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com> CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--drivers/xen/xen-acpi-cpuhotplug.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/xen/xen-acpi-cpuhotplug.c b/drivers/xen/xen-acpi-cpuhotplug.c
index 3e62ee4b3b66..5a62aa007d4a 100644
--- a/drivers/xen/xen-acpi-cpuhotplug.c
+++ b/drivers/xen/xen-acpi-cpuhotplug.c
@@ -77,7 +77,7 @@ static int xen_acpi_processor_enable(struct acpi_device *device)
77 77
78 pr->id = xen_pcpu_id(pr->acpi_id); 78 pr->id = xen_pcpu_id(pr->acpi_id);
79 79
80 if ((int)pr->id < 0) 80 if (invalid_logical_cpuid(pr->id))
81 /* This cpu is not presented at hypervisor, try to hotadd it */ 81 /* This cpu is not presented at hypervisor, try to hotadd it */
82 if (ACPI_FAILURE(xen_acpi_cpu_hotadd(pr))) { 82 if (ACPI_FAILURE(xen_acpi_cpu_hotadd(pr))) {
83 pr_err(PREFIX "Hotadd CPU (acpi_id = %d) failed.\n", 83 pr_err(PREFIX "Hotadd CPU (acpi_id = %d) failed.\n",
@@ -226,7 +226,7 @@ static acpi_status xen_acpi_cpu_hotadd(struct acpi_processor *pr)
226 return AE_ERROR; 226 return AE_ERROR;
227 227
228 pr->id = xen_hotadd_cpu(pr); 228 pr->id = xen_hotadd_cpu(pr);
229 if ((int)pr->id < 0) 229 if (invalid_logical_cpuid(pr->id))
230 return AE_ERROR; 230 return AE_ERROR;
231 231
232 /* 232 /*