diff options
author | Eric Huang <JinHuiEric.Huang@amd.com> | 2016-06-14 15:08:22 -0400 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2016-07-07 14:54:32 -0400 |
commit | 14b33074299cbdf3213723dc4267fd3c822135c7 (patch) | |
tree | 93d4b7a86cdb01dc7414ecf71a3c39093a5ad74e | |
parent | 0a81a87c984afb1f765b8d60da809d177aff5c89 (diff) |
drm/amdgpu: some improvement in parsing inputs
It changes the way to skip newline character and also avoids
warning message from some compiler.
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Eric Huang <JinHuiEric.Huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index 250f8693f170..ff63b88b0ffa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | |||
@@ -365,7 +365,9 @@ static ssize_t amdgpu_set_pp_dpm_sclk(struct device *dev, | |||
365 | uint32_t i, mask = 0; | 365 | uint32_t i, mask = 0; |
366 | char sub_str[2]; | 366 | char sub_str[2]; |
367 | 367 | ||
368 | for (i = 0; i < strlen(buf) - 1; i++) { | 368 | for (i = 0; i < strlen(buf); i++) { |
369 | if (*(buf + i) == '\n') | ||
370 | continue; | ||
369 | sub_str[0] = *(buf + i); | 371 | sub_str[0] = *(buf + i); |
370 | sub_str[1] = '\0'; | 372 | sub_str[1] = '\0'; |
371 | ret = kstrtol(sub_str, 0, &level); | 373 | ret = kstrtol(sub_str, 0, &level); |
@@ -413,7 +415,9 @@ static ssize_t amdgpu_set_pp_dpm_mclk(struct device *dev, | |||
413 | uint32_t i, mask = 0; | 415 | uint32_t i, mask = 0; |
414 | char sub_str[2]; | 416 | char sub_str[2]; |
415 | 417 | ||
416 | for (i = 0; i < strlen(buf) - 1; i++) { | 418 | for (i = 0; i < strlen(buf); i++) { |
419 | if (*(buf + i) == '\n') | ||
420 | continue; | ||
417 | sub_str[0] = *(buf + i); | 421 | sub_str[0] = *(buf + i); |
418 | sub_str[1] = '\0'; | 422 | sub_str[1] = '\0'; |
419 | ret = kstrtol(sub_str, 0, &level); | 423 | ret = kstrtol(sub_str, 0, &level); |
@@ -461,7 +465,9 @@ static ssize_t amdgpu_set_pp_dpm_pcie(struct device *dev, | |||
461 | uint32_t i, mask = 0; | 465 | uint32_t i, mask = 0; |
462 | char sub_str[2]; | 466 | char sub_str[2]; |
463 | 467 | ||
464 | for (i = 0; i < strlen(buf) - 1; i++) { | 468 | for (i = 0; i < strlen(buf); i++) { |
469 | if (*(buf + i) == '\n') | ||
470 | continue; | ||
465 | sub_str[0] = *(buf + i); | 471 | sub_str[0] = *(buf + i); |
466 | sub_str[1] = '\0'; | 472 | sub_str[1] = '\0'; |
467 | ret = kstrtol(sub_str, 0, &level); | 473 | ret = kstrtol(sub_str, 0, &level); |