diff options
author | Álvaro Fernández Rojas <noltari@gmail.com> | 2015-12-15 15:03:46 -0500 |
---|---|---|
committer | Jacek Anaszewski <j.anaszewski@samsung.com> | 2016-01-04 03:57:39 -0500 |
commit | 0171dc6abbfab4a168f65498a73d18311cb606b5 (patch) | |
tree | 0b0046c612b2f509446f79972a0b0ac4dff61be2 | |
parent | 41251e2469f081da0d7844c8c61400cf030b58ed (diff) |
leds: bcm6328: remove unneded lock when checking initial LED
This lock isn't really needed, since we're only reading the register and
changes made to other LEDs aren't relevant.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
-rw-r--r-- | drivers/leds/leds-bcm6328.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c index 1ef69c27a6a7..cd542641e38d 100644 --- a/drivers/leds/leds-bcm6328.c +++ b/drivers/leds/leds-bcm6328.c | |||
@@ -264,7 +264,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, | |||
264 | unsigned long *blink_leds, unsigned long *blink_delay) | 264 | unsigned long *blink_leds, unsigned long *blink_delay) |
265 | { | 265 | { |
266 | struct bcm6328_led *led; | 266 | struct bcm6328_led *led; |
267 | unsigned long flags; | ||
268 | const char *state; | 267 | const char *state; |
269 | int rc; | 268 | int rc; |
270 | 269 | ||
@@ -286,7 +285,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, | |||
286 | "linux,default-trigger", | 285 | "linux,default-trigger", |
287 | NULL); | 286 | NULL); |
288 | 287 | ||
289 | spin_lock_irqsave(lock, flags); | ||
290 | if (!of_property_read_string(nc, "default-state", &state)) { | 288 | if (!of_property_read_string(nc, "default-state", &state)) { |
291 | if (!strcmp(state, "on")) { | 289 | if (!strcmp(state, "on")) { |
292 | led->cdev.brightness = LED_FULL; | 290 | led->cdev.brightness = LED_FULL; |
@@ -314,7 +312,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, | |||
314 | } else { | 312 | } else { |
315 | led->cdev.brightness = LED_OFF; | 313 | led->cdev.brightness = LED_OFF; |
316 | } | 314 | } |
317 | spin_unlock_irqrestore(lock, flags); | ||
318 | 315 | ||
319 | bcm6328_led_set(&led->cdev, led->cdev.brightness); | 316 | bcm6328_led_set(&led->cdev, led->cdev.brightness); |
320 | 317 | ||