From d8c1aed41b421ab60a2b6fdbf4776c46dc66ec94 Mon Sep 17 00:00:00 2001
From: Steven Rostedt <srostedt@redhat.com>
Date: Wed, 10 Feb 2010 20:56:09 -0500
Subject: trace-graph: Show wake latency in task plots

Add the ability for a plot to draw a empty box.

Then with this ability, change the task plots to show a hollow red
box from the time the task was woken, till the time it was scheduled.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 trace-graph.c     |  8 +++++---
 trace-graph.h     |  2 ++
 trace-plot-task.c | 14 ++++++++++++++
 trace-plot.c      |  1 +
 4 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/trace-graph.c b/trace-graph.c
index d62882c..be19a95 100644
--- a/trace-graph.c
+++ b/trace-graph.c
@@ -1402,7 +1402,8 @@ static gint draw_plot_line(struct graph_info *ginfo, int i,
 
 static void draw_plot_box(struct graph_info *ginfo, int i,
 			  unsigned long long start,
-			  unsigned long long end, GdkGC *gc)
+			  unsigned long long end,
+			  gboolean fill, GdkGC *gc)
 {
 	gint x1;
 	gint x2;
@@ -1411,7 +1412,7 @@ static void draw_plot_box(struct graph_info *ginfo, int i,
 	x2 = convert_time_to_x(ginfo, end);
 
 	gdk_draw_rectangle(ginfo->curr_pixmap, gc,
-			   TRUE,
+			   fill,
 			   x1, PLOT_BOX_TOP(i),
 			   x2 - x1, PLOT_BOX_SIZE);
 }
@@ -1448,7 +1449,8 @@ static void draw_plot(struct graph_info *ginfo, struct graph_plot *plot,
 			set_color(ginfo->draw, plot->gc, plot->last_color);
 		}
 
-		draw_plot_box(ginfo, plot->pos, info.bstart, info.bend, plot->gc);
+		draw_plot_box(ginfo, plot->pos, info.bstart, info.bend,
+			      info.bfill, plot->gc);
 	}
 
 	if (info.line) {
diff --git a/trace-graph.h b/trace-graph.h
index 3874aa9..6a00d82 100644
--- a/trace-graph.h
+++ b/trace-graph.h
@@ -22,6 +22,7 @@ struct plot_info {
 	int			bcolor;
 	unsigned long long	bstart;
 	unsigned long long	bend;
+	gboolean		bfill;
 };
 
 /*
@@ -44,6 +45,7 @@ struct plot_info {
  *    bstart is the time the box starts at
  *    bend is the time the box ends at
  *     (bstart and bend are ignored if box is 0)
+ *    bfill whether or not to fill the box (default TRUE)
  *   time is the time of the current event
  *
  * end:
diff --git a/trace-plot-task.c b/trace-plot-task.c
index a42202f..32bfc68 100644
--- a/trace-plot-task.c
+++ b/trace-plot-task.c
@@ -2,10 +2,13 @@
 
 #include "trace-graph.h"
 
+#define RED 0xff
+
 struct task_plot_info {
 	int			pid;
 	struct cpu_data		*cpu_data;
 	unsigned long long	last_time;
+	unsigned long long	wake_time;
 	int			last_cpu;
 };
 
@@ -305,6 +308,8 @@ static int task_plot_event(struct graph_info *ginfo,
 				task_info->last_cpu = -1;
 			}
 
+			task_info->wake_time = record->ts;
+
 			return 1;
 		}
 
@@ -325,6 +330,13 @@ static int task_plot_event(struct graph_info *ginfo,
 				/* Just got scheduled in */
 				task_info->last_cpu = record->cpu;
 				task_info->last_time = record->ts;
+				if (task_info->wake_time) {
+					info->box = TRUE;
+					info->bfill = FALSE;
+					info->bstart = task_info->wake_time;
+					info->bend = record->ts;
+					info->bcolor = RED;
+				}
 			} else if (!info->box) {
 				/* just got scheduled out */
 				info->box = TRUE;
@@ -335,6 +347,8 @@ static int task_plot_event(struct graph_info *ginfo,
 			}
 		}
 
+		task_info->wake_time = 0;
+
 		return 1;
 	}
 
diff --git a/trace-plot.c b/trace-plot.c
index ec76d52..604b7bf 100644
--- a/trace-plot.c
+++ b/trace-plot.c
@@ -321,6 +321,7 @@ int trace_graph_plot_event(struct graph_info *ginfo,
 {
 	info->line = FALSE;
 	info->box = FALSE;
+	info->bfill = TRUE;
 
 	if (!plot->cb->plot_event)
 		return 0;
-- 
cgit v1.2.2