aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAge
...
* | trace-view: Do not select a row if there are noneSteven Rostedt2010-01-07
| | | | | | | | | | | | | | Selecting a row use to give errors when there were no rows. Just prevent a row from being selected when there are none. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | kernelshark: Separate event filtering from graph and listSteven Rostedt2010-01-07
| | | | | | | | | | | | | | | | | | Let the list and the graph have their own filters. While analyzing the data, I found it nice to be able to limit the graph but still see other events in the list. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | kerenl-shark: Use callbacks for updating the filter between graph and listSteven Rostedt2010-01-07
| | | | | | | | | | | | Have the graph send callbacks to update the lists filters. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Add hiding of tasks to listSteven Rostedt2010-01-07
| | | | | | | | | | | | | | Pass the task filters for both hiding and filtering from the graph to the list. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Fix filter_task_copy to also copy countSteven Rostedt2010-01-07
| | | | | | | | | | | | Need to copy the count of the hash, not just the data. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Add hiding of tasksSteven Rostedt2010-01-07
| | | | | | | | | | | | | | | | Add option to hide tasks. This acts as the opposite of filtering. If a task is added to the hidden list, then it will not show up. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | kernel-shark: Add event filtering for graph tooSteven Rostedt2010-01-07
| | | | | | | | | | | | Use the event filter callback to also update the graph. Signen-off-by: Steven Rostedt <rostedt@goodmis.org>
* | Merge branch 'trace-cmd' into trace-viewSteven Rostedt2010-01-07
|\|
| * trace-cmd: Add *.dat and *.patch to .gitignoreSteven Rostedt2010-01-07
| | | | | | | | | | | | | | | | | | Have git ignore the data files used by trace-cmd. The default data file is trace.dat, but anything ending in .dat should be ignored. Also, ignore patches that are laying around in the directory. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Implement event filtering for the graphSteven Rostedt2010-01-07
| | | | | | | | | | | | | | Move some of the trace-view event filtering to be generic enough and have the trace-graph use it. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Make event and CPU dialogs genericSteven Rostedt2010-01-07
| | | | | | | | | | | | | | | | | | | | Since the event and CPU dialogs may also be used by the trace-graph make it generic and remove the dependency of the trace-view-store. This also changes them to accept a callback function for when a response is made. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Free the pango font descriptionSteven Rostedt2010-01-07
| | | | | | | | | | | | Apparently we have to free this. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Free pango layoutSteven Rostedt2010-01-06
| | | | | | | | | | | | | | The pango layout that is created for determining size is never freed. Free it! Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Fix trace_view_store_get_row() assertionSteven Rostedt2010-01-06
| | | | | | | | | | | | | | With recent changes to getting rows, the assertion to check the row integrity was not updated, and would cause false failures. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Shut up the stupid gcc warningSteven Rostedt2010-01-05
| | | | | | | | | | | | | | | | | | | | A printf format has %llu for reading guint64, which is necessary on 32bit boxes. But unfortunately, on 64 bit boxes, guint64 is a long. This makes it inconsistent for how to read it. Just typecast it to long long and shut up the warning. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Have deselecting an event system clear allSteven Rostedt2010-01-05
| | | | | | | | | | | | | | | | If the event filter system or all-events is deselected, have it deselect all its siblings. This is useful if you only want to see a few events. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | Merge branch 'for-rostedt/trace-view' of ↵Steven Rostedt2010-01-05
|\ \ | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/dvhart/trace-cmd into dvhart-temp
| * | trace-view: cleanup python make targetsDarren Hart2010-01-05
| | | | | | | | | | | | Signed-off-by: Darren Hart <dvhltc@us.ibm.com>
| * | trace-view: consolidate the trace-view-store row accessDarren Hart2010-01-05
| | | | | | | | | | | | | | | | | | | | | | | | Rather than provide an accessor function for each field of the row record in the trace-view-store, simply return the row record and allow the caller to access the fields directly. Signed-off-by: Darren Hart <dvhltc@us.ibm.com>
* | | trace-graph: Show filtered tasks scheduling outSteven Rostedt2010-01-05
| | | | | | | | | | | | | | | | | | | | | The trace graph shows filtered tasks scheduling in, but it filters out that task from scheduling out. This fixes that bug. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | | trace-view: Fix list filter on tasks scheduling inSteven Rostedt2010-01-05
| | | | | | | | | | | | | | | | | | | | | Fix the list to view the task scheduling in. That is, the record belongs to the previous task, but we want to see a filtered task scheduling in. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | | trace-view: Implement event filterSteven Rostedt2010-01-05
| | | | | | | | | | | | | | | | | | | | | This patch now implements the event filtering dialog for the trace-view (list) only. This works with kernelshark too, but only the list is filtered. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | | trace-view: Add check boxes to event filter dialogSteven Rostedt2010-01-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The event dialog now implements check boxes that are used to select and unselect the events. Although the event filter dialog is still not hooked to anything, and does not affect the list yet. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | | trace-view: Fixed comment about version in trace-compat.hSteven Rostedt2010-01-05
| | | | | | | | | | | | Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | | trace-view: Have filter dialogs not show scrollbars when not neededSteven Rostedt2010-01-05
| | | | | | | | | | | | | | | | | | | | | Set the scrollbars to automatic, so they are not shown when not needed. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | | trace-view: Add tree view to scrolled window with gtk_container_add()Steven Rostedt2010-01-04
|/ / | | | | | | | | | | | | | | | | The tree-view-main.c added the tree view to the scrolled window with gtk_scrolled_window_add_with_viewport, but tree-views have their own viewport. Not only is this not the proper way, but it was causing a hang when we opened either the CPU or events dialogs. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Add ctracecmdgui_wrap.c to .gitignoreDarren Hart2010-01-04
| | | | | | | | | | | | Signed-off-by: Darren Hart <dvhltc@us.ibm.com> LKML-Reference: <1262654682-20325-4-git-send-email-dvhltc@us.ibm.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Provide GTK TreeModel trace-view-store available to pythonDarren Hart2010-01-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the necessary trace-view-store methods non-static and place their declarations in the header file. Functions beginning with _ are considered private in python. The structs beginning with _ caused their accessor functions to be generated as private. Since they aren't used as structs anywhere in the C code, rename them to something more accessible to python. Signed-off-by: Darren Hart <dvhltc@us.ibm.com> LKML-Reference: <1262654682-20325-3-git-send-email-dvhltc@us.ibm.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Add trace_view_store_get_row() convenience functionDarren Hart2010-01-04
| | | | | | | | | | | | | | | | | | trace_view_get_row() encapsulates some of the bounds checking and provides a Python friendly way to access the store rows. Signed-off-by: Darren Hart <dvhltc@us.ibm.com> LKML-Reference: <1262654682-20325-2-git-send-email-dvhltc@us.ibm.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | kernelshark: Make the programs depend on the tracecmd librarySteven Rostedt2010-01-04
| | | | | | | | | | | | | | | | | | | | | | | | If we do a make clean, still allow the dependencies of the programs to create the library. That is: $ make clean $ make trace-view Needs to build the libtracecmd.a file. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Include sched switch in task filteringSteven Rostedt2010-01-04
| | | | | | | | | | | | | | Include when a task is scheduled in as an event in the filtered list. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Fix trace_view_store_get_timestamp_visible_row()Steven Rostedt2010-01-04
| | | | | | | | | | | | | | | | | | | | | | The search used the size of the actual_rows array, and not the size of what was visible. The visible_rows use the array, but anything outside the visible rows are just left overs. Using the bsearch on the entire array causes errors in the search. It should only use the subset that is visible. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Fix searching by timestamp for filtered listsSteven Rostedt2010-01-04
| | | | | | | | | | | | | | | | | | | | | | | | | | When a list is filtered, the search_for_record_by_timestamp() was returning incorrect values because the rows_ts_cmp() was using the pointer the array was pointing to go to the next record. But if that record was not visible or the next record should have been on another CPU, it would break the bsearch. The correct approach is to look at the next record in the array, not the per cpu list. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Do not call helper function to select row in trace_view_select()Steven Rostedt2010-01-04
| | | | | | | | | | | | | | The helper function to select a row just adds overhead for trace_view_select(). Just call the selection directly. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-view: Return only visible recordsSteven Rostedt2010-01-04
| | | | | | | | | | | | | | | | The trace_view_store_get_timestamp_visible_row() did not return only visible rows, but also invisible ones. This patch fixes the code to only return the visible rows. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | kernel-shark: Enabled filtering of tasks for list and graphSteven Rostedt2010-01-04
| | | | | | | | | | | | The list and graph can now filter tasks. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | Merge branch 'trace-cmd' into trace-viewSteven Rostedt2010-01-04
|\|
| * trace-cmd: Have tracecmd_read_cpu_first() return the first recordSteven Rostedt2010-01-04
| | | | | | | | | | | | | | | | | | | | | | There was a bug with tracecmd_read_cpu_first() where it may not return the first record for a CPU. If another record was read on the first page the get_page() function would return without reseting the index. The tracecmd_read_cpu_first() needs to always reset the index before returning tracecmd_read_data(). Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Move task filter code to trace-hash.[ch]Steven Rostedt2010-01-04
| | | | | | | | | | | | | | | | | | In order to make the trace tree of kernelshark work better with the trace-graph, move the filtering code of tasks out of trace-graph.c into trace-hash.c. This will allow the trace-tree to be more flexible in its filtering too. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Disable filter when last task is removedSteven Rostedt2010-01-04
| | | | | | | | | | | | When the last task is removed from the filter, disable the filter. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | kernel-shark: Allow filtering of graph from tree viewSteven Rostedt2010-01-04
| | | | | | | | | | | | | | | | Let the tree view pop up menu filter the graph as well. This makes finding tasks to filter on easier, as it is easier to search for a task from the tree view than with the graph. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | Merge branch 'trace-cmd' into trace-viewSteven Rostedt2009-12-31
|\| | | | | | | | | | | | | Conflicts: Makefile Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| * trace-cmd: Add plugin_kmem for showing function names of call sitesSteven Rostedt2009-12-31
| | | | | | | | | | | | | | | | | | | | | | The kmem events only show a useless hex symbol for the call site name. This adds a plugin to do a lookup of the function name and still print the rest of the event format. Also adds pevent_find_function_address() to let the plugin show the offset into the function as well. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| * trace-cmd: Allow plugin handlers to let the default print to also happenSteven Rostedt2009-12-31
| | | | | | | | | | | | | | | | | | | | A plugin may only need to translate part of the field, or if it fails to translate, it may want the default to print. Now if a plugin handler returns something other than 0, the default print handler will take place. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Add filtering of tasksSteven Rostedt2009-12-31
| | | | | | | | | | | | | | This enables the popup filter menus to actual filter the tasks in the graph. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Remove hack to redraw graphSteven Rostedt2009-12-31
| | | | | | | | | | | | | | | | An old hack was still in place to redraw the graph after zooming in and out. Replace it with the redraw function and the update_with_backend(). Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Add task filtering popup menusSteven Rostedt2009-12-31
| | | | | | | | | | | | | | | | | | Add popup menus to graph that allows the use to add or remove tasks from the filter, as well as to enable or disable the filter. This only adds the popup menus, the filtering is not actually done yet. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Replace hash looping with a faster hashSteven Rostedt2009-12-31
| | | | | | | | | | | | | | | | | | Did a little more research and found a nice hash that is quick and pretty powerful. Based off of Paul Hsieh's super fast hash: http://www.azillionmonkeys.com/qed/hash.html Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Add a little better pid hash functionSteven Rostedt2009-12-31
| | | | | | | | | | | | | | | | This adds a little better pid hash function that will give a better difference in colors for tasks than the previous hash algorithm. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
* | trace-graph: Fix color of task starting windowSteven Rostedt2009-12-31
| | | | | | | | | | | | | | | | | | The color was not being set up for the box if a task other than idle was the first event on a CPU. The gc variable used to draw the task box was not initialized and the color of the task was random at the start. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>