video: tegra: dc: have proper of_node_put

of_node_put is needed before discarding a value received
from of_find_node_by_path, of_parse_phandle and
of_find_compatible_node in error handling code or when the
device node is no longer used, in order to avoid any
memory leak.

Bug 1371533

Change-Id: I824d10bca984e4d6e46bf2f41e30dd441f0f0668
Signed-off-by: Min-wuk Lee <mlee@nvidia.com>
Reviewed-on: http://git-master/r/655213
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
Tested-by: Bharat Nihalani <bnihalani@nvidia.com>

1 files changed, 6 insertions, 1 deletions

diff --git a/drivers/video/tegra/dc/dp.c b/drivers/video/tegra/dc/dp.c
index 45b5fbac4..499052537 100644
--- a/drivers/video/tegra/dc/dp.c
+++ b/drivers/video/tegra/dc/dp.c
@@ -1620,8 +1620,10 @@ static int tegra_dc_dp_init(struct tegra_dc *dc)
                 : of_find_node_by_path(DPAUX_NODE);
 
         dp = devm_kzalloc(&dc->ndev->dev, sizeof(*dp), GFP_KERNEL);
-        if (!dp)
+        if (!dp) {
+                of_node_put(np_dp);
                 return -ENOMEM;
+        }
 
         if (np) {
                 if (np_dp && (of_device_is_available(np_dp) ||
@@ -1743,6 +1745,7 @@ static int tegra_dc_dp_init(struct tegra_dc *dc)
 
         tegra_dc_set_outdata(dc, dp);
         tegra_dc_dp_debug_create(dp);
+        of_node_put(np_dp);
 
         return 0;
 
@@ -1761,6 +1764,7 @@ err_release_resource_reg:
                 release_resource(res);
 err_free_dp:
         devm_kfree(&dc->ndev->dev, dp);
+        of_node_put(np_dp);
 
         return err;
 }
@@ -2432,6 +2436,7 @@ static void tegra_dc_dp_destroy(struct tegra_dc *dc)
         if (!np_dp || !of_device_is_available(np_dp))
                 release_resource(dp->res);
         devm_kfree(&dc->ndev->dev, dp);
+        of_node_put(np_dp);
 }
 
 static void tegra_dc_dp_disable(struct tegra_dc *dc)