drivers: spi: Avoid unchecked return value

tegra_prod_set_by_name is called without checking the return value.
Return value indicates either success or fail.
Fixed by capturing the return value and using it for error message.

Coverity ID 557117

Bug 200192456

Change-Id: I05a0b16cf5f6792800b4d0362075075b7362b68b
Signed-off-by: Aniruddha TVS Rao <anrao@nvidia.com>
Reviewed-on: http://git-master/r/1320963
Reviewed-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>

1 files changed, 7 insertions, 1 deletions

diff --git a/drivers/spi/spi-tegra186-qspi.c b/drivers/spi/spi-tegra186-qspi.c
index 9eb59c3d8..3b4120e83 100644
--- a/drivers/spi/spi-tegra186-qspi.c
+++ b/drivers/spi/spi-tegra186-qspi.c
@@ -969,11 +969,17 @@ static void tegra_qspi_set_gr_registers(struct spi_device *spi)
 {
         struct tegra_qspi_data *tqspi = spi_master_get_devdata(spi->master);
         char prod_name[MAX_PROD_NAME];
+        int err;
+
         if (tqspi->prod_list) {
                 /* If available, initialise the config registers
                  * for QSPI with the values mentioned in prod list.
                  */
-                tegra_prod_set_by_name(&tqspi->base, "prod", tqspi->prod_list);
+                err = tegra_prod_set_by_name(&tqspi->base, "prod",
+                                                tqspi->prod_list);
+                if (err < 0)
+                        dev_dbg(tqspi->dev,
+                                "failed to set prod for qspi by %d\n", err);
                 if (tqspi->is_ddr_mode)
                         sprintf(prod_name, "prod_c_DDR%d", (tqspi->cur_speed/1000000));
                 else