r8152: Use kmemdup instead of kmalloc + memcpy

This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

From http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c4438f03ca439daa349d93d7102ed36422dfcd7f

Change-Id: I2987a0a992f6fe7a312bd92b84ab3b954dfa81e8
Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from upstream commit c4438f03ca439daa349d93d7102ed36422dfcd7f)
Signed-off-by: Aly Hirani <ahirani@nvidia.com>
Reviewed-on: http://git-master/r/553391
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>

1 files changed, 1 insertions, 3 deletions

diff --git a/drivers/net/usb/r8152_shield.c b/drivers/net/usb/r8152_shield.c
index dd067e534..1c206bec9 100644
--- a/drivers/net/usb/r8152_shield.c
+++ b/drivers/net/usb/r8152_shield.c
@@ -667,12 +667,10 @@ int set_registers(struct r8152 *tp, u16 value, u16 index, u16 size, void *data)
         int ret;
         void *tmp;
 
-        tmp = kmalloc(size, GFP_KERNEL);
+        tmp = kmemdup(data, size, GFP_KERNEL);
         if (!tmp)
                 return -ENOMEM;
 
-        memcpy(tmp, data, size);
-
         ret = usb_control_msg(tp->udev, usb_sndctrlpipe(tp->udev, 0),
                                RTL8152_REQ_SET_REGS, RTL8152_REQT_WRITE,
                                value, index, tmp, size, 500);