drivers: ov5693: coverity issue fix

remove redundant priv->pdata pointer check.

coverity ID: 20412

Bug 200116059

Change-Id: I7eb8db1e27ada09cf24ce4494b52b274c941bd17
Signed-off-by: David Wang <davidw@nvidia.com>
Reviewed-on: http://git-master/r/1001866
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Jihoon Bang <jbang@nvidia.com>

1 files changed, 9 insertions, 4 deletions

diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
index 3cee4e983..1f2479800 100644
--- a/drivers/media/i2c/ov5693.c
+++ b/drivers/media/i2c/ov5693.c
@@ -397,8 +397,13 @@ static int ov5693_power_get(struct ov5693 *priv)
         struct clk *parent;
         int err = 0;
 
-        mclk_name = priv->pdata->mclk_name ?
-                    priv->pdata->mclk_name : "cam_mclk1";
+        if (!pdata) {
+                dev_err(&priv->i2c_client->dev, "pdata missing\n");
+                return -EFAULT;
+        }
+
+        mclk_name = pdata->mclk_name ?
+                    pdata->mclk_name : "cam_mclk1";
         pw->mclk = devm_clk_get(&priv->i2c_client->dev, mclk_name);
         if (IS_ERR(pw->mclk)) {
                 dev_err(&priv->i2c_client->dev,
@@ -406,7 +411,7 @@ static int ov5693_power_get(struct ov5693 *priv)
                 return PTR_ERR(pw->mclk);
         }
 
-        parentclk_name = priv->pdata->parentclk_name;
+        parentclk_name = pdata->parentclk_name;
         if (parentclk_name) {
                 parent = devm_clk_get(&priv->i2c_client->dev, parentclk_name);
                 if (IS_ERR(parent)) {
@@ -430,7 +435,7 @@ static int ov5693_power_get(struct ov5693 *priv)
                 pw->pwdn_gpio = pdata->pwdn_gpio;
         }
 
-        if (priv->pdata && priv->pdata->use_cam_gpio) {
+        if (pdata->use_cam_gpio) {
                 err = cam_gpio_register(priv->i2c_client, pw->pwdn_gpio);
                 if (err)
                         dev_err(&priv->i2c_client->dev,