diff options
| author | Sivaram Nair <sivaramn@nvidia.com> | 2017-03-09 13:00:55 -0500 |
|---|---|---|
| committer | Timo Alho <talho@nvidia.com> | 2018-01-11 04:08:09 -0500 |
| commit | a5bf8d4dca93de4381a054f0f30b7604e9e214eb (patch) | |
| tree | fb91e819152670c2f406e68f2fdf650716cdf416 /drivers/firmware/tegra | |
| parent | 4f91383a77e618d5ec48c9969c6627c93b4d443a (diff) | |
firmware: tegra: fix coverity bugs
Removed some redundant checks (unsigned compared against -ve).
Bug 200192149
Change-Id: I080f43c6906ce9d75d178765d6d8638fd768fe6c
Signed-off-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-on: http://git-master/r/1318165
Reviewed-on: http://git-master/r/1493428
Reviewed-by: Navneet Kumar <navneetk@nvidia.com>
GVS: Gerrit_Virtual_Submit
Diffstat (limited to 'drivers/firmware/tegra')
| -rw-r--r-- | drivers/firmware/tegra/fwdebug.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/firmware/tegra/fwdebug.c b/drivers/firmware/tegra/fwdebug.c index 0461ecf17..c97238043 100644 --- a/drivers/firmware/tegra/fwdebug.c +++ b/drivers/firmware/tegra/fwdebug.c | |||
| @@ -123,9 +123,6 @@ static int bpmp_debugfs_read(uint32_t name, uint32_t sz_name, | |||
| 123 | struct mrq_debugfs_response re; | 123 | struct mrq_debugfs_response re; |
| 124 | int r; | 124 | int r; |
| 125 | 125 | ||
| 126 | if (sz_name < 0 || sz_data < 0) | ||
| 127 | return -EINVAL; | ||
| 128 | |||
| 129 | rq.cmd = cpu_to_le32(CMD_DEBUGFS_READ); | 126 | rq.cmd = cpu_to_le32(CMD_DEBUGFS_READ); |
| 130 | rq.fop.fnameaddr = cpu_to_le32(name); | 127 | rq.fop.fnameaddr = cpu_to_le32(name); |
| 131 | rq.fop.fnamelen = cpu_to_le32(sz_name); | 128 | rq.fop.fnamelen = cpu_to_le32(sz_name); |
| @@ -200,9 +197,6 @@ static int bpmp_debugfs_write(uint32_t name, size_t sz_name, | |||
| 200 | { | 197 | { |
| 201 | struct mrq_debugfs_request rq; | 198 | struct mrq_debugfs_request rq; |
| 202 | 199 | ||
| 203 | if (sz_name < 0 || sz_data < 0) | ||
| 204 | return -EINVAL; | ||
| 205 | |||
| 206 | rq.cmd = cpu_to_le32(CMD_DEBUGFS_WRITE); | 200 | rq.cmd = cpu_to_le32(CMD_DEBUGFS_WRITE); |
| 207 | rq.fop.fnameaddr = cpu_to_le32(name); | 201 | rq.fop.fnameaddr = cpu_to_le32(name); |
| 208 | rq.fop.fnamelen = cpu_to_le32(sz_name); | 202 | rq.fop.fnamelen = cpu_to_le32(sz_name); |
