vse: Fix null pointer dereference.

Fix null pointer dereferencing in an error print
before pointer is assigned to non null value.

This fix coverity issue: 2448554

Bug 200689436

Change-Id: If85e16d50d7286b3fa67d2d9a7162b22fe048616
Signed-off-by: Achal Verma <achalv@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2475949
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Dmitry Pervushin <dpervushin@nvidia.com>
Reviewed-by: Rahul Jain (SW-TEGRA) <rahuljain@nvidia.com>
Tested-by: Smriti Sharma <smritis@nvidia.com>
GVS: Gerrit_Virtual_Submit
(cherry picked from commit 559dc2257bc22855010b690f31272e321deeda73)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2499890
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: Phoenix Jung <pjung@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>

1 files changed, 4 insertions, 9 deletions

diff --git a/drivers/crypto/tegra-hv-vse.c b/drivers/crypto/tegra-hv-vse.c
index 7629f26fe..861d0aa83 100644
--- a/drivers/crypto/tegra-hv-vse.c
+++ b/drivers/crypto/tegra-hv-vse.c
@@ -4,7 +4,7 @@
  *
  * Support for Tegra Virtual Security Engine hardware crypto algorithms.
  *
- * Copyright (c) 2016-2020, NVIDIA Corporation. All Rights Reserved.
+ * Copyright (c) 2016-2021, NVIDIA Corporation. All Rights Reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -3653,16 +3653,11 @@ static int tegra_vse_kthread(void *unused)
                         read_size = tegra_hv_ivc_read(pivck,
                                         ivc_resp_msg,
                                         sizeof(struct tegra_virtual_se_ivc_msg_t));
-                        if (read_size <= 0) {
-                                dev_err(se_dev->dev,
-                                        "tegra_hv_ivc_read returned error %d\n", read_size);
+                        if (read_size < sizeof(struct tegra_virtual_se_ivc_msg_t) ) {
+                                pr_err("tegra_hv_ivc_read returned error %d\n", read_size);
                                 break;
                         }
-                        if (read_size < sizeof(struct tegra_virtual_se_ivc_msg_t)) {
-                                dev_err(se_dev->dev,
-                                        "Wrong read msg len %d\n", read_size);
-                                continue;
-                        }
+
                         p_dat =
                                 (struct tegra_vse_tag *)ivc_resp_msg->hdr.tag;
                         priv = (struct tegra_vse_priv_data *)p_dat->priv_data;