nvdla: kmd: handle {RELEASE,ALLOC}_QUEUE ioctls

[1] This commit separates the allocation and deallocation
    of mission critical resources away from open() and close()
[2] It is achieved through introduction of NVDLA_IOCTL_{ALLOC,RELEASE}
    IOCTLs.
[3] nvdla_buffer_* APIs introduced to facilitate easier split.

Jira DLA-4175
Bug 3200422
Bug 200628173

Change-Id: I3fb07ecaff69c62ec5eb9e5bea39b07ae1624240
Signed-off-by: Arvind M <am@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2403689
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2412585
GVS: Gerrit_Virtual_Submit
Tested-by: Bharat Nihalani <bnihalani@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: Mitch Harwell <mharwell@nvidia.com>
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>

4 files changed, 142 insertions, 16 deletions

diff --git a/drivers/video/tegra/host/nvdla/nvdla_buffer.c b/drivers/video/tegra/host/nvdla/nvdla_buffer.c
index 1d7fabfb6..cdbb23f80 100644
--- a/drivers/video/tegra/host/nvdla/nvdla_buffer.c
+++ b/drivers/video/tegra/host/nvdla/nvdla_buffer.c
@@ -1,7 +1,7 @@
 /*
  * NVHOST buffer management for T194
  *
- * Copyright (c) 2016-2018, NVIDIA Corporation.  All rights reserved.
+ * Copyright (c) 2016-2020, NVIDIA Corporation.  All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms and conditions of the GNU General Public License,
@@ -236,6 +236,18 @@ nvdla_buffer_init_err:
         return ERR_PTR(err);
 }
 
+bool nvdla_buffer_is_valid(struct nvdla_buffers *nvdla_buffers)
+{
+        /* Currently there is only one check */
+        return (nvdla_buffers->pdev != NULL);
+}
+
+void nvdla_buffer_set_platform_device(struct nvdla_buffers *nvdla_buffers,
+                struct platform_device *pdev)
+{
+        nvdla_buffers->pdev = pdev;
+}
+
 int nvdla_buffer_submit_pin(struct nvdla_buffers *nvdla_buffers,
                              struct dma_buf **dmabufs, u32 count,
                              dma_addr_t *paddr, size_t *psize,
diff --git a/drivers/video/tegra/host/nvdla/nvdla_buffer.h b/drivers/video/tegra/host/nvdla/nvdla_buffer.h
index 2bb0e57c1..0353e83ed 100644
--- a/drivers/video/tegra/host/nvdla/nvdla_buffer.h
+++ b/drivers/video/tegra/host/nvdla/nvdla_buffer.h
@@ -1,7 +1,7 @@
 /*
  * NVDLA Buffer Management Header
  *
- * Copyright (c) 2019, NVIDIA Corporation.  All rights reserved.
+ * Copyright (c) 2019-2020, NVIDIA Corporation.  All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms and conditions of the GNU General Public License,
@@ -60,6 +60,28 @@ struct nvdla_buffers {
 struct nvdla_buffers *nvdla_buffer_init(struct platform_device *pdev);
 
 /**
+ * @brief       Checks for validity of nvdla_buffer
+ *
+ * This function checks the validity of buffer and is
+ * recommended to be called prior to any buffer operations
+ *
+ * @param nvdla_buffers Pointer to nvdla_buffers struct
+ * @return                  true on buffer being valid, and false otherwise
+ **/
+bool nvdla_buffer_is_valid(struct nvdla_buffers *nvdla_buffers);
+
+/**
+ * @brief       Sets host1x platform device corresponding to nvdla_buffer
+ *
+ * This function resets the platform_device pdev information of nvdla_buffer.
+ *
+ * @param nvdla_buffers Pointer to nvdla_buffers struct
+ * @param pdev                  Pointer to NvHost device
+ **/
+void nvdla_buffer_set_platform_device(struct nvdla_buffers *nvdla_buffers,
+                struct platform_device *pdev);
+
+/**
  * @brief                       Pin the memhandle using dma_buf functions
  *
  * This function maps the buffer memhandle list passed from user side
diff --git a/drivers/video/tegra/host/nvdla/nvdla_ioctl.c b/drivers/video/tegra/host/nvdla/nvdla_ioctl.c
index 12bfabecc..1cea4d54c 100644
--- a/drivers/video/tegra/host/nvdla/nvdla_ioctl.c
+++ b/drivers/video/tegra/host/nvdla/nvdla_ioctl.c
@@ -178,6 +178,12 @@ static int nvdla_pin(struct nvdla_private *priv, void *arg)
 
         nvdla_dbg_fn(pdev, "");
 
+        if (!nvdla_buffer_is_valid(priv->buffers)) {
+                nvdla_dbg_err(pdev, "Invalid buffer\n");
+                err = -EINVAL;
+                goto fail_to_get_val_arg;
+        }
+
         if (!buf_list) {
                 nvdla_dbg_err(pdev, "Invalid argument ptr in pin\n");
                 err = -EINVAL;
@@ -233,6 +239,12 @@ static int nvdla_unpin(struct nvdla_private *priv, void *arg)
 
         nvdla_dbg_fn(pdev, "");
 
+        if (!nvdla_buffer_is_valid(priv->buffers)) {
+                nvdla_dbg_err(pdev, "Invalid buffer\n");
+                err = -EINVAL;
+                goto fail_to_get_val_arg;
+        }
+
         if (!buf_list) {
                 nvdla_dbg_err(pdev, "Invalid argument for pointer\n");
                 err = -EINVAL;
@@ -930,6 +942,70 @@ exit:
         return 0;
 }
 
+static int nvdla_queue_alloc_handler(struct nvdla_private *priv, void *arg)
+{
+        int err = 0;
+        struct platform_device *pdev = priv->pdev;
+        struct nvhost_device_data *pdata = platform_get_drvdata(pdev);
+        struct nvdla_device *nvdla_dev = pdata->private_data;
+
+        /* Currently unused and kept to be consistent with other handlers. */
+        (void) arg;
+
+        /* If queue is already allocated, error out. */
+        if (unlikely(NULL != priv->queue)) {
+                nvdla_dbg_err(pdev, "Queue already allocated");
+                err = -EINVAL;
+                goto fail;
+        }
+
+        /* Allocate the queue */
+        priv->queue = nvdla_queue_alloc(nvdla_dev->pool, MAX_NVDLA_TASK_COUNT,
+                                        nvdla_dev->submit_mode == NVDLA_SUBMIT_MODE_CHANNEL);
+        if (IS_ERR(priv->queue)) {
+                err = PTR_ERR(priv->queue);
+                priv->queue = NULL;
+                goto fail;
+        }
+
+        /* Set nvdla_buffers platform device */
+        nvdla_buffer_set_platform_device(priv->buffers, priv->queue->vm_pdev);
+
+fail:
+        return err;
+}
+
+static int nvdla_queue_release_handler(struct nvdla_private *priv, void *arg)
+{
+        int err = 0;
+        struct platform_device *pdev = priv->pdev;
+
+        /**
+         * Note: This functiona shall be reached directly either
+         * [1] NVDLA_IOCTL_RELEASE_QUEUE ioctl call.
+         * [2] when fd is closed before releasing the queue.
+         **/
+
+        /* Currently unused and kept to be consistent with other handlers. */
+        (void) arg;
+
+        /* If no queue is allocated, error out. */
+        if (unlikely(NULL == priv->queue)) {
+                nvdla_dbg_err(pdev, "No queue to be released.");
+                err = -EINVAL;
+                goto fail;
+        }
+
+        /* Release the queue */
+        (void) nvdla_queue_abort(priv->queue);
+        nvdla_queue_put(priv->queue);
+
+        priv->queue = NULL;
+fail:
+        return err;
+}
+
+
 static int nvdla_submit(struct nvdla_private *priv, void *arg)
 {
         struct nvdla_submit_args *args =
@@ -1097,6 +1173,12 @@ static long nvdla_ioctl(struct file *file, unsigned int cmd,