nvidia-tegra-modules.git/security/tlk_driver/ote_device.c, branch rtss22-ae NVIDIA's kernel modules to support tegra chips (used in Jetson boards) security: tlk: warn user when nvdec clk/reset not available 2019-01-30T00:36:09+00:00 Vince Hsu vinceh@nvidia.com 2019-01-28T09:57:59+00:00 a3c6822a669853467d323843cb4c4e0515b380f8 Add message to warn people that something is wrong with nvdec when the clock and reset control are not available. Bug 200487383 Change-Id: I59ec706df513b4b4e4068cdbbbc614b5fda32e2f Signed-off-by: Vince Hsu <vinceh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2005479 Reviewed-by: Robert Shih <rshih@nvidia.com> Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Vinayak Pane <vpane@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Add message to warn people that something is wrong with nvdec when
the clock and reset control are not available.

Bug 200487383

Change-Id: I59ec706df513b4b4e4068cdbbbc614b5fda32e2f
Signed-off-by: Vince Hsu <vinceh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2005479
Reviewed-by: Robert Shih <rshih@nvidia.com>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
securty: tlk: move miscdev registration to module_init 2018-11-19T19:14:39+00:00 Vince Hsu vinceh@nvidia.com 2018-11-15T03:40:38+00:00 816b9c0e47d63ec75305736fe04dbdc953b3b27a This change moves tlk_driver_init to subsys initcall and put miscdev registration into module_init to fix init order problem with miscdev framework. Bug 200464388 Based on the work by Mahesh Lagadapati <mlagadapati@nvidia.com> Change-Id: I0c2b8fbd8185bfdd05f83607c24e6f4b21250f9a Signed-off-by: Vince Hsu <vinceh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1951229 (cherry picked from commit 19dd8d26da1ae12cf40ba095055f05fd7e00563b) Reviewed-on: https://git-master.nvidia.com/r/1953449 GVS: Gerrit_Virtual_Submit Reviewed-by: Vinayak Pane <vpane@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
This change moves tlk_driver_init to subsys initcall and put miscdev
registration into module_init to fix init order problem with miscdev
framework.

Bug 200464388

Based on the work by Mahesh Lagadapati <mlagadapati@nvidia.com>

Change-Id: I0c2b8fbd8185bfdd05f83607c24e6f4b21250f9a
Signed-off-by: Vince Hsu <vinceh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1951229
(cherry picked from commit 19dd8d26da1ae12cf40ba095055f05fd7e00563b)
Reviewed-on: https://git-master.nvidia.com/r/1953449
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Revert "security: tlk : load tlk driver early" 2018-11-19T19:13:50+00:00 Vinayak Pane vpane@nvidia.com 2018-11-13T02:18:12+00:00 61aa7d070995c142a83e61fb0507e77a0a1a0674 This reverts commit 61d373c4a7156ced5d5ce7c437c053e01c227606. Bug 200464388 Change-Id: I8f8276df7a8541ebb74d9facce07dd967dbd771e Signed-off-by: Vinayak Pane <vpane@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1949340 (cherry picked from commit cd5777721c52d46cd78ced269ec319a4e0248d7b) Reviewed-on: https://git-master.nvidia.com/r/1949343 Tested-by: Vince Hsu <vinceh@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
This reverts commit 61d373c4a7156ced5d5ce7c437c053e01c227606.

Bug 200464388

Change-Id: I8f8276df7a8541ebb74d9facce07dd967dbd771e
Signed-off-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1949340
(cherry picked from commit cd5777721c52d46cd78ced269ec319a4e0248d7b)
Reviewed-on: https://git-master.nvidia.com/r/1949343
Tested-by: Vince Hsu <vinceh@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
security: tlk : load tlk driver early 2018-11-01T07:28:32+00:00 Mahesh Lagadapati mlagadapati@nvidia.com 2018-10-22T19:24:54+00:00 1b51971513bf16e0032b48f3321c4ce818f0941b Drivers like DC need to access TLK during early boot. Hence initializing it early so that other device drivers can use it during boot. Moved TLK cmd list allocation from probe to init as probe function invocation is getting delayed Bug 2418355 Tests TLK unit tests, GVS Change-Id: Ife724a0e1b75ea44c0d065d14e002087638fc64e Signed-off-by: Mahesh Lagadapati <mlagadapati@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1932842 (cherry picked from commit 61d373c4a7156ced5d5ce7c437c053e01c227606) Reviewed-on: https://git-master.nvidia.com/r/1938438 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Mihir Joshi <mihirj@nvidia.com> Reviewed-by: Vinayak Pane <vpane@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Drivers like DC need to access TLK during early boot. Hence initializing
it early so that other device drivers can use it during boot.

Moved TLK cmd list allocation from probe to init as probe function
invocation is getting delayed

Bug 2418355
Tests TLK unit tests, GVS

Change-Id: Ife724a0e1b75ea44c0d065d14e002087638fc64e
Signed-off-by: Mahesh Lagadapati <mlagadapati@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1932842
(cherry picked from commit 61d373c4a7156ced5d5ce7c437c053e01c227606)
Reviewed-on: https://git-master.nvidia.com/r/1938438
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Mihir Joshi <mihirj@nvidia.com>
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
tlk-driver: Enable nvdec clock if defined in device tree 2018-10-11T08:03:39+00:00 Mikko Perttunen mperttunen@nvidia.com 2018-07-09T07:27:15+00:00 a3811645322b7c0b9eb3d7dee63157d92ed93369 On Shield devices, a trusted application wants to asynchronously (without kernel knowledge) access NVDEC registers. As such, the NVDEC clock needs to be kept enabled. Add code to enable the NVDEC clock on probe if defined in the device tree. Also deassert the reset. Bug 200422563 Jira HOSTX-348 Change-Id: I44f23a3ec48b1de1bccc4d6c318f47c1475b35fb Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1842475 Reviewed-on: https://git-master.nvidia.com/r/1919899 GVS: Gerrit_Virtual_Submit Reviewed-by: Mahesh Lagadapati <mlagadapati@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
On Shield devices, a trusted application wants to asynchronously
(without kernel knowledge) access NVDEC registers. As such, the
NVDEC clock needs to be kept enabled.

Add code to enable the NVDEC clock on probe if defined in the
device tree. Also deassert the reset.

Bug 200422563
Jira HOSTX-348

Change-Id: I44f23a3ec48b1de1bccc4d6c318f47c1475b35fb
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1842475
Reviewed-on: https://git-master.nvidia.com/r/1919899
GVS: Gerrit_Virtual_Submit
Reviewed-by: Mahesh Lagadapati <mlagadapati@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
ote_device: reduce verbosity of TLK print 2018-02-24T05:02:42+00:00 Mihir Joshi mihirj@nvidia.com 2017-12-18T19:23:13+00:00 a12d57be92f0daa6558d5bf448d6ff05fc648fab Due to run time TOS detection support, we need to verify whether TLK node is enabled in the DT or not before any TOS related operation. For that, get_tlk_device_node() API is used internally. If TLK node is not present it outputs an error message in dmesg which has no relevance from end user's POV. This change reduces verbosity of that message so that it doesn't spam the UART if non-TLK TOS is flashed. Bug 200366478 Tests GVS Change-Id: I304f0d87930c3725e5babde0643903d7a4f0e0e5 Signed-off-by: Mihir Joshi <mihirj@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1620551 (cherry picked from commit 0a36a2beca5c7dffc7dac2cc406099a4d1ffaac3) Reviewed-on: https://git-master.nvidia.com/r/1654617 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Varun Wadekar <vwadekar@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Due to run time TOS detection support, we need to verify whether TLK
node is enabled in the DT or not before any TOS related operation.

For that, get_tlk_device_node() API is used internally. If TLK node is not
present it outputs an error message in dmesg which has no relevance from
end user's POV.

This change reduces verbosity of that message so that it doesn't spam the
UART if non-TLK TOS is flashed.

Bug 200366478
Tests GVS

Change-Id: I304f0d87930c3725e5babde0643903d7a4f0e0e5
Signed-off-by: Mihir Joshi <mihirj@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1620551
(cherry picked from commit 0a36a2beca5c7dffc7dac2cc406099a4d1ffaac3)
Reviewed-on: https://git-master.nvidia.com/r/1654617
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Varun Wadekar <vwadekar@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
security: tlk: rename send_smc to tlk_send_smc 2018-01-27T04:56:06+00:00 Daniel Fu danifu@nvidia.com 2017-10-26T07:07:18+00:00 c1f4b06e9ae4a2e32643d004962c2ab49a572589 Rename the send_smc() to handle the multiple definition build failure. drivers/built-in.o: In function `send_smc': kernel-4.4/drivers/platform/tegra/pm_debugfs.c:57: multiple definition of `send_smc' security/built-in.o: nvidia/security/tlk_driver/ote_comms.c:118: first defined here Bug 2008213 Change-Id: Ib661a6a10a4160c573454b84d146aa216ca611ba Signed-off-by: Daniel Fu <danifu@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1606709 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Rename the send_smc() to handle the multiple definition
build failure.

drivers/built-in.o: In function `send_smc':
kernel-4.4/drivers/platform/tegra/pm_debugfs.c:57:
	multiple definition of `send_smc'
security/built-in.o:
nvidia/security/tlk_driver/ote_comms.c:118:
	first defined here

Bug 2008213

Change-Id: Ib661a6a10a4160c573454b84d146aa216ca611ba
Signed-off-by: Daniel Fu <danifu@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1606709
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
security: tlk_driver: enable TLK node based on DT 2017-11-01T07:06:57+00:00 Mihir Joshi mihirj@nvidia.com 2017-08-17T00:49:39+00:00 a838d2d49502a47a4135f40758ad1eae400a1e3f Due to run time TOS detection, bootloader patches kernel DTB based on the flashed TOS image. It updates DTB with status = "okay" whereas traditional TLK driver checked for status = "enabled". This patch checks the DTB status property for TLK node before registering the device. Also, this patch updates get_tlk_device_node method to honor the status mentioned in DT. Bug 200334066 Bug 1961076 Tests GVS Change-Id: If26f8596c8420453f06d1d4cf3788f413a2dfc41 Reviewed-on: https://git-master.nvidia.com/r/1539947 Signed-off-by: Mihir Joshi <mihirj@nvidia.com> (cherry picked from commit 1e11f87bd9c831d866fddf24216fc337bac8ca9f) Reviewed-on: https://git-master.nvidia.com/r/1587183 Reviewed-by: Mahesh Lagadapati <mlagadapati@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Due to run time TOS detection, bootloader patches kernel DTB based on
the flashed TOS image. It updates DTB with status = "okay" whereas
traditional TLK driver checked for status = "enabled".

This patch checks the DTB status property for TLK node before registering
the device.
Also, this patch updates get_tlk_device_node method to honor the status
mentioned in DT.

Bug 200334066
Bug 1961076
Tests GVS

Change-Id: If26f8596c8420453f06d1d4cf3788f413a2dfc41
Reviewed-on: https://git-master.nvidia.com/r/1539947
Signed-off-by: Mihir Joshi <mihirj@nvidia.com>
(cherry picked from commit 1e11f87bd9c831d866fddf24216fc337bac8ca9f)
Reviewed-on: https://git-master.nvidia.com/r/1587183
Reviewed-by: Mahesh Lagadapati <mlagadapati@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
tegra-se: fix uninitialized variable error 2017-09-26T18:09:26+00:00 Shravani Dingari shravanid@nvidia.com 2017-09-13T11:49:11+00:00 40c31a756dcb005450be53650cc803fa16ffd189 initialize pointer variable that fixes uninitialized variable error Change-Id: I89a248242aa5540e302ac353181ab41614ce3533 Signed-off-by: Shravani Dingari <shravanid@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1559050 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Mallikarjun Kasoju <mkasoju@nvidia.com> Reviewed-by: Venu Byravarasu <vbyravarasu@nvidia.com> 
initialize pointer variable that fixes uninitialized
variable error

Change-Id: I89a248242aa5540e302ac353181ab41614ce3533
Signed-off-by: Shravani Dingari <shravanid@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1559050
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
Reviewed-by: Venu Byravarasu <vbyravarasu@nvidia.com>