nvidia-tegra-modules.git/security/tlk_driver/ote_comms.c, branch rtss22-ae NVIDIA's kernel modules to support tegra chips (used in Jetson boards) tlk_driver: print stating result_origin override 2019-04-20T06:43:19+00:00 Stephen Wolfe swolfe@nvidia.com 2019-04-19T00:33:05+00:00 07e24275f898e43481deb70c27d894544db32e87 Under certain situations, TLK kernel may return an error code _without_ updating the shared request buffer. In the TLK driver we override the result_origin field when this occurs. This commit adds an error print if this override logic occurs. Bug 200500073 Change-Id: Ie91c8016e28597ef3bbdf9580233c35943e9f365 Signed-off-by: Stephen Wolfe <swolfe@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2100860 Reviewed-by: Mihir Joshi <mihirj@nvidia.com> Reviewed-by: Pranami Bhattacharya <pranamib@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Under certain situations, TLK kernel may return an error code
_without_ updating the shared request buffer. In the TLK driver
we override the result_origin field when this occurs.

This commit adds an error print if this override logic occurs.

Bug 200500073

Change-Id: Ie91c8016e28597ef3bbdf9580233c35943e9f365
Signed-off-by: Stephen Wolfe <swolfe@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2100860
Reviewed-by: Mihir Joshi <mihirj@nvidia.com>
Reviewed-by: Pranami Bhattacharya <pranamib@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
ote_comms: Add more debug information 2019-04-02T12:29:08+00:00 pranamib pranamib@nvidia.com 2019-03-27T00:55:10+00:00 09a2a8e500aff4cbe43be83746e770e276aadc2e Print request->result_origin in case of error to know more about the origin of the error Bug 200500073 Change-Id: Ia472f287d84b36533ba1ae11a8bbe9c92ad9fb49 Signed-off-by: pranamib <pranamib@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2082371 Reviewed-by: Stephen Wolfe <swolfe@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Vinayak Pane <vpane@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Print request->result_origin in case of error to know more about
the origin of the error

Bug 200500073

Change-Id: Ia472f287d84b36533ba1ae11a8bbe9c92ad9fb49
Signed-off-by: pranamib <pranamib@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2082371
Reviewed-by: Stephen Wolfe <swolfe@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
tlk_driver: Remove the tsk_cpus_allowed() wrapper 2018-08-16T09:53:55+00:00 Joseph Lo josephl@nvidia.com 2018-08-14T02:13:35+00:00 c4ee6f84327724a65eef07c055c382e1aa4d5ef7 Regarding to the upstream commit "0c98d344fe5c sched/core: Remove the tsk_cpus_allowed() wrapper", do the same fix to align with main line linux kernel. Bug 200432223 Change-Id: Ic64f557ff41883c078251ee2076af5bd989fa1cb Signed-off-by: Joseph Lo <josephl@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1799239 Reviewed-by: Stephen Wolfe <swolfe@nvidia.com> Tested-by: Stephen Wolfe <swolfe@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Regarding to the upstream commit "0c98d344fe5c sched/core: Remove the
tsk_cpus_allowed() wrapper", do the same fix to align with main line
linux kernel.

Bug 200432223

Change-Id: Ic64f557ff41883c078251ee2076af5bd989fa1cb
Signed-off-by: Joseph Lo <josephl@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1799239
Reviewed-by: Stephen Wolfe <swolfe@nvidia.com>
Tested-by: Stephen Wolfe <swolfe@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
tlk_driver: propagate TLK error code to user-app 2018-08-07T19:13:48+00:00 Mihir Joshi mihirj@nvidia.com 2018-07-23T23:14:10+00:00 fe941adbc0463dabb94e94536dadb15f62908b0c Bug 2186806 Tests Tested locally by turning NS DRAM ranges feature ON/OFF and testing userspace binaries Change-Id: I52687f865cf205d158fbf2126c1bb0833ef772d2 Signed-off-by: Mihir Joshi <mihirj@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1784276 (cherry picked from commit e9dd22e4eddc803488d4f4d2315e23c1de9e2f01) Reviewed-on: https://git-master.nvidia.com/r/1793791 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Bug 2186806
Tests Tested locally by turning NS DRAM ranges feature ON/OFF and testing
      userspace binaries

Change-Id: I52687f865cf205d158fbf2126c1bb0833ef772d2
Signed-off-by: Mihir Joshi <mihirj@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1784276
(cherry picked from commit e9dd22e4eddc803488d4f4d2315e23c1de9e2f01)
Reviewed-on: https://git-master.nvidia.com/r/1793791
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
hdmivrr: vrr authentication 2018-04-10T20:43:32+00:00 Ishwarya Balaji Gururajan igururajan@nvidia.com 2018-02-19T20:55:37+00:00 83bc4258001563a464592e937aa88d1e6ffbbdf0 This change is to be in compliance with the VRR authentication and computation change in the VRR TA with two different commands: 1. CMD_VRR_AUTH and 2. CMD_VRR_SEC Also tegra_vrr struct is changed to be in sync with struct present in the VRR TA. Jira TDS-3382 Bug 2062211 Change-Id: Ib30fd34013a07bfbbcdf73266ec995a24b2d858f Signed-off-by: Ishwarya Balaji Gururajan <igururajan@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1662263 Reviewed-on: https://git-master.nvidia.com/r/1671484 (cherry picked from commit ef85a3536faf20f2e16be228547f2842af650a66) Reviewed-on: https://git-master.nvidia.com/r/1673634 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
This change is to be in compliance with the VRR authentication
and computation change in the VRR TA with two different commands:
1. CMD_VRR_AUTH and
2. CMD_VRR_SEC

Also tegra_vrr struct is changed to be in sync with struct present
in the VRR TA.

Jira TDS-3382
Bug 2062211

Change-Id: Ib30fd34013a07bfbbcdf73266ec995a24b2d858f
Signed-off-by: Ishwarya Balaji Gururajan <igururajan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1662263
Reviewed-on: https://git-master.nvidia.com/r/1671484
(cherry picked from commit ef85a3536faf20f2e16be228547f2842af650a66)
Reviewed-on: https://git-master.nvidia.com/r/1673634
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
tlk_driver: check TLK node before tlk_restore_keyslots 2018-02-24T05:02:38+00:00 Mihir Joshi mihirj@nvidia.com 2017-12-18T19:36:30+00:00 edd17ef5419150586ea36375b9dc8ebb47b54eb2 Currently, we call tlk_restore_keyslots even if TLK node is not enabled in DTB. This patch adds a check to not call the TLK SMC if detected TOS is not TLK Bug 200366892 Tests GVS Change-Id: I52b35f9398c8c9a6d0350640313794beeb20e23d Signed-off-by: Mihir Joshi <mihirj@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1620558 (cherry picked from commit 18f69d64ea4011f1db4f8f692d2129447da33c21) Reviewed-on: https://git-master.nvidia.com/r/1654616 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Varun Wadekar <vwadekar@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Currently, we call tlk_restore_keyslots even if TLK node is not enabled in
DTB.
This patch adds a check to not call the TLK SMC if detected TOS is not TLK

Bug 200366892
Tests GVS

Change-Id: I52b35f9398c8c9a6d0350640313794beeb20e23d
Signed-off-by: Mihir Joshi <mihirj@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1620558
(cherry picked from commit 18f69d64ea4011f1db4f8f692d2129447da33c21)
Reviewed-on: https://git-master.nvidia.com/r/1654616
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Varun Wadekar <vwadekar@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
security: tlk: rename send_smc to tlk_send_smc 2018-01-27T04:56:06+00:00 Daniel Fu danifu@nvidia.com 2017-10-26T07:07:18+00:00 c1f4b06e9ae4a2e32643d004962c2ab49a572589 Rename the send_smc() to handle the multiple definition build failure. drivers/built-in.o: In function `send_smc': kernel-4.4/drivers/platform/tegra/pm_debugfs.c:57: multiple definition of `send_smc' security/built-in.o: nvidia/security/tlk_driver/ote_comms.c:118: first defined here Bug 2008213 Change-Id: Ib661a6a10a4160c573454b84d146aa216ca611ba Signed-off-by: Daniel Fu <danifu@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1606709 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Rename the send_smc() to handle the multiple definition
build failure.

drivers/built-in.o: In function `send_smc':
kernel-4.4/drivers/platform/tegra/pm_debugfs.c:57:
	multiple definition of `send_smc'
security/built-in.o:
nvidia/security/tlk_driver/ote_comms.c:118:
	first defined here

Bug 2008213

Change-Id: Ib661a6a10a4160c573454b84d146aa216ca611ba
Signed-off-by: Daniel Fu <danifu@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1606709
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
security:tlk: rename te_restore_keyslots 2018-01-27T04:36:11+00:00 Pranami Bhattacharya pranamib@nvidia.com 2017-10-02T05:19:07+00:00 e87669fd0fd4064d8af6eeda4414300318527720 This patch removed unnecessary functions from ote_comms.c file. te_restore_keyslots which is a TOS specific function is renamed for both OSes as {tlk|trusty}_restore_keyslots and the caller is updated in a separate patch Bug 200346933 Change-Id: Ifdcf20844eb6345f33d19e7a39ce52fcfb89eba6 Signed-off-by: Pranami Bhattacharya <pranamib@nvidia.com> Signed-off-by: Daniel Fu <danifu@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1606708 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
This patch removed unnecessary functions from ote_comms.c file.

te_restore_keyslots which is a TOS specific function is renamed for
both OSes as {tlk|trusty}_restore_keyslots and the caller is updated
in a separate patch

Bug 200346933

Change-Id: Ifdcf20844eb6345f33d19e7a39ce52fcfb89eba6
Signed-off-by: Pranami Bhattacharya <pranamib@nvidia.com>
Signed-off-by: Daniel Fu <danifu@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1606708
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
ote_comms: Suffix tlk to the APIs 2018-01-27T04:26:05+00:00 Pranami Bhattacharya pranamib@nvidia.com 2017-09-20T22:48:25+00:00 7fde5fc76d5ba7c1adbfec7f94fe4d75487ebbdd Since we are supporting both trusty and TLK in the build and the same APIs are used for both, suffixing the TLK ones with the appropriate suffix. Bug 200346933 Change-Id: Id51a305e4f9960dbd417f52fdb1444a0e66a3ee0 Signed-off-by: Pranami Bhattacharya <pranamib@nvidia.com> (cherry picked from commit 5f000d612475d5a587d08d6c0926cecff7c20a38) Reviewed-on: https://git-master.nvidia.com/r/1606707 Reviewed-by: Automatic_Commit_Validation_User Tested-by: Daniel Fu <danifu@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Since we are supporting both trusty and TLK in the build and the same
APIs are used for both, suffixing the TLK ones with the appropriate
suffix.

Bug 200346933

Change-Id: Id51a305e4f9960dbd417f52fdb1444a0e66a3ee0
Signed-off-by: Pranami Bhattacharya <pranamib@nvidia.com>
(cherry picked from commit 5f000d612475d5a587d08d6c0926cecff7c20a38)
Reviewed-on: https://git-master.nvidia.com/r/1606707
Reviewed-by: Automatic_Commit_Validation_User
Tested-by: Daniel Fu <danifu@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
tegra-se: fix uninitialized variable error 2017-09-26T18:09:26+00:00 Shravani Dingari shravanid@nvidia.com 2017-09-13T11:49:11+00:00 40c31a756dcb005450be53650cc803fa16ffd189 initialize pointer variable that fixes uninitialized variable error Change-Id: I89a248242aa5540e302ac353181ab41614ce3533 Signed-off-by: Shravani Dingari <shravanid@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1559050 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Mallikarjun Kasoju <mkasoju@nvidia.com> Reviewed-by: Venu Byravarasu <vbyravarasu@nvidia.com> 
initialize pointer variable that fixes uninitialized
variable error

Change-Id: I89a248242aa5540e302ac353181ab41614ce3533
Signed-off-by: Shravani Dingari <shravanid@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1559050
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
Reviewed-by: Venu Byravarasu <vbyravarasu@nvidia.com>