nvidia-tegra-modules.git/include/media/capture.h, branch rtss22-ae NVIDIA's kernel modules to support tegra chips (used in Jetson boards) capture-vi: use separate ringbuffer to pass iova to rtcpu 2021-06-21T08:55:03+00:00 Kirill Artamonov kartamonov@nvidia.com 2021-06-15T00:11:28+00:00 6e262c637e5116e3057b73788c02358bafe2b725 Passing iova pointers using capture descriptor is not safe since usermode application can access them. Use additional ringbuffer shared between kernel and rtcpu to pass iova pointers securely. Related changes and bugfixes: Use permanent vmap mapping for VI capture descriptors. This should also improve performance and reduce fragmentation of kernel address space. Don't use relocs. Access descriptor like normal C structure. Remove unused parameter capture_data from tegra_channel to avoid confusing null pointer investigation when accidentally using it. Check for zero pin count at submit to avoid potential memory mapping leak which will happen if usermode submits same capture descriptor without waiting for completion. Reboot rtcpu if fail to communicate with rtcpu during channel release IVC call. Allocate fixed size unpin buffer at setup time istead of relying on kzalloc/kfree during each request. This is to simplify critical runtime codepath and remove flexible array struct member which is prohibited by MISRA C conventions. CAMASIL-7466 bug 2768992 bug 3231670 bug 200688288 bug 200690078 CAMASIL-7460 CAMASIL-7477 CAMASIL-4619 CAMASIL-7465 Change-Id: Ia39de887093bbc158c72008ae387287ce30ebd82 Signed-off-by: Kirill Artamonov <kartamonov@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2475799 (cherry picked from commit 71ad1f9d54a45e54767d5fa9411a4aee83374398) Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2545006 Reviewed-by: Igor Mitsyanko <imitsyanko@nvidia.com> Reviewed-by: Semi Malinen <smalinen@nvidia.com> Reviewed-by: Pekka Pessi <ppessi@nvidia.com> Reviewed-by: Mika Liljeberg <mliljeberg@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: Igor Mitsyanko <imitsyanko@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit 
Passing iova pointers using capture descriptor is not safe since
usermode application can access them.

Use additional ringbuffer shared between kernel and rtcpu to
pass iova pointers securely.

Related changes and bugfixes:

Use permanent vmap mapping for VI capture descriptors.
This should also improve performance and reduce fragmentation
of kernel address space.

Don't use relocs. Access descriptor like normal C structure.

Remove unused parameter capture_data from tegra_channel to
avoid confusing null pointer investigation when accidentally
using it.

Check for zero pin count at submit to avoid potential memory
mapping leak which will happen if usermode submits same capture
descriptor without waiting for completion.

Reboot rtcpu if fail to communicate with rtcpu during
channel release IVC call.

Allocate fixed size unpin buffer at setup time istead of
relying on kzalloc/kfree during each request. This is to simplify
critical runtime codepath and remove flexible array struct
member which is prohibited by MISRA C conventions.

CAMASIL-7466

bug 2768992
bug 3231670
bug 200688288
bug 200690078
CAMASIL-7460
CAMASIL-7477
CAMASIL-4619
CAMASIL-7465

Change-Id: Ia39de887093bbc158c72008ae387287ce30ebd82
Signed-off-by: Kirill Artamonov <kartamonov@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2475799
(cherry picked from commit 71ad1f9d54a45e54767d5fa9411a4aee83374398)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2545006
Reviewed-by: Igor Mitsyanko <imitsyanko@nvidia.com>
Reviewed-by: Semi Malinen <smalinen@nvidia.com>
Reviewed-by: Pekka Pessi <ppessi@nvidia.com>
Reviewed-by: Mika Liljeberg <mliljeberg@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: Igor Mitsyanko <imitsyanko@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
nvcapture: capture buffer management 2021-06-21T08:54:53+00:00 Ziqi Qing zqing@nvidia.com 2019-03-14T23:46:21+00:00 582806934788414445291cb103f8560bfd1618d6 Buffer management in KMD allow client to pin and setup a set of surface before any capture request. Also keep the compatibility to pin the surface when it is not registered before. - Add ioctl to handle buffer pin request. - Add capture buffer table. Bug 2462034 Change-Id: I71021a241aab4e61d27bd504fb5657b169e56643 Signed-off-by: Ziqi Qing <zqing@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1972655 (cherry picked from commit 05c14274b4070aaa0fd02f07166554d07ede85ec) Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2545282 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> Reviewed-by: Kirill Artamonov <kartamonov@nvidia.com> Reviewed-by: Igor Mitsyanko <imitsyanko@nvidia.com> Reviewed-by: Semi Malinen <smalinen@nvidia.com> Reviewed-by: Pekka Pessi <ppessi@nvidia.com> Reviewed-by: Mika Liljeberg <mliljeberg@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: Kirill Artamonov <kartamonov@nvidia.com> Tested-by: Igor Mitsyanko <imitsyanko@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit 
Buffer management in KMD allow client to pin and setup a set of surface
before any capture request. Also keep the compatibility to pin the
surface when it is not registered before.

- Add ioctl to handle buffer pin request.
- Add capture buffer table.

Bug 2462034

Change-Id: I71021a241aab4e61d27bd504fb5657b169e56643
Signed-off-by: Ziqi Qing <zqing@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1972655
(cherry picked from commit 05c14274b4070aaa0fd02f07166554d07ede85ec)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2545282
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: Kirill Artamonov <kartamonov@nvidia.com>
Reviewed-by: Igor Mitsyanko <imitsyanko@nvidia.com>
Reviewed-by: Semi Malinen <smalinen@nvidia.com>
Reviewed-by: Pekka Pessi <ppessi@nvidia.com>
Reviewed-by: Mika Liljeberg <mliljeberg@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: Kirill Artamonov <kartamonov@nvidia.com>
Tested-by: Igor Mitsyanko <imitsyanko@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
tegra: camera: add vi_channel_mask propagation 2018-09-06T23:12:44+00:00 Isaac Sy isy@nvidia.com 2018-08-17T03:49:30+00:00 c6abd6255cfc1f2e45515d308acfa73a76fe70cb Bug 2366452 Change-Id: Iefa543ff4c7bbf97964c41b39234480215189cc5 Signed-off-by: Isaac Sy <isy@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1801539 Tested-by: Vincent Chung <vincentc@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: David Bang <dbang@nvidia.com> Reviewed-by: Frank Chen <frankc@nvidia.com> Reviewed-by: Bhanu Murthy V <bmurthyv@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Bug 2366452

Change-Id: Iefa543ff4c7bbf97964c41b39234480215189cc5
Signed-off-by: Isaac Sy <isy@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1801539
Tested-by: Vincent Chung <vincentc@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: David Bang <dbang@nvidia.com>
Reviewed-by: Frank Chen <frankc@nvidia.com>
Reviewed-by: Bhanu Murthy V <bmurthyv@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
tegra: camera: Progress status buffer support 2018-08-23T17:53:21+00:00 Andrew Jiang andrewj@nvidia.com 2018-07-11T07:03:38+00:00 19fcb5e39cfba50310ed8324a42793ff3ac0738c Add necessary structs and ioctl calls to allow KMD to use a new progress status buffer allocated by UMD as a convenient way to communicate the status of each request. This is part of supporting the new detached mode mechanism. Bug 2173282 Change-Id: Id279af4e7541d3b9f30e0b68bc838d924e5ab234 Signed-off-by: Andrew Jiang <andrewj@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1750545 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Add necessary structs and ioctl calls to allow KMD to use a new
progress status buffer allocated by UMD as a convenient way to
communicate the status of each request. This is part of
supporting the new detached mode mechanism.

Bug 2173282

Change-Id: Id279af4e7541d3b9f30e0b68bc838d924e5ab234
Signed-off-by: Andrew Jiang <andrewj@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1750545
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
capture: vi/isp: Reset barrier in capture ivc 2018-07-24T21:26:13+00:00 Bhanu Murthy V bmurthyv@nvidia.com 2018-07-17T02:09:26+00:00 4444a23d76c2169b90ac550a2def6028ef01c208 Add capture reset barrier indication in the capture ivc channel in the reset sequence. This is to allow indication for RCE that the capture requests submitted before this event must be cleaned up and released. Bug 2258538 Bug 2047639 Bug 200430058 Change-Id: I51c43fb926eec305c09c4334492c4e238a8a22ff Signed-off-by: Bhanu Murthy V <bmurthyv@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1779659 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Add capture reset barrier indication in the capture
ivc channel in the reset sequence. This is to allow
indication for RCE that the capture requests submitted
before this event must be cleaned up and released.

Bug 2258538
Bug 2047639
Bug 200430058

Change-Id: I51c43fb926eec305c09c4334492c4e238a8a22ff
Signed-off-by: Bhanu Murthy V <bmurthyv@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1779659
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
media: platform: tegra: support capture error masks 2018-07-09T11:05:01+00:00 Kirill Artamonov kartamonov@nvidia.com 2018-05-23T16:42:01+00:00 8d8b24816277811a0014ff5a67fe98db9cd189e8 Pass correctable and incorrectable error action masks from UMD to rtcpu during capture setup. bug 2047638 CAMASIL-78 Change-Id: I79a15eeedb6dfc29d2e3339e94b734c8cdceb139 Signed-off-by: Kirill Artamonov <kartamonov@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1728317 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Pass correctable and incorrectable error action masks from UMD
to rtcpu during capture setup.

bug 2047638
CAMASIL-78

Change-Id: I79a15eeedb6dfc29d2e3339e94b734c8cdceb139
Signed-off-by: Kirill Artamonov <kartamonov@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1728317
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
media: tegra: camera: close nvcsi on client crash 2018-06-21T23:43:13+00:00 Vincent Chung vincentc@nvidia.com 2018-06-12T02:13:03+00:00 c8314513ca2e44bb1b421aa416ac2ebdd19c4a20 Add utility to cache the NVCSI stream and TPG virtual channel to properly close NVCSI resources through RCE, in the event that the NvCapture UMD client crashes w/o the opportunity to release them. Also remove inactive PHY stream reset IVC cases. Bug 2179959 Change-Id: Ib522f629b9bdaf10acfaaa2a80d6054dbce43225 Signed-off-by: Vincent Chung <vincentc@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1746815 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Bhanu Murthy V <bmurthyv@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Add utility to cache the NVCSI stream and TPG virtual channel to
properly close NVCSI resources through RCE, in the event that the
NvCapture UMD client crashes w/o the opportunity to release them.

Also remove inactive PHY stream reset IVC cases.

Bug 2179959

Change-Id: Ib522f629b9bdaf10acfaaa2a80d6054dbce43225
Signed-off-by: Vincent Chung <vincentc@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1746815
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bhanu Murthy V <bmurthyv@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
media: tegra: update vi_capture_setup structure 2018-05-17T21:13:06+00:00 Frank Chen frankc@nvidia.com 2018-05-08T22:38:59+00:00 4a8e63d9e984d46a11680f66ca7ae309f1b8c3af The 32bit mem is the RM handle passed from user mode and will be converted to 64bit virtual address later as iova. For v4l2 capture, we use iova directly since there is no user mode code involved. Since they are representing the same memory region for capture descriptor, change them to use union to avoid confusion. Jira CRTC-1446 Change-Id: I52c40a329b5635956a914a32fb30ab2a433693d8 Signed-off-by: Frank Chen <frankc@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1710827 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Chinniah Poosapadi <cpoosapadi@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Jon Mayo <jmayo@nvidia.com> Reviewed-by: Songhee Baek <sbaek@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
The 32bit mem is the RM handle passed from user mode
and will be converted to 64bit virtual address later
as iova.

For v4l2 capture, we use iova directly since there is
no user mode code involved.

Since they are representing the same memory region
for capture descriptor, change them to use union
to avoid confusion.

Jira CRTC-1446

Change-Id: I52c40a329b5635956a914a32fb30ab2a433693d8
Signed-off-by: Frank Chen <frankc@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1710827
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Chinniah Poosapadi <cpoosapadi@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Jon Mayo <jmayo@nvidia.com>
Reviewed-by: Songhee Baek <sbaek@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
media: tegra: camera: t19x rce vi5 support 2018-02-15T05:43:23+00:00 Vincent Chung vincentc@nvidia.com 2018-02-05T17:56:48+00:00 59c1ffc651aa549a38fca306371932a57b8996ee Add support for vi5 in the KMD for Xavier. * Memory pin/unpin are only required for user-space buffers Change-Id: Ifea45c6dc036429559127c6f4f6322e19773833b Signed-off-by: Vincent Chung <vincentc@nvidia.com> Signed-off-by: Bhanu Murthy V <bmurthyv@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1652195 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Frank Chen <frankc@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Add support for vi5 in the KMD for Xavier.
* Memory pin/unpin are only required for user-space buffers

Change-Id: Ifea45c6dc036429559127c6f4f6322e19773833b
Signed-off-by: Vincent Chung <vincentc@nvidia.com>
Signed-off-by: Bhanu Murthy V <bmurthyv@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1652195
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Frank Chen <frankc@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Revert "drivers: camera: RTCPU support for vi-mode" 2018-01-02T21:29:16+00:00 Frank Chen frankc@nvidia.com 2018-01-02T17:24:29+00:00 60becba8286d00ec9bef7715d86777a3b28888b1 Revert change due to kernel crash. Bug 200377184 This reverts commit a7a83d4c7ad2acfd26a21f50580f05ba01023dce. Change-Id: I72efc9af7dffb719c78d254c7218cd0350c8c911 Signed-off-by: Frank Chen <frankc@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1630198 Reviewed-by: Jihoon Bang <jbang@nvidia.com> GVS: Gerrit_Virtual_Submit 
Revert change due to kernel crash.

Bug 200377184

This reverts commit a7a83d4c7ad2acfd26a21f50580f05ba01023dce.

Change-Id: I72efc9af7dffb719c78d254c7218cd0350c8c911
Signed-off-by: Frank Chen <frankc@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1630198
Reviewed-by: Jihoon Bang <jbang@nvidia.com>
GVS: Gerrit_Virtual_Submit