nvidia-tegra-modules.git/drivers/net/wireless/bcmdhd, branch gpu-paging NVIDIA's kernel modules to support tegra chips (used in Jetson boards) bcmdhd: allow room for copying null termination 2021-01-08T21:54:33+00:00 Hans-Christian Noren Egtvedt hegtvedt@cisco.com 2019-09-23T12:29:12+00:00 ec87a1c81263562f33b74bec93ac6332cada81c6 Can be solved in more elegant ways, but this was the simplest modification. Also, str_len is in current code much smaller than BUF_SIZE. Solves building using GCC >= 8. Bug 2712282 Change-Id: I615ab3f3f6f20bf131bcb3ec150611f2b56b3e08 Signed-off-by: Jeremy Ho <jeremyh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2282796 Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Can be solved in more elegant ways, but this was the simplest
modification. Also, str_len is in current code much smaller than
BUF_SIZE.

Solves building using GCC >= 8.

Bug 2712282

Change-Id: I615ab3f3f6f20bf131bcb3ec150611f2b56b3e08
Signed-off-by: Jeremy Ho <jeremyh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2282796
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: use size of destination buffer when calling strncpy() 2021-01-08T21:54:21+00:00 Hans-Christian Noren Egtvedt hegtvedt@cisco.com 2019-09-23T12:25:29+00:00 f5f90a7e632ad1195f8bf0d391027436c5e16191 The length argument should always be limited by the destination size to avoid overflowing destination. Solves building using GCC >= 8. Bug 2712282 Change-Id: I05649c0ce198e63d2c36376f683b67f370689629 Signed-off-by: Jeremy Ho <jeremyh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2282794 Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> 
The length argument should always be limited by the destination size to
avoid overflowing destination.

Solves building using GCC >= 8.

Bug 2712282

Change-Id: I05649c0ce198e63d2c36376f683b67f370689629
Signed-off-by: Jeremy Ho <jeremyh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2282794
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: fix slab-out-of-bounds bug 2020-10-07T17:40:29+00:00 Shobek Sam Attupurath sattupurath@nvidia.com 2020-09-25T12:22:01+00:00 b91033aaaca42d7295aa139e396057da305cc2c4 With enabling KASAN, we got a bug about slab-out-of-bounds in bcm_mkiovar. We should round up the source buffer size to the word and the length update will take care of using it in 8-byte words. We used the ROUNDUP() api in the fix. Bug 3094055 Change-Id: I1801354382a07df2bee34e5a419261199ecf189c Signed-off-by: Jeremy Ho <jeremyh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2419757 Reviewed-by: automaticguardword <automaticguardword@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Shobek Attupurath <sattupurath@nvidia.com> Reviewed-by: Bibhay Ranjan <bibhayr@nvidia.com> Reviewed-by: Ashutosh Jha <ajha@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit 
With enabling KASAN, we got a bug about slab-out-of-bounds
in bcm_mkiovar. We should round up the source buffer size
to the word and the length update will take care of using
it in 8-byte words. We used the ROUNDUP() api in the fix.

Bug 3094055

Change-Id: I1801354382a07df2bee34e5a419261199ecf189c
Signed-off-by: Jeremy Ho <jeremyh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2419757
Reviewed-by: automaticguardword <automaticguardword@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Shobek Attupurath <sattupurath@nvidia.com>
Reviewed-by: Bibhay Ranjan <bibhayr@nvidia.com>
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
drivers: string handling 2020-05-13T19:40:41+00:00 dmitry pervushin dpervushin@nvidia.com 2020-05-11T17:30:26+00:00 f395c71b0997e9b6ed092078a31d76f02dad161e gcc9 is more strict about using strncpy... and in many cases it is right Replacing strncpy with strdup (when possible) or strlcpy Bug 2973859 Change-Id: I1283db0385d7b35f747d129d3963e8f293e83dc3 Signed-off-by: dmitry pervushin <dpervushin@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2342280 Reviewed-by: automaticguardword <automaticguardword@nvidia.com> Reviewed-by: Phoenix Jung <pjung@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
gcc9 is more strict about using strncpy... and in many cases it is right
Replacing strncpy with strdup (when possible) or strlcpy

Bug 2973859

Change-Id: I1283db0385d7b35f747d129d3963e8f293e83dc3
Signed-off-by: dmitry pervushin <dpervushin@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2342280
Reviewed-by: automaticguardword <automaticguardword@nvidia.com>
Reviewed-by: Phoenix Jung <pjung@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: Update wifi power mode based on preference 2020-02-08T01:38:53+00:00 Shobek Attupurath sattupurath@nvidia.com 2020-02-06T05:42:40+00:00 0674f53622cb1a09450a08d17aad3a624e9fe461 Issue: 1. Station does not need to be in connected state to apply preferred power mode 2. On state change power save mode always gets set to power save enabled due to delayed worker that gets triggered on state change Solution: 1. Remove CONNECTED state check to allow setting of preferred power save mode 2. Store preferred power save mode in cfg struct and check before scheduling delayed worker Bug 2781055 Change-Id: Ib3c746b45eff2eb5bbd3703b3026dd54c9013e44 Signed-off-by: Shobek Attupurath <sattupurath@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2290724 Reviewed-by: Nagaraj Annaiah <nannaiah@nvidia.com> Reviewed-by: Srinivas Ramachandran <srinivasra@nvidia.com> Reviewed-by: Ashutosh Jha <ajha@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: 1. Station does not need to be in connected state
          to apply preferred power mode
       2. On state change power save mode always gets set to
          power save enabled due to delayed worker that gets
          triggered on state change

Solution: 1. Remove CONNECTED state check to allow setting of
             preferred power save mode
          2. Store preferred power save mode in cfg struct and
             check before scheduling delayed worker

Bug 2781055

Change-Id: Ib3c746b45eff2eb5bbd3703b3026dd54c9013e44
Signed-off-by: Shobek Attupurath <sattupurath@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2290724
Reviewed-by: Nagaraj Annaiah <nannaiah@nvidia.com>
Reviewed-by: Srinivas Ramachandran <srinivasra@nvidia.com>
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: fix incorrect call of wl_bss_roaming_done 2019-04-23T15:48:34+00:00 Om Prakash Singh omp@nvidia.com 2019-04-17T10:50:46+00:00 3036d56ce99019befc1766072ea1d48b75ebc925 Issue: wl_bss_roaming_done is getting called from wl_notify_connect_status even roaming is not enabled. wl_bss_roaming_done call should be only due to event from fw WLC_E_ROAM Fix: remove wl_bss_roaming_done from wl_notify_connect_status Bug 200509944 Change-Id: Iad47c0f57016b20fce4ed04471b7f84fab237e67 Signed-off-by: Om Prakash Singh <omp@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2099490 Reviewed-by: Mohan Thadikamalla <mohant@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Ashutosh Jha <ajha@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: wl_bss_roaming_done is getting called from wl_notify_connect_status
    even roaming is not enabled. wl_bss_roaming_done call should be only
    due to event from fw WLC_E_ROAM

Fix: remove wl_bss_roaming_done from wl_notify_connect_status

Bug  200509944

Change-Id: Iad47c0f57016b20fce4ed04471b7f84fab237e67
Signed-off-by: Om Prakash Singh <omp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2099490
Reviewed-by: Mohan Thadikamalla <mohant@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: Add fix to nv scan done and scan request 2019-02-05T03:58:24+00:00 nannaiah nannaiah@nvidia.com 2019-01-16T18:49:15+00:00 7d015d5f8eb2de37805496cf74b4b1e7440d0615 1.Reorganize wifi scan done to handle error and race conditions. 2.Schedule workqueue only after scan rules are filled. NvTag: NvScan NvFeature: Scan Policy Bug 200467503 Change-Id: I49ee91d426f63e95e4f6ca6b24b16edfcd6f8ac2 Signed-off-by: Nagaraj Annaiah <nannaiah@nvidia.com> Change-Id: I3f136fee04d05c3e03aec6bb5371a6de5284457a Reviewed-on: https://git-master.nvidia.com/r/2005876 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
1.Reorganize wifi scan done to handle error and race conditions.
2.Schedule workqueue only after scan rules are filled.

NvTag: NvScan
NvFeature: Scan Policy

Bug 200467503

Change-Id: I49ee91d426f63e95e4f6ca6b24b16edfcd6f8ac2

Signed-off-by: Nagaraj Annaiah <nannaiah@nvidia.com>
Change-Id: I3f136fee04d05c3e03aec6bb5371a6de5284457a
Reviewed-on: https://git-master.nvidia.com/r/2005876
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: fix connection issue reconnecting to new bss 2019-01-31T06:20:08+00:00 Om Prakash Singh omp@nvidia.com 2019-01-23T11:53:27+00:00 27e4ebe394f6592dc3951a81caae15ea9502bdb5 Issue: wdev->ssid_len is becoming 0, resulting to invalid bss object in sme.c. Below is warning error __cfg80211_connect_result+0x210/0x2a0 [cfg80211] cfg80211_process_wdev_events+0x154/0x1c0 [cfg80211] cfg80211_process_rdev_events+0x3c/0x80 [cfg80211] cfg80211_event_work+0x24/0x38 [cfg80211] process_one_work+0x1e0/0x478 worker_thread+0x58/0x4d0 kthread+0xfc/0x110 ret_from_fork+0x10/0x50 Fix: update wdev->ssid_len for new bss Bug 200481846 Bug 200489760 Change-Id: If2213a3e99aa1e1ee490c60bed2e4a3af9454a76 Signed-off-by: Om Prakash Singh <omp@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2007412 Reviewed-by: Ashutosh Jha <ajha@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: wdev->ssid_len is becoming 0, resulting to invalid bss
    object in sme.c. Below is warning error

__cfg80211_connect_result+0x210/0x2a0 [cfg80211]
cfg80211_process_wdev_events+0x154/0x1c0 [cfg80211]
cfg80211_process_rdev_events+0x3c/0x80 [cfg80211]
cfg80211_event_work+0x24/0x38 [cfg80211]
process_one_work+0x1e0/0x478
worker_thread+0x58/0x4d0
kthread+0xfc/0x110
ret_from_fork+0x10/0x50

Fix: update wdev->ssid_len for new bss

Bug 200481846
Bug 200489760

Change-Id: If2213a3e99aa1e1ee490c60bed2e4a3af9454a76
Signed-off-by: Om Prakash Singh <omp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2007412
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: fix disable roaming by default 2019-01-31T06:19:50+00:00 Om Prakash Singh omp@nvidia.com 2019-01-24T05:00:20+00:00 e3c95c260d71b9e8c6d411e53366ddf7032c85d7 Issue: roaming is enabled even builtin_roam_disabled is set DT Fix: update roam_off in dhd_preinit_ioctls based on builtin_roam_disabled value Bug 1895940 Bug 2484421 Change-Id: I403a91df93e0d44169bd20f98a37bb0cb9c72aa9 Signed-off-by: Om Prakash Singh <omp@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2002557 (cherry picked from commit af38a6a9da9de02ed1ee36a497ba7196aa4efbd7) Reviewed-on: https://git-master.nvidia.com/r/2006273 Reviewed-by: Mohan Thadikamalla <mohant@nvidia.com> Tested-by: Mohan Thadikamalla <mohant@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Vinayak Pane <vpane@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: roaming is enabled even builtin_roam_disabled is set DT

Fix: update roam_off in dhd_preinit_ioctls based on builtin_roam_disabled
     value

Bug 1895940
Bug 2484421

Change-Id: I403a91df93e0d44169bd20f98a37bb0cb9c72aa9
Signed-off-by: Om Prakash Singh <omp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2002557
(cherry picked from commit af38a6a9da9de02ed1ee36a497ba7196aa4efbd7)
Reviewed-on: https://git-master.nvidia.com/r/2006273
Reviewed-by: Mohan Thadikamalla <mohant@nvidia.com>
Tested-by: Mohan Thadikamalla <mohant@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: Handle scan error in scan policy 2019-01-31T06:16:25+00:00 nannaiah nannaiah@nvidia.com 2019-01-10T08:18:41+00:00 27a779e2ea8ccc8a0617c093dce7530c5dda7f78 Issue: When interface is down the wl_cfg80211_scan function returns error and if not handled this causes consistent scan failures. Fix: Add call to TEGRA_SCAN_DONE when scan function returns an error and clean up workqueue when active scan rules is zero. Bug 200472884 Change-Id: I361ff6419743aef9df2d7680e7793806b2a82954 Signed-off-by: Nagaraj Annaiah <nannaiah@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1990171 (cherry picked from commit 33d5eab52477c818ce88315dd7463c6376db3822) Reviewed-on: https://git-master.nvidia.com/r/1997810 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> Reviewed-by: Mohan Thadikamalla <mohant@nvidia.com> Reviewed-by: Om Prakash Singh <omp@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Vinayak Pane <vpane@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: When interface is down the wl_cfg80211_scan function returns error
       and if not handled this causes consistent scan failures.

Fix: Add call to TEGRA_SCAN_DONE when scan function returns an error and
     clean up workqueue when active scan rules is zero.

Bug 200472884

Change-Id: I361ff6419743aef9df2d7680e7793806b2a82954
Signed-off-by: Nagaraj Annaiah <nannaiah@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1990171
(cherry picked from commit 33d5eab52477c818ce88315dd7463c6376db3822)
Reviewed-on: https://git-master.nvidia.com/r/1997810
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: Mohan Thadikamalla <mohant@nvidia.com>
Reviewed-by: Om Prakash Singh <omp@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>