nvidia-tegra-modules.git/drivers/net/wireless/bcmdhd/dhd_common.c, branch rtss22-ae NVIDIA's kernel modules to support tegra chips (used in Jetson boards) bcmdhd: allow room for copying null termination 2021-01-08T21:54:33+00:00 Hans-Christian Noren Egtvedt hegtvedt@cisco.com 2019-09-23T12:29:12+00:00 ec87a1c81263562f33b74bec93ac6332cada81c6 Can be solved in more elegant ways, but this was the simplest modification. Also, str_len is in current code much smaller than BUF_SIZE. Solves building using GCC >= 8. Bug 2712282 Change-Id: I615ab3f3f6f20bf131bcb3ec150611f2b56b3e08 Signed-off-by: Jeremy Ho <jeremyh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2282796 Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Can be solved in more elegant ways, but this was the simplest
modification. Also, str_len is in current code much smaller than
BUF_SIZE.

Solves building using GCC >= 8.

Bug 2712282

Change-Id: I615ab3f3f6f20bf131bcb3ec150611f2b56b3e08
Signed-off-by: Jeremy Ho <jeremyh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2282796
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: fix slab-out-of-bounds bug 2020-10-07T17:40:29+00:00 Shobek Sam Attupurath sattupurath@nvidia.com 2020-09-25T12:22:01+00:00 b91033aaaca42d7295aa139e396057da305cc2c4 With enabling KASAN, we got a bug about slab-out-of-bounds in bcm_mkiovar. We should round up the source buffer size to the word and the length update will take care of using it in 8-byte words. We used the ROUNDUP() api in the fix. Bug 3094055 Change-Id: I1801354382a07df2bee34e5a419261199ecf189c Signed-off-by: Jeremy Ho <jeremyh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2419757 Reviewed-by: automaticguardword <automaticguardword@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Shobek Attupurath <sattupurath@nvidia.com> Reviewed-by: Bibhay Ranjan <bibhayr@nvidia.com> Reviewed-by: Ashutosh Jha <ajha@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit 
With enabling KASAN, we got a bug about slab-out-of-bounds
in bcm_mkiovar. We should round up the source buffer size
to the word and the length update will take care of using
it in 8-byte words. We used the ROUNDUP() api in the fix.

Bug 3094055

Change-Id: I1801354382a07df2bee34e5a419261199ecf189c
Signed-off-by: Jeremy Ho <jeremyh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2419757
Reviewed-by: automaticguardword <automaticguardword@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Shobek Attupurath <sattupurath@nvidia.com>
Reviewed-by: Bibhay Ranjan <bibhayr@nvidia.com>
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
drivers: string handling 2020-05-13T19:40:41+00:00 dmitry pervushin dpervushin@nvidia.com 2020-05-11T17:30:26+00:00 f395c71b0997e9b6ed092078a31d76f02dad161e gcc9 is more strict about using strncpy... and in many cases it is right Replacing strncpy with strdup (when possible) or strlcpy Bug 2973859 Change-Id: I1283db0385d7b35f747d129d3963e8f293e83dc3 Signed-off-by: dmitry pervushin <dpervushin@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2342280 Reviewed-by: automaticguardword <automaticguardword@nvidia.com> Reviewed-by: Phoenix Jung <pjung@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
gcc9 is more strict about using strncpy... and in many cases it is right
Replacing strncpy with strdup (when possible) or strlcpy

Bug 2973859

Change-Id: I1283db0385d7b35f747d129d3963e8f293e83dc3
Signed-off-by: dmitry pervushin <dpervushin@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2342280
Reviewed-by: automaticguardword <automaticguardword@nvidia.com>
Reviewed-by: Phoenix Jung <pjung@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: update Wifi stats to versoin 3.2 2019-01-17T14:47:17+00:00 Om Prakash Singh omp@nvidia.com 2018-08-08T16:35:04+00:00 66ba76ef032785abc45c139f1445224b60bab4d8 Below is new addions 1) set_ssid failure count 2) 4whs msg retry count 3) bucketize rssi level 4) bucketize bw_est level Bug 2293222 Change-Id: I19e05aa016c5a9e0ad4523726ff2e98abfa14c6b Signed-off-by: Om Prakash Singh <omp@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1812364 (cherry picked from commit ec141f9a18877ebf849a6de66d6dc0dfa8103831) Reviewed-on: https://git-master.nvidia.com/r/1988967 Reviewed-by: Rakesh Goyal <rgoyal@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Ashutosh Jha <ajha@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Below is new addions
 1) set_ssid failure count
 2) 4whs msg retry count
 3) bucketize rssi level
 4) bucketize bw_est level

Bug 2293222

Change-Id: I19e05aa016c5a9e0ad4523726ff2e98abfa14c6b
Signed-off-by: Om Prakash Singh <omp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1812364
(cherry picked from commit ec141f9a18877ebf849a6de66d6dc0dfa8103831)
Reviewed-on: https://git-master.nvidia.com/r/1988967
Reviewed-by: Rakesh Goyal <rgoyal@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: fix crash in dhd_wl_ioctl 2019-01-17T14:47:14+00:00 Om Prakash Singh omp@nvidia.com 2018-08-11T19:52:31+00:00 2b4bfc07ab5a4ab587fb8672592c33c50cc01ff9 Issue: crash due to accessing user buffer directly dhd_wl_ioctl+0x134/0x448 [bcmdhd] dhd_ioctl_process+0xec/0x1d8 [bcmdhd] dhd_ioctl_entry+0x43c/0x590 [bcmdhd] dev_ifsioc+0x280/0x320 dev_ioctl+0x13c/0x5f8 Fix: Use buffer that allocated for copy_from_user Bug 2321150 Change-Id: I39bae5c39f078cb436a0b9d079fb0e6150c14221 Signed-off-by: Om Prakash Singh <omp@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1801955 (cherry picked from commit a4af4685d660a770417259b6274d6d2c37e9f69b) Reviewed-on: https://git-master.nvidia.com/r/1988966 Reviewed-by: Rakesh Goyal <rgoyal@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Ashutosh Jha <ajha@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: crash due to accessing user buffer directly
    dhd_wl_ioctl+0x134/0x448 [bcmdhd]
    dhd_ioctl_process+0xec/0x1d8 [bcmdhd]
    dhd_ioctl_entry+0x43c/0x590 [bcmdhd]
    dev_ifsioc+0x280/0x320
    dev_ioctl+0x13c/0x5f8

Fix: Use buffer that allocated for copy_from_user

Bug 2321150
Change-Id: I39bae5c39f078cb436a0b9d079fb0e6150c14221
Signed-off-by: Om Prakash Singh <omp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1801955
(cherry picked from commit a4af4685d660a770417259b6274d6d2c37e9f69b)
Reviewed-on: https://git-master.nvidia.com/r/1988966
Reviewed-by: Rakesh Goyal <rgoyal@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
net: wireless: bcmdhd: Load clm blob path from DT 2018-12-19T05:57:49+00:00 Srinivas Ramachandran srinivasra@nvidia.com 2018-09-01T00:12:39+00:00 91f056e78e0707901e0c934de57c4b292e8a4337 Issue: clm.blob file path on DUT is provided either via driver module param or build defconfig. For flexibility to use different target path on various specific FS structures with same driver, need a way to specify the file path per platform. Fix: Initialize the clm.blob file path from DT. Bug 2090899 Change-Id: I68e35a77791890db3aeacbd1fde889d0b7ff36fd Signed-off-by: Srinivas Ramachandran <srinivasra@nvidia.com> (cherry picked from commit bcff98542a48aa4f109a5c3a5090aeb0fe3676b7) Signed-off-by: Shobek Sam Attupurath <sattupurath@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1849476 (cherry picked from commit 910789b6444049c784833a8c1ae03d826250a062) Reviewed-on: https://git-master.nvidia.com/r/1933927 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: clm.blob file path on DUT is provided either via driver
       module param or build defconfig. For flexibility to use
       different target path on various specific FS structures
       with same driver, need a way to specify the file path
       per platform.

Fix:   Initialize the clm.blob file path from DT.

Bug 2090899

Change-Id: I68e35a77791890db3aeacbd1fde889d0b7ff36fd
Signed-off-by: Srinivas Ramachandran <srinivasra@nvidia.com>
(cherry picked from commit bcff98542a48aa4f109a5c3a5090aeb0fe3676b7)
Signed-off-by: Shobek Sam Attupurath <sattupurath@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1849476
(cherry picked from commit 910789b6444049c784833a8c1ae03d826250a062)
Reviewed-on: https://git-master.nvidia.com/r/1933927
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
net: wireless: bcmdhd: Add support for clm.blob 2018-12-19T05:57:40+00:00 Prasanna Kerekoppa Prasanna.Kerekoppa@cypress.com 2018-07-27T00:55:50+00:00 dbf7cccd63417203cf230237e5407ebc53437403 Issue: Currently CLM table is built into the wifi firmware. Thus any changes in CLM table/creation of new CLM table for any product/customer requires spinning a separate firmware build. Supporting several FW build requests was not scalable for vendor. Hence Cypress have designed a new architecture to build and load clm as a separate blob file from firmware. Fix: Cypress provided DHD patch to support loading clm.blob file after loading firmware to chip, in Mycase 403591. With this patch, firmware with built-in clm works as is, firmware with external clm.blob has to be used with corresponding products clm.blob in CONFIG_BCMDHD_CLM_PATH. If clm.blob file is not present on DUT, once firmware is loaded driver validates currently set country code in fw. If it is not valid (true for cases like firmware which do not have built-in CLM), then driver aborts wifi initialization. Bug 2090899 Change-Id: If03d3898ef5d95bc5e03b67d5b14c8c51693713b Signed-off-by: Srinivas Ramachandran <srinivasra@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1787167 (cherry picked from commit 29fb503be68b66558c9274b53769dbcb80765dff) Signed-off-by: Shobek Sam Attupurath <sattupurath@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1849475 (cherry picked from commit 4a970b1c9dffa9a366f346e68ed4c02d2f9a0878) Reviewed-on: https://git-master.nvidia.com/r/1933926 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: Currently CLM table is built into the wifi firmware.
       Thus any changes in CLM table/creation of new CLM
       table for any product/customer requires spinning
       a separate firmware build. Supporting several FW
       build requests was not scalable for vendor. Hence
       Cypress have designed a new architecture to build
       and load clm as a separate blob file from firmware.

Fix:   Cypress provided DHD patch to support loading clm.blob
       file after loading firmware to chip, in Mycase 403591.
       With this patch, firmware with built-in clm works as is,
       firmware with external clm.blob has to be used with
       corresponding products clm.blob in CONFIG_BCMDHD_CLM_PATH.
       If clm.blob file is not present on DUT, once firmware
       is loaded driver validates currently set country code in fw.
       If it is not valid (true for cases like firmware which do not
       have built-in CLM), then driver aborts wifi initialization.

Bug 2090899

Change-Id: If03d3898ef5d95bc5e03b67d5b14c8c51693713b
Signed-off-by: Srinivas Ramachandran <srinivasra@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1787167
(cherry picked from commit 29fb503be68b66558c9274b53769dbcb80765dff)
Signed-off-by: Shobek Sam Attupurath <sattupurath@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1849475
(cherry picked from commit 4a970b1c9dffa9a366f346e68ed4c02d2f9a0878)
Reviewed-on: https://git-master.nvidia.com/r/1933926
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
bcmdhd: save the firmware events in a file 2018-10-19T10:52:14+00:00 Bibhay Ranjan bibhayr@nvidia.com 2016-02-11T21:33:46+00:00 7cbeb4c0e6e327f469f40e7814f168fe3761f4e2 NvFeature: IDS Bug 200173848 Change-Id: Id359c0a8b811d03383aaab6fef5642d90613eb5a Signed-off-by: Bibhay Ranjan <bibhayr@nvidia.com> Reviewed-on: http://git-master/r/1011951 Reviewed-on: https://git-master.nvidia.com/r/1807213 Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> Reviewed-by: Bitan Biswas <bbiswas@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1925164 Reviewed-by: Ishan Srivastava <isrivastava@nvidia.com> Tested-by: Ishan Srivastava <isrivastava@nvidia.com> 
NvFeature: IDS

Bug 200173848

Change-Id: Id359c0a8b811d03383aaab6fef5642d90613eb5a
Signed-off-by: Bibhay Ranjan <bibhayr@nvidia.com>
Reviewed-on: http://git-master/r/1011951
Reviewed-on: https://git-master.nvidia.com/r/1807213
Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1925164
Reviewed-by: Ishan Srivastava <isrivastava@nvidia.com>
Tested-by: Ishan Srivastava <isrivastava@nvidia.com>
bcmdhd: Copy bcmdhd driver from rel-30 kernel-4.9 2018-08-02T13:15:04+00:00 Manikanta Maddireddy mmaddireddy@nvidia.com 2018-07-31T03:50:15+00:00 3a13ebe7d4f8195547441a181078b6ac608e8c33 Copy bcmdhd driver from rel-30 kernel-4.9, top commit of the driver is https://git-master.nvidia.com/r/#/c/1785761/. 189db8da83b6 net: wireless: bcmdhd: remove obsoleted \ wl_cfgvendor_priv_string_handler bug 200421308 Change-Id: I14b2fd0540cbb0b9227cd928383d1b5c88657d55 Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1784156 GVS: Gerrit_Virtual_Submit Reviewed-by: Narayan Reddy <narayanr@nvidia.com> Reviewed-by: Om Prakash Singh <omp@nvidia.com> Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Copy bcmdhd driver from rel-30 kernel-4.9, top commit of the driver is
https://git-master.nvidia.com/r/#/c/1785761/.
189db8da83b6 net: wireless: bcmdhd: remove obsoleted \
wl_cfgvendor_priv_string_handler

bug 200421308

Change-Id: I14b2fd0540cbb0b9227cd928383d1b5c88657d55
Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1784156
GVS: Gerrit_Virtual_Submit
Reviewed-by: Narayan Reddy <narayanr@nvidia.com>
Reviewed-by: Om Prakash Singh <omp@nvidia.com>
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>