nvidia-tegra-modules.git/drivers/net/can, branch gpu-paging NVIDIA's kernel modules to support tegra chips (used in Jetson boards) mttcan: Fix uninitialized stack variable. 2021-08-13T20:10:52+00:00 Achal Verma achalv@nvidia.com 2021-04-14T04:22:42+00:00 b476437caad5bb931afa75f0b1c5c7f4466ce24f Stack variable should be initialized before use. This fix coverity issue : 20384, 20383, 20382 Bug 200697818 Change-Id: Ibf6eab6c51f2348850bf3139146c513baf8657d0 Signed-off-by: Achal Verma <achalv@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2575317 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> Reviewed-by: Phoenix Jung <pjung@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Stack variable should be initialized before use.

This fix coverity issue : 20384, 20383, 20382

Bug 200697818

Change-Id: Ibf6eab6c51f2348850bf3139146c513baf8657d0
Signed-off-by: Achal Verma <achalv@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2575317
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: Phoenix Jung <pjung@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
kernel: configure tdc offset via sysfs 2020-03-05T12:54:31+00:00 abhijit abhijit@nvidia.com 2018-04-25T10:01:46+00:00 5cfe9a9f6e3d035f884cc72870d6ae84a21cb928 Adding support to configure tdc_offset in userspace via sysfs. TDC refers to transmitter delay compensation which shifts sample point based on tdc_offset value in sysfs. This needs to be configured when user is trying higher data bitrates > 2Mbps. Offset value is dependent on external transceiver connected to tegra mttcan. Bug 2810935 Change-Id: Ib88410ac3957f3792e3bb2e7836aa2ae57f8404d Signed-off-by: Shubhi Garg <shgarg@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2275807 Reviewed-by: automaticguardword <automaticguardword@nvidia.com> Reviewed-by: Bibek Basu <bbasu@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Adding support to configure tdc_offset in userspace via sysfs.
TDC refers to transmitter delay compensation which shifts sample point
based on tdc_offset value in sysfs. This needs to be configured when
user is trying higher data bitrates > 2Mbps. Offset value is dependent
on external transceiver connected to tegra mttcan.

Bug 2810935

Change-Id: Ib88410ac3957f3792e3bb2e7836aa2ae57f8404d
Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2275807
Reviewed-by: automaticguardword <automaticguardword@nvidia.com>
Reviewed-by: Bibek Basu <bbasu@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
net: can: mttcan: fix for variant 1-S 2019-11-07T20:14:07+00:00 Abhijit abhijit@nvidia.com 2019-07-25T11:16:48+00:00 5a7a5228de5f0b3819388f2ef96d422266d867bf This patch adds speculative barrier to all the places where user provided index is used to store user provided data in order to prevent variant 1-S attack. Bug 200480085 Change-Id: I3bf42235dbd791592ee9227d98daed24983bbc88 Signed-off-by: Abhijit <abhijit@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2161202 Reviewed-by: Vipin Kumar <vipink@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Sandeep Trasi <strasi@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> (cherry picked from commit b3152e1eb9f746c5c5a5580f1aa15cfa590cf514) Reviewed-on: https://git-master.nvidia.com/r/2231470 Reviewed-by: Achal Verma <achalv@nvidia.com> Tested-by: Achal Verma <achalv@nvidia.com> Reviewed-by: Hardik T Shah <hardikts@nvidia.com> Reviewed-by: Hemant Pedanekar <hpedanekar@nvidia.com> 
This patch adds speculative barrier to all the places where user
provided index is used to store user provided data in order to
prevent variant 1-S attack.

Bug 200480085

Change-Id: I3bf42235dbd791592ee9227d98daed24983bbc88
Signed-off-by: Abhijit <abhijit@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2161202
Reviewed-by: Vipin Kumar <vipink@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sandeep Trasi <strasi@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
(cherry picked from commit b3152e1eb9f746c5c5a5580f1aa15cfa590cf514)
Reviewed-on: https://git-master.nvidia.com/r/2231470
Reviewed-by: Achal Verma <achalv@nvidia.com>
Tested-by: Achal Verma <achalv@nvidia.com>
Reviewed-by: Hardik T Shah <hardikts@nvidia.com>
Reviewed-by: Hemant Pedanekar <hpedanekar@nvidia.com>
[Boot-KPI] Change to fix build while making eqos as module. 2019-03-15T18:43:20+00:00 achalv achalv@nvidia.com 2019-01-09T15:39:56+00:00 904c599ba7dafe90a428551130bdc443837662b5 Bug 200489191 Change-Id: I75357dd974a04494efdc0637f3ed5cbd78a97e00 Signed-off-by: Achal Verma <achalv@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2006527 Reviewed-by: Rahul Jain (SW-TEGRA) <rahuljain@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-on: https://git-master.nvidia.com/r/2070549 Reviewed-by: Dmitry Pervushin <dpervushin@nvidia.com> Reviewed-by: Hardik T Shah <hardikts@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Bug 200489191
Change-Id: I75357dd974a04494efdc0637f3ed5cbd78a97e00
Signed-off-by: Achal Verma <achalv@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2006527
Reviewed-by: Rahul Jain (SW-TEGRA) <rahuljain@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-on: https://git-master.nvidia.com/r/2070549
Reviewed-by: Dmitry Pervushin <dpervushin@nvidia.com>
Reviewed-by: Hardik T Shah <hardikts@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
net: can: mttcan: Changes for using FIFO mode only 2019-03-13T15:44:23+00:00 Abhijit abhijit@nvidia.com 2019-02-12T15:02:41+00:00 9dfc6bec8b8d322e582ccdd96bf26c838a2e5071 Currently we use both Buffer and FIFO mode for both Rx and Tx path. But according to Bosch Errata 21, there is problem with using both the modes on Tx path. This patch contains required changes that will help in moving to FIFO mode only. This patch doesn't change Rx/Tx path, but add more error checking in HW filter configuration path (via sysfs) in case we use only FIFO mode. Bug 200491948 Bug 200481176 Change-Id: I4873fb46b58a4f71a85d13f3bfcbcbb66f69d33d Signed-off-by: Abhijit <abhijit@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2017412 Reviewed-on: https://git-master.nvidia.com/r/2025543 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Phoenix Jung <pjung@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Currently we use both Buffer and FIFO mode for both Rx and Tx path.
But according to Bosch Errata 21, there is problem with using
both the modes on Tx path. This patch contains required changes
that will help in moving to FIFO mode only.

This patch doesn't change Rx/Tx path, but add more error checking
in HW filter configuration path (via sysfs) in case we use only
FIFO mode.

Bug 200491948
Bug 200481176

Change-Id: I4873fb46b58a4f71a85d13f3bfcbcbb66f69d33d
Signed-off-by: Abhijit <abhijit@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2017412
Reviewed-on: https://git-master.nvidia.com/r/2025543
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Phoenix Jung <pjung@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
net: can: mttcan: Fix HP message handling 2018-09-18T06:40:07+00:00 djoker abhijit@nvidia.com 2018-09-10T09:19:41+00:00 29065935d9e023891ec5664120f5ef753b0cfed3 Currently we always pass the received HP (High Priority) message as CAN FD packet to upper layer. This is incorrect handling as we can get both types (FD or non-FD packet) with High Priority. Fix is to pass correct packet (either FD or non-FD) to upper layer. Bug 200448178 Change-Id: Ib1b90c7eef9fa585a8bc477b846381f1fa070064 Signed-off-by: Abhijit <abhijit@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1817865 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Vipin Kumar <vipink@nvidia.com> Reviewed-by: Manoj Chourasia <mchourasia@nvidia.com> Reviewed-by: Sandeep Trasi <strasi@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Currently we always pass the received HP (High Priority) message as
CAN FD packet to upper layer. This is incorrect handling as we can
get both types (FD or non-FD packet) with High Priority.
Fix is to pass correct packet (either FD or non-FD) to upper layer.

Bug 200448178

Change-Id: Ib1b90c7eef9fa585a8bc477b846381f1fa070064
Signed-off-by: Abhijit <abhijit@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1817865
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Vipin Kumar <vipink@nvidia.com>
Reviewed-by: Manoj Chourasia <mchourasia@nvidia.com>
Reviewed-by: Sandeep Trasi <strasi@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
net: can: mttcan: replace cycle_t by u64 for k4.14 2018-07-20T14:56:53+00:00 Bitan Biswas bbiswas@nvidia.com 2018-07-19T14:41:23+00:00 f751845fb169f43317c0295fa559c0d3760973a5 k4.14 onwards cycle_t is replaced by u64. Fix corresponding build errors bug 200385931 bug 200381871 Change-Id: I62cf9f0ceb28209d6b458079fc39c54c3fd735ca Signed-off-by: Bitan Biswas <bbiswas@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1781741 GVS: Gerrit_Virtual_Submit Reviewed-by: Rakesh Babu Bodla <rbodla@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
k4.14 onwards cycle_t is replaced by u64. Fix corresponding
build errors

bug 200385931
bug 200381871

Change-Id: I62cf9f0ceb28209d6b458079fc39c54c3fd735ca
Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1781741
GVS: Gerrit_Virtual_Submit
Reviewed-by: Rakesh Babu Bodla <rbodla@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
kernel:nvidia:devices:disable nvseccan debug 2018-07-09T12:10:34+00:00 Yong Zhang yongz@nvidia.com 2018-07-05T10:07:29+00:00 16380577990fe76ac47497f7da0fd26a74473347 remove the debug message from the virtual CAN drive Bug 200415395 Change-Id: I469b1f8a9797eaac079700dc0f3f2db49d6c6207 Signed-off-by: Yong Zhang <yongz@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1771407 Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Bitan Biswas <bbiswas@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
remove the debug message from the virtual
CAN drive

Bug 200415395

Change-Id: I469b1f8a9797eaac079700dc0f3f2db49d6c6207
Signed-off-by: Yong Zhang <yongz@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1771407
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
mttcan : Fix transmit path handling 2018-06-21T13:34:06+00:00 abhijit abhijit@nvidia.com 2018-04-16T07:23:19+00:00 593b7293005fa49b5eef41e466b065eede264b18 Currently if space is not available in Tx buffer or fifo, we drop the tx packet. Instead of dropping the packets, we should inform upper layer that we can't take more packet now by stopping the tx queue. Once we have tx complete interrupt, we will start the tx queue again. Bug 200328436 Bug 200294531 Change-Id: Ided4c223c5415f7fbe074ad159c458f75c37401c Signed-off-by: Abhijit <abhijit@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1695841 Reviewed-by: Manoj Chourasia <mchourasia@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Vipin Kumar <vipink@nvidia.com> Reviewed-by: Sandeep Trasi <strasi@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Currently if space is not available in Tx buffer or fifo, we drop the
tx packet. Instead of dropping the packets, we should inform upper layer
that we can't take more packet now by stopping the tx queue. Once we
have tx complete interrupt, we will start the tx queue again.

Bug 200328436
Bug 200294531

Change-Id: Ided4c223c5415f7fbe074ad159c458f75c37401c
Signed-off-by: Abhijit <abhijit@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1695841
Reviewed-by: Manoj Chourasia <mchourasia@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vipin Kumar <vipink@nvidia.com>
Reviewed-by: Sandeep Trasi <strasi@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
mttcan: Fix controller restart crash 2018-04-03T13:04:40+00:00 abhijit abhijit@nvidia.com 2017-07-12T10:53:59+00:00 8e9e79f81010c17310f619ac5cf856331151f59b Issue: If controller is configured in restart mode and it goes to BUS OFF state, then kernel crash is observed. Currently while restarting the controller, we are reading the state from PSR register which reports the state as BUS OFF. In that case we are informing the upper layer again about BUS OFF state. This leads to rescheduling of can restart work which leads to crash. Fix: No need to call bus_off again in restart, that will be handled by bus_off irq. There is race condition ragarding CARRIER flag, that is not handled by CAN dev layer. Moved restart logic to driver to handle this. Bug 200293626 Change-Id: I179775f76e4e8739f4da6047d0282521a614f4a3 Signed-off-by: Abhijit <abhijit@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1517956 Reviewed-by: Manoj Chourasia <mchourasia@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Vipin Kumar <vipink@nvidia.com> Reviewed-by: Sandeep Trasi <strasi@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Issue: If controller is configured in restart mode and it goes to
BUS OFF state, then kernel crash is observed.
Currently while restarting the controller, we are reading the
state from PSR register which reports the state as BUS OFF. In that
case we are informing the upper layer again about BUS OFF state.
This leads to rescheduling of can restart work which leads to crash.

Fix: No need to call bus_off again in restart, that will be handled
by bus_off irq.

There is race condition ragarding CARRIER flag, that is not handled
by CAN dev layer. Moved restart logic to driver to handle this.

Bug 200293626

Change-Id: I179775f76e4e8739f4da6047d0282521a614f4a3
Signed-off-by: Abhijit <abhijit@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1517956
Reviewed-by: Manoj Chourasia <mchourasia@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vipin Kumar <vipink@nvidia.com>
Reviewed-by: Sandeep Trasi <strasi@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>