nvidia-tegra-modules.git/drivers/firmware/tegra/fwdebug.c, branch rtss22-ae NVIDIA's kernel modules to support tegra chips (used in Jetson boards) firmware: tegra: explicilty cast little-endians to uint32_t 2018-09-04T23:17:15+00:00 Timo Alho talho@nvidia.com 2018-09-03T12:47:13+00:00 233d8c34db47629c78f863ad29320dc4d404d005 The BPMP-FW firmware header uses little endian byte order in the command structs. However, the struct members are declared as uint32_t and sparse emits warnings as cpu_to_le32() return type is __le32. To avoid these warnings, cast the return value of cpu_to_le32() explicitly to uint32_t. It is arguable that more correct way to resolve the warnings would be to change the ABI header data types. However, this is unfavorable as the same header is shared across multiple operating systems and __le32 is not standard data type. Bug 200434802 Change-Id: I3b27b0086a7b6aeb9707e72c21e08bbf89fe8a7b Signed-off-by: Timo Alho <talho@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1811967 GVS: Gerrit_Virtual_Submit Reviewed-by: Sivaram Nair <sivaramn@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
The BPMP-FW firmware header uses little endian byte order in the
command structs. However, the struct members are declared as uint32_t
and sparse emits warnings as cpu_to_le32() return type is __le32.

To avoid these warnings, cast the return value of cpu_to_le32()
explicitly to uint32_t. It is arguable that more correct way to
resolve the warnings would be to change the ABI header data
types. However, this is unfavorable as the same header is shared
across multiple operating systems and __le32 is not standard data
type.

Bug 200434802

Change-Id: I3b27b0086a7b6aeb9707e72c21e08bbf89fe8a7b
Signed-off-by: Timo Alho <talho@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1811967
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
driver: bpmp: Add DTB check in fwdebug init 2018-08-23T06:07:14+00:00 Abhiroop Kaginalkar akaginalkar@nvidia.com 2018-07-20T07:41:21+00:00 cd758515cbac851a749cac3bf8a8a58a3859f09a The bpmp fw debugfs init is controlled by a Kconfig, irrespective of whether an active bpmp node is present in the device DTB. This change adds OF support to parse the "compatible" and "status" properties of the bpmp node and decide to initialize the bpmp fw debugfs based on that info. Bug 2268445 Change-Id: Ifd67fee90757af190eabf154b5a76d67a60e95ea Signed-off-by: Abhiroop Kaginalkar <akaginalkar@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1782755 (cherry picked from commit 6e87da084b76319e302c003a30c1a8d4c855767e) Reviewed-on: https://git-master.nvidia.com/r/1800422 Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
The bpmp fw debugfs init is controlled by a Kconfig,
irrespective of whether an active bpmp node is present
in the device DTB.
This change adds OF support to parse the "compatible"
and "status" properties of the bpmp node and decide to
initialize the bpmp fw debugfs based on that info.

Bug 2268445

Change-Id: Ifd67fee90757af190eabf154b5a76d67a60e95ea
Signed-off-by: Abhiroop Kaginalkar <akaginalkar@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1782755
(cherry picked from commit 6e87da084b76319e302c003a30c1a8d4c855767e)
Reviewed-on: https://git-master.nvidia.com/r/1800422
Reviewed-by: David Dastous St Hilaire <ddastoussthi@nvidia.com>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
firmware: tegra: increase debugfs buffer size 2018-07-20T17:15:41+00:00 Sivaram Nair sivaramn@nvidia.com 2018-07-19T18:00:32+00:00 debe0a6446b3e5183660b39afdaaf711848c09e8 Size increased from 128 KB to 256 KB for accomodating large files (such as device tree). Bug 1872026 Change-Id: Ib32cfa1fdeb72284954c609d7d678a8e512a4f2f Signed-off-by: Sivaram Nair <sivaramn@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1781847 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Aleksandr Frid <afrid@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Size increased from 128 KB to 256 KB for accomodating large files (such
as device tree).

Bug 1872026

Change-Id: Ib32cfa1fdeb72284954c609d7d678a8e512a4f2f
Signed-off-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1781847
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Aleksandr Frid <afrid@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
firmware: tegra: skip WARN_ON in bpmp_fwdebug_init 2018-05-30T12:37:45+00:00 Joseph Lo josephl@nvidia.com 2018-05-18T03:07:02+00:00 853de695e8d69365973e1d750efa8d3994e0fa5a The function "bpmp_init_mount" will be invoked unconditionally even we disabled BPMP support for Tegra210 shield platform. This will cause the warning message can not be avoided. So remove it. Bug 200412288 Change-Id: I7dac62ca2ce7ddb95577c22dab9f670e8424f845 Signed-off-by: Joseph Lo <josephl@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1723312 Reviewed-by: Timo Alho <talho@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Bitan Biswas <bbiswas@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
The function "bpmp_init_mount" will be invoked unconditionally even we
disabled BPMP support for Tegra210 shield platform. This will cause the
warning message can not be avoided. So remove it.

Bug 200412288

Change-Id: I7dac62ca2ce7ddb95577c22dab9f670e8424f845
Signed-off-by: Joseph Lo <josephl@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1723312
Reviewed-by: Timo Alho <talho@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
[firmware][tegra] Use hex format BPMP trace nodes 2018-02-15T05:42:25+00:00 Alex Frid afrid@nvidia.com 2018-01-30T06:57:49+00:00 bb3d5939686e79742b28e22d166b64752d3310c5 Since BPMP trace control nodes are bit-masks, hex format is more convenient. Change-Id: Iff27274fdbee22d52791eab2c20f2502a2475b1f Signed-off-by: Alex Frid <afrid@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1648505 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Sivaram Nair <sivaramn@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Since BPMP trace control nodes are bit-masks, hex format is more
convenient.

Change-Id: Iff27274fdbee22d52791eab2c20f2502a2475b1f
Signed-off-by: Alex Frid <afrid@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1648505
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
firmware: tegra: use soc/tegra/chip-id.h 2018-01-11T14:40:38+00:00 Timo Alho talho@nvidia.com 2018-01-10T13:45:33+00:00 b9f24cc0c4cd2d143527a920714f4e6dabc9d2a8 Use "soc/tegra/chip-id.h" in place "linux/tegra-soc.h" as the former is available on all current downstream kernel versions. Bug 200325739 Change-Id: I7f8359c82bd6ed24fe4dc430522dddb701fad844 Signed-off-by: Timo Alho <talho@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1635656 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Use "soc/tegra/chip-id.h" in place "linux/tegra-soc.h" as the former
is available on all current downstream kernel versions.

Bug 200325739

Change-Id: I7f8359c82bd6ed24fe4dc430522dddb701fad844
Signed-off-by: Timo Alho <talho@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1635656
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
clk: firmware: tegra: Extend BPMP clk debugfs 2018-01-11T09:08:11+00:00 Alex Frid afrid@nvidia.com 2018-01-06T05:19:23+00:00 8d14443ea556b516adec9c138e5302d6a15181cd Added BPMP clock debugfs extension node to pull into kernel debugfs all clocks that are exposed by BPMP, but not acquired by any driver, and add Tegra clock writable debugfs extensions that are available on non-BPMP Tegra platforms. Change-Id: I4a91684f10bcec4da2e80bf9d0ff625e950f9f85 Signed-off-by: Alex Frid <afrid@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1633054 GVS: Gerrit_Virtual_Submit Reviewed-by: Sivaram Nair <sivaramn@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> 
Added BPMP clock debugfs extension node to pull into kernel debugfs
all clocks that are exposed by BPMP, but not acquired by any driver,
and add Tegra clock writable debugfs extensions that are available on
non-BPMP Tegra platforms.

Change-Id: I4a91684f10bcec4da2e80bf9d0ff625e950f9f85
Signed-off-by: Alex Frid <afrid@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1633054
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
firmware: tegra: Add config DEBUGFS_MOUNT_ON_BOOT 2018-01-11T09:08:10+00:00 sreenivasulu velpula svelpula@nvidia.com 2017-09-06T06:28:37+00:00 af5af119d76d20ecef8478f0049219cdbb932c26 Add config option "BPMP_DEBUGFS_MOUNT_ON_BOOT" to choose whether to mount the bpmp debugfs by default on boot. Bug 200342673 Change-Id: I09f92ce4b52277617c53baa4e296310a36854d6f Signed-off-by: sreenivasulu velpula <svelpula@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1553110 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com> Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> Reviewed-by: Timo Alho <talho@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Sandeep Trasi <strasi@nvidia.com> Reviewed-by: Sivaram Nair <sivaramn@nvidia.com> 
Add config option "BPMP_DEBUGFS_MOUNT_ON_BOOT" to choose whether
to mount the bpmp debugfs by default on boot.

Bug 200342673

Change-Id: I09f92ce4b52277617c53baa4e296310a36854d6f
Signed-off-by: sreenivasulu velpula <svelpula@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1553110
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: Timo Alho <talho@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sandeep Trasi <strasi@nvidia.com>
Reviewed-by: Sivaram Nair <sivaramn@nvidia.com>
firmware: tegra: fix coverity bugs 2018-01-11T09:08:09+00:00 Sivaram Nair sivaramn@nvidia.com 2017-03-09T18:00:55+00:00 a5bf8d4dca93de4381a054f0f30b7604e9e214eb Removed some redundant checks (unsigned compared against -ve). Bug 200192149 Change-Id: I080f43c6906ce9d75d178765d6d8638fd768fe6c Signed-off-by: Sivaram Nair <sivaramn@nvidia.com> Reviewed-on: http://git-master/r/1318165 Reviewed-on: http://git-master/r/1493428 Reviewed-by: Navneet Kumar <navneetk@nvidia.com> GVS: Gerrit_Virtual_Submit 
Removed some redundant checks (unsigned compared against -ve).

Bug 200192149

Change-Id: I080f43c6906ce9d75d178765d6d8638fd768fe6c
Signed-off-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-on: http://git-master/r/1318165
Reviewed-on: http://git-master/r/1493428
Reviewed-by: Navneet Kumar <navneetk@nvidia.com>
GVS: Gerrit_Virtual_Submit
firmware: tegra: fix sparse warning 2018-01-11T09:08:09+00:00 Sivaram Nair sivaramn@nvidia.com 2017-04-27T18:41:05+00:00 1f857daeb562bdd2ac581b457bec77b9982b3d8b Made bpmp_fwdebug_uninit() static. Bug 200299572 Change-Id: I04145a1e17dbf7e325da1b8f390c19c95b6a9982 Signed-off-by: Sivaram Nair <sivaramn@nvidia.com> Reviewed-on: http://git-master/r/1471557 Reviewed-by: Timo Alho <talho@nvidia.com> Reviewed-by: Sachin Nikam <snikam@nvidia.com> GVS: Gerrit_Virtual_Submit 
Made bpmp_fwdebug_uninit() static.

Bug 200299572

Change-Id: I04145a1e17dbf7e325da1b8f390c19c95b6a9982
Signed-off-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-on: http://git-master/r/1471557
Reviewed-by: Timo Alho <talho@nvidia.com>
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
GVS: Gerrit_Virtual_Submit