nvidia-tegra-modules.git/drivers/crypto/tegra-cryptodev.c, branch rtss22-ae

crypto: tegra: return error upon wait timeout

2021-09-24T13:24:54+00:00

Return an error value from process_crypt_req if
wait_for_completion_timeout returns 0 in case of a timeout waiting
for crypto operation to complete.

Bug 200771660

Change-Id: Ie7597a053274cace6b930895e3f969622a813d76
Signed-off-by: Harinarayan Bhatta 
Reviewed-on: https://git-master.nvidia.com/r/#/c/linux-nvidia/+/2596050
(cherry picked from commit f62687d53e0437b6138c02a4463acee21361cd26)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2599867
Reviewed-by: svcacv 
Reviewed-by: Phoenix Jung 
Reviewed-by: mobile promotions 
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions

crypto: vse: fix rng generate return value

2021-08-19T20:55:31+00:00

Fix the return value of rng generate() function according to the Linux
crypto framework's header file include/crypto/rng.h.

Also, return -EAGAIN error code if SE server returns timeout (-13) when
trying to acquire RNG1 mutex.

Bug 200753491

Change-Id: I29d13f457b15ee8c8d02d01b5c1216b694d70680
Signed-off-by: Harinarayan Bhatta 
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2574509
Tested-by: mobile promotions 
Reviewed-by: mobile promotions

drivers: crypto: Update tegra-se to support FIPS

2021-06-14T22:24:05+00:00

In process of resolve the crash and erros update code as per below,

   o Re arranged tegra_se_elp_probe for mutex init
   o Re arranged tegra_se_probe for different crypto test
   o Remove bug in handling memory pointers
   o Set flags in internal crypto allocation while using it for sign
   o Change sequence in Makefile to delay probing sequence of elp
   o Change rsa crypto name to "rsa-pka1" in elp

Bug 3274911
Bug 200739154

Signed-off-by: Ankit Patel 
Change-Id: Iefc04d975a5d2c71bf41050f32e36e8cfec5c966
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2532028
Reviewed-by: svcacv 
Reviewed-by: svc-mobile-coverity 
Reviewed-by: Rakesh Babu Bodla 
Reviewed-by: Bibek Basu 
Reviewed-by: mobile promotions 
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions

cryptodev: Add mutex lock for synchronization

2021-05-13T01:44:54+00:00

There is a possibility of race condition between
different crypto operations which can lead to
accessing dangling pointers and can lead to crash.
Add mutex lock for synchronization.

Bug 3308522
Bug 3299723


Signed-off-by: Rakesh Babu Bodla 
Change-Id: Id12097b816373025d06fc760e7a85362e1d1cd4b
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2527329
Tested-by: mobile promotions 
Reviewed-by: svcacv 
Reviewed-by: Bitan Biswas 
Reviewed-by: svc-mobile-coverity 
Reviewed-by: mobile promotions 
GVS: Gerrit_Virtual_Submit

crypto: tegra: Set IV for first block only.

2019-12-09T07:08:50+00:00

Cryptodev breaks the AES operation in multiples of PAGE_SIZE.
If client has passed IV, it is set in each iteration. However for CBC,
IV has to be set only for the first iteration. For the further
iterations, IV is taken from hardware.

Bug 2529092
Bug 2771692

Change-Id: I2de0777665fbc5a615f6c335d7cd905a6db84820
Signed-off-by: Kartik 
Reviewed-on: https://git-master.nvidia.com/r/2070658
(cherry picked from commit dff885f46090b88ef8c2c5c699a07b06ec86476e)
Reviewed-on: https://git-master.nvidia.com/r/2256503
Reviewed-by: Automatic_Commit_Validation_User
Tested-by: Byungkuk Seo 
GVS: Gerrit_Virtual_Submit
Reviewed-by: Phoenix Jung 
Reviewed-by: mobile promotions 
Tested-by: mobile promotions

include: uapi: move tegra-cryptodev header file

2019-05-03T20:43:41+00:00

Move tegra-cryptodev header file from drivers/crypto/ to
include/uapi/misc/.

Change the path for above header in the dependent file.

Bug 2062672

Change-Id: I738fc7e9425f251372c38573c7f23c89be059a15
Signed-off-by: Anuj Gangwar 
Reviewed-on: https://git-master.nvidia.com/r/2029283
(cherry picked from commit 2c27305ca4404483d0a356636594ebeeedf53fc3)
Signed-off-by: Anuj Gangwar 
Reviewed-on: https://git-master.nvidia.com/r/2110150
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bibek Basu 
Reviewed-by: mobile promotions 
Tested-by: mobile promotions

crypto: tegra: use enum for algo.

2019-04-09T13:45:18+00:00

algo is unsigned char* variable in tegra_sha_req_shash which is a
pointer in userspace and since there are no checks done on this string.
A simple modification of this string can cause a system crash.

Example: passing algo as NULL or a not NULL terminated string.

Avoid this by representing algo by enum in tegra_sha_req_shash.
This will not only avoid most of the checks that we had to do on a string
but it will also improve the execution time.

Example:
	for (i = 0; i < 5; i++) {
		if (!strcmp(sha_req_shash->algo, sha_algo[i])) {
			ctx->shash_tfm[i] = stfm;
			break;
		}
	}

	This for loop can be replaced with:

	ctx->shash_tfm[sha_req_shash->algo] = stfm;

        By using this we're reducing 5n iterations for n number of
	sha operation.

Bug 200484323
Bug 200485303

Change-Id: Ib4e0e9805502a18da3c365ef2d1f5231035efefd
Signed-off-by: Kartik 
Reviewed-on: https://git-master.nvidia.com/r/2089534
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Mallikarjun Kasoju 
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bitan Biswas 
Reviewed-by: mobile promotions 
Tested-by: mobile promotions

tegra-cryptodev: Allow null key only for SE driver

2019-02-17T01:45:28+00:00

Null key is allowed in SE driver for using SSK.
For other drivers, if the key is null, return error.

Bug 200490640

Change-Id: Ibebddd81f90564e7f0f044d1ca2af400ace07e21
Signed-off-by: Mallikarjun Kasoju 
Reviewed-on: https://git-master.nvidia.com/r/2019952
Reviewed-by: svc-mobile-coverity 
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bibek Basu 
Reviewed-by: mobile promotions 
Tested-by: mobile promotions

cryptodev: prevent speculative load related leak

2018-04-23T18:03:10+00:00

Data can be speculatively loaded from memory and stay in cache even
when bound check fails. This can lead to unintended information
disclosure via side-channel analysis.

To mitigate this problem, use array_index_nospec.

Bug 2060857
CVE-2017-5753

Change-Id: I442461cad42fde3a2f9bdee3c8a5eb98ce81efee
Signed-off-by: David Gilhooley 
Reviewed-on: https://git-master.nvidia.com/r/1684651
Reviewed-by: svc-mobile-coverity 
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bo Yan 
Reviewed-by: mobile promotions 
Tested-by: mobile promotions

tegra-cryptodev: set callback for ahash operation

2018-02-23T13:04:56+00:00

Set callback support for ahash operation and wait
for completion without interruption as SHA ahash
procssing is done asynchronously

Bug 200364660

Change-Id: I489711deeaccad4076eeead3a2b70927b1849b34
Signed-off-by: Shravani Dingari 
Reviewed-on: https://git-master.nvidia.com/r/1661610
Reviewed-by: svc-mobile-coverity 
GVS: Gerrit_Virtual_Submit
Reviewed-by: Mallikarjun Kasoju 
Reviewed-by: Bitan Biswas 
Reviewed-by: mobile promotions 
Tested-by: mobile promotions