From 5d7253ea02d1e2328698a15b0430530acd1c05c9 Mon Sep 17 00:00:00 2001 From: Thomas Fleury Date: Thu, 12 Jan 2017 09:14:51 -0800 Subject: gpu: nvgpu: field position in gpu characteristics Fields added to nvgpu_gpu_characteristics must be before the /* Notes: .. */ section. Otherwise, there is a possibility that cherry-picks for new fields actually go before "Notes" and that breaks binary compatibility. Jira DNVGPU-186 Change-Id: Idcd5100be357c187e7194d4c9577f85e12541053 Signed-off-by: Thomas Fleury Reviewed-on: http://git-master/r/1284324 Reviewed-by: Sami Kiminki GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom --- include/uapi/linux/nvgpu.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'include/uapi/linux') diff --git a/include/uapi/linux/nvgpu.h b/include/uapi/linux/nvgpu.h index 1fb633c8..f5c70f2d 100644 --- a/include/uapi/linux/nvgpu.h +++ b/include/uapi/linux/nvgpu.h @@ -225,6 +225,9 @@ struct nvgpu_gpu_characteristics { __u32 reg_ops_limit; __u32 reserved1; + __s16 event_ioctl_nr_last; + __u16 pad[3]; + /* Notes: - This struct can be safely appended with new fields. However, always keep the structure size multiple of 8 and make sure that the binary @@ -232,8 +235,6 @@ struct nvgpu_gpu_characteristics { - If the last field is reserved/padding, it is not generally safe to repurpose the field in future revisions. */ - __s16 event_ioctl_nr_last; - __u16 pad[3]; }; struct nvgpu_gpu_get_characteristics { -- cgit v1.2.2