From a841a88bf0d5d25db0e320c8e11f808c0650f5e7 Mon Sep 17 00:00:00 2001 From: Seema Khowala Date: Mon, 21 Nov 2016 08:51:57 -0800 Subject: gpu: nvgpu: fix enable engine activity fifo_sched_disable_true_v() returns 1 and this value is being right shifted by runlist_id. This will work only if runlist_id is 0. For runlist_id other than 0, 1 right shifted by runlist_id will return 0 and engine will remain disabled. fifo_sched_disable_true_v() should be left shifted by runlist_id to fix the bug. Change-Id: If747035b9f6c80a21a67c63e27fb214223a55d4d Signed-off-by: Seema Khowala Reviewed-on: http://git-master/r/1257344 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Alex Waterman GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom --- drivers/gpu/nvgpu/gk20a/fifo_gk20a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c b/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c index 68394da5..99d5fd4c 100644 --- a/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c @@ -2486,7 +2486,7 @@ int gk20a_fifo_enable_engine_activity(struct gk20a *g, mutex_ret = pmu_mutex_acquire(&g->pmu, PMU_MUTEX_ID_FIFO, &token); enable = gk20a_readl(g, fifo_sched_disable_r()); - enable &= ~(fifo_sched_disable_true_v() >> eng_info->runlist_id); + enable &= ~(fifo_sched_disable_true_v() << eng_info->runlist_id); gk20a_writel(g, fifo_sched_disable_r(), enable); if (!mutex_ret) -- cgit v1.2.2