From 9dce41e208818c0084c91685c8255942a2ca6e8d Mon Sep 17 00:00:00 2001 From: Alex Waterman Date: Thu, 22 Sep 2016 16:01:23 -0700 Subject: gpu: nvgpu: Only set mode if ptr is valid In the nvgpu_pci_devnode() function only set the mode if the mode pointer is valid. In some cases this function only needs the name of the node and not its permissions. Bug 1816516 Change-Id: I603c1499083fb29cb5fe4a871068e0bf2cbe9c3d Signed-off-by: Alex Waterman Reviewed-on: http://git-master/r/1225614 (cherry picked from commit 11874ad9df49b44fac4e90d83e138ead63bbb2f9) Reviewed-on: http://git-master/r/1244907 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom Tested-by: Terje Bergstrom --- drivers/gpu/nvgpu/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/gpu/nvgpu/pci.c b/drivers/gpu/nvgpu/pci.c index 3679e0c8..3c46f073 100644 --- a/drivers/gpu/nvgpu/pci.c +++ b/drivers/gpu/nvgpu/pci.c @@ -197,7 +197,8 @@ static int nvgpu_pci_init_support(struct pci_dev *pdev) static char *nvgpu_pci_devnode(struct device *dev, umode_t *mode) { - *mode = S_IRUGO | S_IWUGO; + if (mode) + *mode = S_IRUGO | S_IWUGO; return kasprintf(GFP_KERNEL, "nvgpu-pci/%s", dev_name(dev)); } -- cgit v1.2.2