From cf7850ee33a5a9ffc32f584c7c3beefe286ceed2 Mon Sep 17 00:00:00 2001 From: Amulya Date: Wed, 29 Aug 2018 16:39:46 +0530 Subject: nvgpu: common: MISRA 10.1 boolean fixes Fix violations where a variable of type non-boolean is used as a boolean in gpu/nvgpu/common. JIRA NVGPU-646 Change-Id: I91baa5cf1d38081161336bde5fbc06661b741273 Signed-off-by: Amulya Reviewed-on: https://git-master.nvidia.com/r/1807133 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/include/nvgpu/gmmu.h | 2 +- drivers/gpu/nvgpu/include/nvgpu/list.h | 3 ++- drivers/gpu/nvgpu/include/nvgpu/semaphore.h | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) (limited to 'drivers/gpu/nvgpu/include') diff --git a/drivers/gpu/nvgpu/include/nvgpu/gmmu.h b/drivers/gpu/nvgpu/include/nvgpu/gmmu.h index e58f5498..da27e29c 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/gmmu.h +++ b/drivers/gpu/nvgpu/include/nvgpu/gmmu.h @@ -330,7 +330,7 @@ int __nvgpu_set_pte(struct gk20a *g, struct vm_gk20a *vm, u64 vaddr, u32 *pte); */ #define pte_dbg(g, attrs, fmt, args...) \ do { \ - if (attrs && attrs->debug) \ + if ((attrs != NULL) && (attrs->debug)) \ nvgpu_info(g, fmt, ##args); \ else \ nvgpu_log(g, gpu_dbg_pte, fmt, ##args); \ diff --git a/drivers/gpu/nvgpu/include/nvgpu/list.h b/drivers/gpu/nvgpu/include/nvgpu/list.h index a7e13cab..16080353 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/list.h +++ b/drivers/gpu/nvgpu/include/nvgpu/list.h @@ -22,6 +22,7 @@ #ifndef NVGPU_LIST_H #define NVGPU_LIST_H +#include struct nvgpu_list_node { struct nvgpu_list_node *prev; @@ -57,7 +58,7 @@ static inline void nvgpu_list_del(struct nvgpu_list_node *node) nvgpu_init_list_node(node); } -static inline int nvgpu_list_empty(struct nvgpu_list_node *head) +static inline bool nvgpu_list_empty(struct nvgpu_list_node *head) { return head->next == head; } diff --git a/drivers/gpu/nvgpu/include/nvgpu/semaphore.h b/drivers/gpu/nvgpu/include/nvgpu/semaphore.h index a7bd79cb..85175069 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/semaphore.h +++ b/drivers/gpu/nvgpu/include/nvgpu/semaphore.h @@ -72,7 +72,7 @@ struct nvgpu_semaphore { struct nvgpu_semaphore_loc location; nvgpu_atomic_t value; - int incremented; + bool incremented; struct nvgpu_ref ref; }; @@ -99,7 +99,7 @@ struct nvgpu_semaphore_pool { */ struct nvgpu_mem rw_mem; - int mapped; + bool mapped; /* * Sometimes a channel can be released before other channels are -- cgit v1.2.2