From 4451cf29d46cee3415e4dce42a8f67f3cc49070c Mon Sep 17 00:00:00 2001 From: Nicolas Benech Date: Tue, 4 Sep 2018 21:38:13 -0400 Subject: gpu: nvgpu: Fix nvgpu_sim_esc_readl MISRA 17.7 violations MISRA Rule-17.7 requires the return value of all functions to be used. Fix is either to use the return value or change the function to return void. This patch contains fix for calls to nvgpu_sim_esc_readl by changing its return to void and printing an error message instead. JIRA NVGPU-677 Change-Id: I949bea253dafc316c7dfbf870eb1225b6fc5b9c3 Signed-off-by: Nicolas Benech Reviewed-on: https://git-master.nvidia.com/r/1812887 Reviewed-by: Alex Waterman GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/include/nvgpu/sim.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpu/nvgpu/include') diff --git a/drivers/gpu/nvgpu/include/nvgpu/sim.h b/drivers/gpu/nvgpu/include/nvgpu/sim.h index fe8e8ac6..41cee8d0 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/sim.h +++ b/drivers/gpu/nvgpu/include/nvgpu/sim.h @@ -36,7 +36,7 @@ struct sim_nvgpu { struct nvgpu_mem msg_bfr; void (*sim_init_late)(struct gk20a *); void (*remove_support)(struct gk20a *); - int (*esc_readl)( + void (*esc_readl)( struct gk20a *g, char *path, u32 index, u32 *data); }; #ifdef __KERNEL__ -- cgit v1.2.2