From 07e5bd817a23913d120b945ced5c96951716886c Mon Sep 17 00:00:00 2001 From: Philip Elcan Date: Tue, 18 Sep 2018 10:14:05 -0400 Subject: gpu: nvgpu: fix return type of *get_litter_value() All callers for the *get_litter_value() functions were expecting u32, but the functions were declared to return int's. This is a violation of MISRA 10.3 which prohibits implicit assignment between essential types (signed int and unsigned long int, in this case). The litter values are all u32's anyway. JIRA NVGPU-647 Change-Id: I853d2abee372488e5d12e355050cbeaf1e53a42c Signed-off-by: Philip Elcan Reviewed-on: https://git-master.nvidia.com/r/1830581 Reviewed-by: svc-misra-checker Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Scott Long Reviewed-by: Alex Waterman Reviewed-by: Terje Bergstrom Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/include/nvgpu/gk20a.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpu/nvgpu/include') diff --git a/drivers/gpu/nvgpu/include/nvgpu/gk20a.h b/drivers/gpu/nvgpu/include/nvgpu/gk20a.h index a7fe1c2f..2ebe0011 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/gk20a.h +++ b/drivers/gpu/nvgpu/include/nvgpu/gk20a.h @@ -1194,7 +1194,7 @@ struct gpu_ops { int (*perfbuffer_disable)(struct gk20a *g); } dbg_session_ops; - int (*get_litter_value)(struct gk20a *g, int value); + u32 (*get_litter_value)(struct gk20a *g, int value); int (*chip_init_gpu_characteristics)(struct gk20a *g); struct { -- cgit v1.2.2