From 4cd59404a2d4ab1c31605d96cff848dd4e93c3b4 Mon Sep 17 00:00:00 2001 From: Mahantesh Kumbar Date: Thu, 21 Jun 2018 00:12:01 +0530 Subject: gpu: nvgpu: falcon code cleanup -Created common falcon function nvgpu_flcn_bl_bootstrap() to bootstrap falcon bootloader -Created HAL gk20a_falcon_bl_bootstrap() which does actual bootloader bootstrap by fetching parameters and loading code/parameters as needed. -Created HAL ops bl_bootstrap under nvgpu_falcon_ops. -Created struct nvgpu_falcon_bl_info to hold info required for bootloader to pass to common function -Removed falcons bootstrap code in multiple file & made changes to fill struct nvgpu_falcon_bl_info & call nvgpu_flcn_bl_bootstrap(). Change-Id: Iee275233915ff11f9afb5207ac0c3338ca9dacc1 Signed-off-by: Mahantesh Kumbar Reviewed-on: https://git-master.nvidia.com/r/1756104 Reviewed-by: svc-mobile-coverity Reviewed-by: svc-misra-checker GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/gv11b/acr_gv11b.c | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-) (limited to 'drivers/gpu/nvgpu/gv11b/acr_gv11b.c') diff --git a/drivers/gpu/nvgpu/gv11b/acr_gv11b.c b/drivers/gpu/nvgpu/gv11b/acr_gv11b.c index 673cb7f2..7fe3a2ea 100644 --- a/drivers/gpu/nvgpu/gv11b/acr_gv11b.c +++ b/drivers/gpu/nvgpu/gv11b/acr_gv11b.c @@ -206,11 +206,8 @@ static int bl_bootstrap(struct nvgpu_pmu *pmu, struct flcn_bl_dmem_desc_v1 *pbl_desc, u32 bl_sz) { struct gk20a *g = gk20a_from_pmu(pmu); - struct acr_desc *acr = &g->acr; struct mm_gk20a *mm = &g->mm; - u32 virt_addr = 0; - struct hsflcn_bl_desc *pmu_bl_gm10x_desc = g->acr.pmu_hsbl_desc; - u32 dst; + struct nvgpu_falcon_bl_info bl_info; nvgpu_log_fn(g, " "); @@ -225,23 +222,12 @@ static int bl_bootstrap(struct nvgpu_pmu *pmu, pwr_pmu_new_instblk_target_sys_coh_f() : pwr_pmu_new_instblk_target_sys_ncoh_f())) ; - /*copy bootloader interface structure to dmem*/ - nvgpu_flcn_copy_to_dmem(pmu->flcn, 0, (u8 *)pbl_desc, - sizeof(struct flcn_bl_dmem_desc_v1), 0); - - /* copy bootloader to TOP of IMEM */ - dst = (pwr_falcon_hwcfg_imem_size_v( - gk20a_readl(g, pwr_falcon_hwcfg_r())) << 8) - bl_sz; - - nvgpu_flcn_copy_to_imem(pmu->flcn, dst, - (u8 *)(acr->hsbl_ucode.cpu_va), bl_sz, 0, 0, - pmu_bl_gm10x_desc->bl_start_tag); - - gv11b_dbg_pmu(g, "Before starting falcon with BL\n"); - - virt_addr = pmu_bl_gm10x_desc->bl_start_tag << 8; - - nvgpu_flcn_bootstrap(pmu->flcn, virt_addr); + bl_info.bl_src = g->acr.hsbl_ucode.cpu_va; + bl_info.bl_desc = (u8 *)pbl_desc; + bl_info.bl_desc_size = sizeof(struct flcn_bl_dmem_desc_v1); + bl_info.bl_size = bl_sz; + bl_info.bl_start_tag = g->acr.pmu_hsbl_desc->bl_start_tag; + nvgpu_flcn_bl_bootstrap(&g->pmu_flcn, &bl_info); return 0; } -- cgit v1.2.2