From 2e338c77eac4edffb94c8c9480dbd72712c7696f Mon Sep 17 00:00:00 2001 From: Stephen Warren Date: Mon, 22 May 2017 12:27:40 -0600 Subject: gpu: nvgpu: remove duplicate \n from log messages nvgpu_log/info/warn/err() internally add a \n to the end of the message. Hence, callers should not include a \n at the end of the message. Doing so results in duplicate \n being printed, which ends up creating empty log messages. Remove the duplicate \n from all err/warn messages. Bug 1928311 Change-Id: I99362c5327f36146f28ba63d4e68181589735c39 Signed-off-by: Stephen Warren Reviewed-on: http://git-master/r/1487232 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/gk20a/sim_gk20a.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'drivers/gpu/nvgpu/gk20a/sim_gk20a.c') diff --git a/drivers/gpu/nvgpu/gk20a/sim_gk20a.c b/drivers/gpu/nvgpu/gk20a/sim_gk20a.c index 122e66f9..ecf829b7 100644 --- a/drivers/gpu/nvgpu/gk20a/sim_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/sim_gk20a.c @@ -78,14 +78,14 @@ static int alloc_and_kmap_iopage(struct gk20a *g, if (!*page) { err = -ENOMEM; - nvgpu_err(g, "couldn't allocate io page\n"); + nvgpu_err(g, "couldn't allocate io page"); goto fail; } *kvaddr = kmap(*page); if (!*kvaddr) { err = -ENOMEM; - nvgpu_err(g, "couldn't kmap io page\n"); + nvgpu_err(g, "couldn't kmap io page"); goto fail; } *phys = page_to_phys(*page); @@ -119,7 +119,7 @@ int gk20a_init_sim_support(struct platform_device *pdev) if (!(g->sim.send_bfr.kvaddr && g->sim.recv_bfr.kvaddr && g->sim.msg_bfr.kvaddr)) { - nvgpu_err(g, "couldn't allocate all sim buffers\n"); + nvgpu_err(g, "couldn't allocate all sim buffers"); goto fail; } @@ -269,7 +269,7 @@ static int rpc_recv_poll(struct gk20a *g) (u64)recv_phys_addr_lo << PAGE_SHIFT; if (recv_phys_addr != g->sim.msg_bfr.phys) { - nvgpu_err(g, "%s Error in RPC reply\n", + nvgpu_err(g, "%s Error in RPC reply", __func__); return -1; } @@ -296,21 +296,21 @@ static int issue_rpc_and_wait(struct gk20a *g) err = rpc_send_message(g); if (err) { - nvgpu_err(g, "%s failed rpc_send_message\n", + nvgpu_err(g, "%s failed rpc_send_message", __func__); return err; } err = rpc_recv_poll(g); if (err) { - nvgpu_err(g, "%s failed rpc_recv_poll\n", + nvgpu_err(g, "%s failed rpc_recv_poll", __func__); return err; } /* Now check if RPC really succeeded */ if (*sim_msg_hdr(g, sim_msg_result_r()) != sim_msg_result_success_v()) { - nvgpu_err(g, "%s received failed status!\n", + nvgpu_err(g, "%s received failed status!", __func__); return -(*sim_msg_hdr(g, sim_msg_result_r())); } -- cgit v1.2.2