From d29afd2c9e990799b470bb95a97935cf5b5020db Mon Sep 17 00:00:00 2001 From: Terje Bergstrom Date: Wed, 9 Nov 2016 15:53:16 -0800 Subject: gpu: nvgpu: Fix signed comparison bugs Fix small problems related to signed versus unsigned comparisons throughout the driver. Bump up the warning level to prevent such problems from occuring in future. Change-Id: I8ff5efb419f664e8a2aedadd6515ae4d18502ae0 Signed-off-by: Terje Bergstrom Reviewed-on: http://git-master/r/1252068 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/gk20a/regops_gk20a.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'drivers/gpu/nvgpu/gk20a/regops_gk20a.c') diff --git a/drivers/gpu/nvgpu/gk20a/regops_gk20a.c b/drivers/gpu/nvgpu/gk20a/regops_gk20a.c index 8b87b523..b0754070 100644 --- a/drivers/gpu/nvgpu/gk20a/regops_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/regops_gk20a.c @@ -35,7 +35,7 @@ static int regop_bsearch_range_cmp(const void *pkey, const void *pelem) if (key < prange->base) return -1; else if (prange->base <= key && key < (prange->base + - (prange->count * 4))) + (prange->count * 4U))) return 0; return 1; } @@ -379,7 +379,8 @@ int exec_regops_gk20a(struct dbg_session_gk20a *dbg_s, struct nvgpu_dbg_gpu_reg_op *ops, u64 num_ops) { - int err = 0, i; + int err = 0; + unsigned int i; struct channel_gk20a *ch = NULL; struct gk20a *g = dbg_s->g; /*struct gr_gk20a *gr = &g->gr;*/ @@ -799,7 +800,8 @@ static int gk20a_apply_smpc_war(struct dbg_session_gk20a *dbg_s) * it was already swapped out in/out once or not, etc. */ struct nvgpu_dbg_gpu_reg_op ops[4]; - int i; + unsigned int i; + for (i = 0; i < ARRAY_SIZE(ops); i++) { ops[i].op = REGOP(WRITE_32); ops[i].type = REGOP(TYPE_GR_CTX); -- cgit v1.2.2