From 10f6da09eb6fffea2d50c8fe4634e0d5f8226d7d Mon Sep 17 00:00:00 2001 From: Deepak Nibade Date: Thu, 19 Nov 2015 14:26:15 +0530 Subject: gpu: nvgpu: fix Coverity issues - operands not affecting result (id = 12845) - logically dead code (id = 12890) - dereference after null check (id = 12968) - unsigned compared to 0 (id = 13176) - resource leak (id = 13338, 18673) - unused pointer value (id = 13916) Bug 1703084 Change-Id: I2f401dd93126af27748c53fa1b3a59cb154af36b Signed-off-by: Deepak Nibade Reviewed-on: http://git-master/r/835143 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Terje Bergstrom Reviewed-by: Seshendra Gadagottu GVS: Gerrit_Virtual_Submit Reviewed-by: Sachin Nikam --- drivers/gpu/nvgpu/gk20a/mm_gk20a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpu/nvgpu/gk20a/mm_gk20a.c') diff --git a/drivers/gpu/nvgpu/gk20a/mm_gk20a.c b/drivers/gpu/nvgpu/gk20a/mm_gk20a.c index 4c31d5e4..4bc8d385 100644 --- a/drivers/gpu/nvgpu/gk20a/mm_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/mm_gk20a.c @@ -1735,7 +1735,7 @@ int gk20a_vm_get_compbits_info(struct vm_gk20a *vm, mapped_buffer = find_mapped_buffer_locked(&vm->mapped_buffers, mapping_gva); - if (!mapped_buffer | !mapped_buffer->user_mapped) + if (!mapped_buffer || !mapped_buffer->user_mapped) { mutex_unlock(&vm->update_gmmu_lock); gk20a_err(d, "%s: bad offset 0x%llx", __func__, mapping_gva); -- cgit v1.2.2