From 17aeea4a2ffa23fc9dbcdc84cda747fe5a025131 Mon Sep 17 00:00:00 2001 From: Srirangan Date: Thu, 2 Aug 2018 14:15:54 +0530 Subject: gpu: nvgpu: gk20a: Fix MISRA 15.6 violations This fixes errors due to single statement loop bodies without braces, which is part of Rule 15.6 of MISRA. This patch covers in gpu/nvgpu/gk20a/ JIRA NVGPU-989 Change-Id: I2f422e9bc2b03229f4d2c3198613169ce5e7f3ee Signed-off-by: Srirangan Reviewed-on: https://git-master.nvidia.com/r/1791019 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/gk20a/flcn_gk20a.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) (limited to 'drivers/gpu/nvgpu/gk20a/flcn_gk20a.c') diff --git a/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c b/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c index c55b90b6..98fdb8c2 100644 --- a/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c @@ -213,14 +213,16 @@ static int gk20a_flcn_copy_from_dmem(struct nvgpu_falcon *flcn, gk20a_writel(g, base_addr + falcon_falcon_dmemc_r(port), src | falcon_falcon_dmemc_aincr_f(1)); - for (i = 0; i < words; i++) + for (i = 0; i < words; i++) { dst_u32[i] = gk20a_readl(g, base_addr + falcon_falcon_dmemd_r(port)); + } if (bytes > 0) { data = gk20a_readl(g, base_addr + falcon_falcon_dmemd_r(port)); - for (i = 0; i < bytes; i++) + for (i = 0; i < bytes; i++) { dst[(words << 2) + i] = ((u8 *)&data)[i]; + } } nvgpu_mutex_release(&flcn->copy_lock); @@ -256,14 +258,16 @@ static int gk20a_flcn_copy_to_dmem(struct nvgpu_falcon *flcn, gk20a_writel(g, base_addr + falcon_falcon_dmemc_r(port), dst | falcon_falcon_dmemc_aincw_f(1)); - for (i = 0; i < words; i++) + for (i = 0; i < words; i++) { gk20a_writel(g, base_addr + falcon_falcon_dmemd_r(port), src_u32[i]); + } if (bytes > 0) { data = 0; - for (i = 0; i < bytes; i++) + for (i = 0; i < bytes; i++) { ((u8 *)&data)[i] = src[(words << 2) + i]; + } gk20a_writel(g, base_addr + falcon_falcon_dmemd_r(port), data); } @@ -313,14 +317,16 @@ static int gk20a_flcn_copy_from_imem(struct nvgpu_falcon *flcn, u32 src, falcon_falcon_imemc_blk_f(blk) | falcon_falcon_dmemc_aincr_f(1)); - for (i = 0; i < words; i++) + for (i = 0; i < words; i++) { dst_u32[i] = gk20a_readl(g, base_addr + falcon_falcon_imemd_r(port)); + } if (bytes > 0) { data = gk20a_readl(g, base_addr + falcon_falcon_imemd_r(port)); - for (i = 0; i < bytes; i++) + for (i = 0; i < bytes; i++) { dst[(words << 2) + i] = ((u8 *)&data)[i]; + } } nvgpu_mutex_release(&flcn->copy_lock); -- cgit v1.2.2