From f97d62eb8fa773a1748adb0e523199e7bee9a348 Mon Sep 17 00:00:00 2001 From: Mahantesh Kumbar Date: Mon, 29 May 2017 23:36:18 +0530 Subject: gpu: nvgpu: Avoid NULL dereference of flcn -issue: flcn pointer in nvgpu_flcn_sw_init() will be NULL in default case of switch, and that results in NULL pointer dereference on flcn->flcn_id. -Fix: Used flcn_id parameter to print falcon id in default case. Coverity ID: 2514311 Coverity ID: 2514313 Bug 200291879 Change-Id: I7008817c22cdf8d9d9027cc1b724e2424b4a3d8e Signed-off-by: Mahantesh Kumbar Reviewed-on: http://git-master/r/1491694 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svccoveritychecker GVS: Gerrit_Virtual_Submit Reviewed-by: Deepak Nibade Reviewed-by: Sachin Nikam Reviewed-by: Terje Bergstrom --- drivers/gpu/nvgpu/common/falcon/falcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpu/nvgpu/common') diff --git a/drivers/gpu/nvgpu/common/falcon/falcon.c b/drivers/gpu/nvgpu/common/falcon/falcon.c index ac1b390f..bcc24355 100644 --- a/drivers/gpu/nvgpu/common/falcon/falcon.c +++ b/drivers/gpu/nvgpu/common/falcon/falcon.c @@ -39,7 +39,7 @@ void nvgpu_flcn_sw_init(struct gk20a *g, u32 flcn_id) flcn->flcn_id = flcn_id; break; default: - nvgpu_err(g, "Invalid/Unsupported falcon ID %x", flcn->flcn_id); + nvgpu_err(g, "Invalid/Unsupported falcon ID %x", flcn_id); break; }; -- cgit v1.2.2