From 05f45bcfc390c46f000f4c6b46546eebed869df6 Mon Sep 17 00:00:00 2001 From: Sai Nikhil Date: Tue, 21 Aug 2018 12:18:10 +0530 Subject: gpu: nvgpu: MISRA 10.3 Conversions to/from char MISRA Rule 10.3 states that the value of an expression shall not be assigned to an object with a narrower essential type or of a different essential type category. We have cases where we are converting to/from char and non char types and this fix 10.3 violations resulting from these conversions. This also fix violations in conversions between s8 and non-s8 types as s8 can be typedefed as char. Jira NVGPU-1010 Change-Id: I150dd633eb7575de9ea2bedd598b7af74d1fcbd9 Signed-off-by: Sai Nikhil Reviewed-on: https://git-master.nvidia.com/r/1801613 Reviewed-by: svc-misra-checker Reviewed-by: svccoveritychecker GVS: Gerrit_Virtual_Submit Reviewed-by: Alex Waterman Reviewed-by: Adeel Raza Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/clk/clk_vin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'drivers/gpu/nvgpu/clk/clk_vin.c') diff --git a/drivers/gpu/nvgpu/clk/clk_vin.c b/drivers/gpu/nvgpu/clk/clk_vin.c index 67eeffd5..d57522af 100644 --- a/drivers/gpu/nvgpu/clk/clk_vin.c +++ b/drivers/gpu/nvgpu/clk/clk_vin.c @@ -102,8 +102,8 @@ u32 clk_avfs_get_vin_cal_fuse_v20(struct gk20a *g, if (pvinobjs->calibration_rev_vbios == g->ops.fuse.read_vin_cal_fuse_rev(g)) { BOARDOBJGRP_FOR_EACH(&(pvinobjs->super.super), struct vin_device_v20 *, pvindev, i) { - gain = 0; - offset = 0; + gain = '\0'; + offset = '\0'; pvindev = (struct vin_device_v20 *)CLK_GET_VIN_DEVICE(pvinobjs, i); status = g->ops.fuse.read_vin_cal_gain_offset_fuse(g, pvindev->super.id, &gain, &offset); @@ -268,7 +268,7 @@ static u32 devinit_get_vin_device_table(struct gk20a *g, u8 *vin_tbl_entry_ptr = NULL; u32 index = 0; u32 slope=0, intercept=0; - s8 offset=0, gain=0; + s8 offset='\0', gain='\0'; struct vin_device *pvin_dev; u32 cal_type; -- cgit v1.2.2