From f6f21a27b3fa2c8e9322a086b22ed2f44406702e Mon Sep 17 00:00:00 2001 From: Deepak Nibade Date: Wed, 15 Mar 2017 17:36:29 +0530 Subject: gpu: nvgpu: check return value of mutex_init in CDE code - check return value of nvgpu_mutex_init in cde_gk20a.c - add corresponding nvgpu_mutex_destroy calls Jira NVGPU-13 Change-Id: I99f59d191cc81eff4a330557b864925d36fc4b3d Signed-off-by: Deepak Nibade Reviewed-on: http://git-master/r/1321287 Reviewed-by: svccoveritychecker GVS: Gerrit_Virtual_Submit Reviewed-by: Konsta Holtta Reviewed-by: Terje Bergstrom --- drivers/gpu/nvgpu/gk20a/cde_gk20a.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nvgpu/gk20a/cde_gk20a.c b/drivers/gpu/nvgpu/gk20a/cde_gk20a.c index d19479a2..c8434f3d 100644 --- a/drivers/gpu/nvgpu/gk20a/cde_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/cde_gk20a.c @@ -155,6 +155,8 @@ __releases(&cde_app->mutex) nvgpu_mutex_acquire(&cde_app->mutex); gk20a_cde_stop(g); nvgpu_mutex_release(&cde_app->mutex); + + nvgpu_mutex_destroy(&cde_app->mutex); } void gk20a_cde_suspend(struct gk20a *g) @@ -1301,7 +1303,10 @@ __releases(&cde_app->mutex) gk20a_dbg(gpu_dbg_fn | gpu_dbg_cde_ctx, "cde: init"); - nvgpu_mutex_init(&cde_app->mutex); + err = nvgpu_mutex_init(&cde_app->mutex); + if (err) + return err; + nvgpu_mutex_acquire(&cde_app->mutex); INIT_LIST_HEAD(&cde_app->free_contexts); @@ -1316,6 +1321,10 @@ __releases(&cde_app->mutex) nvgpu_mutex_release(&cde_app->mutex); gk20a_dbg(gpu_dbg_cde_ctx, "cde: init finished: %d", err); + + if (err) + nvgpu_mutex_destroy(&cde_app->mutex); + return err; } -- cgit v1.2.2