summaryrefslogtreecommitdiffstats
path: root/scripts/rfr
Commit message (Collapse)AuthorAge
* scripts: rfr: Direct email supportAlex Waterman2018-06-28
| | | | | | | | | | | | | | | | | | | | | | | Add support for `rfr' to send emails directly to the nvgpu-core mailing list. Copying the email contents and then manually updating it is annoying. This streamlines that process greatly! Since most people always write something extra past what the `rfr' script generates you can edit the message before it sends. If you don't specify a message explicitly with '--msg' then an editor based on your setting of $EDITOR is opened up with the contents of the email. What you edit into there will be sent verbatim. If for some reason you want nothing to be added there's the '--no-msg' option. Change-Id: Icb0ccba936357cf5e3a93001a5c22aeacf906e11 Signed-off-by: Alex Waterman <alexw@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1595544 GVS: Gerrit_Virtual_Submit Reviewed-by: Konsta Holtta <kholtta@nvidia.com> Tested-by: Konsta Holtta <kholtta@nvidia.com> Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
* scripts: rfr: support https://git-master.nvidia.com/r/#/c/(\d+)Richard Zhao2018-01-31
| | | | | | | | | | | | | | | | | https://git-master.nvidia.com/r/#/c/(\d+) is acceptable format for gerrit website and it won't auto-correct by adding '/' at endof the url. Jira EVLR-2364 Change-Id: I1a33578058d23fbb3eaf76d260a1a659c628fdc3 Signed-off-by: Richard Zhao <rizhao@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1646315 Reviewed-by: Alex Waterman <alexw@nvidia.com> Reviewed-by: Seshendra Gadagottu <sgadagottu@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
* scripts: rfr: query gerrit for git sha1Konsta Holtta2017-11-01
| | | | | | | | | | | | | | | | The gerrit search supports git sha1 revisions, so use that directly when given a git commit. This changes the behaviour such that the change-id found from the commit message is not used implicitly, which removes ambiguity. Change-Id: Ifac1002421886dc73234b530d937395aae5addee Signed-off-by: Konsta Holtta <kholtta@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1585437 GVS: Gerrit_Virtual_Submit Reviewed-by: Alex Waterman <alexw@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
* scripts: rfr: explicitly use gerrit cl if neededKonsta Holtta2017-11-01
| | | | | | | | | | | | | | | | | | Fetch the full patch information from gerrit as soon as possible, so that the gerrit cl (i.e., git-master url) is used if given, because it has more information than the change-id (which may exist in multiple branches). Querying based on change-id or git commit-id are left as-is. Change-Id: I58dfa9da7354d607ca7e38f91e4a5f2c92c8454f Signed-off-by: Konsta Holtta <kholtta@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1585436 Reviewed-by: Alex Waterman <alexw@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Vijayakumar Subbu <vsubbu@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
* scripts: rfr: Remove duplicate subjectsAlex Waterman2017-09-13
| | | | | | | | | | | | | The commit subject is printed implicitly in the commit message so remove the subject from the header generated by `rfr'. Also delete a debug line that got left over accidentally. Change-Id: Ia7fe704182d87504c5794ad4661d8dd2f14bc51f Signed-off-by: Alex Waterman <alexw@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1558431 Reviewed-by: Konsta Holtta <kholtta@nvidia.com> Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
* scripts: Add an 'rfr' programAlex Waterman2017-09-11
Add an RFR program to generate RFR emails. Since there are many emails sent with either no information or lacking information this script will help make RFR emails more useful to developers interested in conducting reviews. The help is as follows: $ ./rfr --help usage: rfr [-h] [-V] [-m MSG] Commit-IDs [Commit-IDs ...] RFR formatting tool positional arguments: Commit-IDs Git or gerrit commits to describe. Can be either a git or gerrit commit ID. If the ID starts with a 'I' then it will be treated as a gerrit ID. If the commit ID looks like a gerrit URL then it is treated as a gerrit URL. Otherwise it's treated as a git commit ID. optional arguments: -h, --help show this help message and exit -V, --version print the program version -m MSG, --msg MSG Custom message to add to the RFR email This program will format commit messages into something that can be sent to the nvgpu mailing list for review The Commit IDs can be a git commit ID, gerrit change ID, or a gerrit URL. For example: # Git commit IDs (abbreviated are ok) $ ./rfr 89e2470807 $ ./rfr 89e2470807571ef6dc545ece8f5f7e43e27b0c12 # Gerrit Change-Id (also can be abbreviated) $ ./rfr I0524ae1982fbce9eb4da976e72102e08e2dcd017 $ ./rfr I0524ae198 # And lastly, several different URL formats: https://git-master.nvidia.com/r/#/c/1553782/2 https://git-master.nvidia.com/r/#/c/1553782/ https://git-master.nvidia.com/r/1553782 https://git-master/r/1553782 The only currently known bug is that if yo have multiple versions of a commit that share the same gerrit Change-ID then this script will only take the first one. For example if there's a bunch of cherry-picks then which commit is taken is undefined. It seems like generally the order that gerrit returns changes puts open changes first, but this is not tested nor should this be relied upon. At some point supporting some mechanism to filter will be necessary. Change-Id: I0524ae1982fbce9eb4da976e72102e08e2dcd017 Signed-off-by: Alex Waterman <alexw@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1552173 Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>