summaryrefslogtreecommitdiffstats
path: root/include/uapi
diff options
context:
space:
mode:
authorThomas Fleury <tfleury@nvidia.com>2017-01-12 12:14:51 -0500
committermobile promotions <svcmobile_promotions@nvidia.com>2017-01-16 17:44:01 -0500
commit5d7253ea02d1e2328698a15b0430530acd1c05c9 (patch)
treea4d311adb5363729e51b389c9f3afe20c8b17da9 /include/uapi
parentf6a634ff24194ee83579f90ab399a08d91df233a (diff)
gpu: nvgpu: field position in gpu characteristics
Fields added to nvgpu_gpu_characteristics must be before the /* Notes: .. */ section. Otherwise, there is a possibility that cherry-picks for new fields actually go before "Notes" and that breaks binary compatibility. Jira DNVGPU-186 Change-Id: Idcd5100be357c187e7194d4c9577f85e12541053 Signed-off-by: Thomas Fleury <tfleury@nvidia.com> Reviewed-on: http://git-master/r/1284324 Reviewed-by: Sami Kiminki <skiminki@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Diffstat (limited to 'include/uapi')
-rw-r--r--include/uapi/linux/nvgpu.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/include/uapi/linux/nvgpu.h b/include/uapi/linux/nvgpu.h
index 1fb633c8..f5c70f2d 100644
--- a/include/uapi/linux/nvgpu.h
+++ b/include/uapi/linux/nvgpu.h
@@ -225,6 +225,9 @@ struct nvgpu_gpu_characteristics {
225 __u32 reg_ops_limit; 225 __u32 reg_ops_limit;
226 __u32 reserved1; 226 __u32 reserved1;
227 227
228 __s16 event_ioctl_nr_last;
229 __u16 pad[3];
230
228 /* Notes: 231 /* Notes:
229 - This struct can be safely appended with new fields. However, always 232 - This struct can be safely appended with new fields. However, always
230 keep the structure size multiple of 8 and make sure that the binary 233 keep the structure size multiple of 8 and make sure that the binary
@@ -232,8 +235,6 @@ struct nvgpu_gpu_characteristics {
232 - If the last field is reserved/padding, it is not 235 - If the last field is reserved/padding, it is not
233 generally safe to repurpose the field in future revisions. 236 generally safe to repurpose the field in future revisions.
234 */ 237 */
235 __s16 event_ioctl_nr_last;
236 __u16 pad[3];
237}; 238};
238 239
239struct nvgpu_gpu_get_characteristics { 240struct nvgpu_gpu_get_characteristics {