diff options
author | Thomas Fleury <tfleury@nvidia.com> | 2017-10-24 13:06:10 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2017-11-06 16:41:27 -0500 |
commit | 4e7c9c3008e8bd354afa471e1d97ba88b12194da (patch) | |
tree | 3dc16e5b0bda16b5992736bd2c3fd52331bd5310 /drivers/gpu/nvgpu | |
parent | d0a278b0a53224dd3e8374f7ae8b9aea5176b92e (diff) |
gpu: nvgpu: fix dma memory leak in remove pmu support
Add missing unmap and free for seq_buf and ucode (acr & hsbl).
JIRA EVLR-1959
Bug 200352009
Change-Id: I3e422ce07228b59554ab1407c29e45c70479134d
Signed-off-by: Thomas Fleury <tfleury@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1586576
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: David Martinez Nieto <dmartineznie@nvidia.com>
Reviewed-by: Richard Zhao <rizhao@nvidia.com>
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu')
-rw-r--r-- | drivers/gpu/nvgpu/common/pmu/pmu_fw.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/gpu/nvgpu/common/pmu/pmu_fw.c b/drivers/gpu/nvgpu/common/pmu/pmu_fw.c index 8c4e091d..20eadb50 100644 --- a/drivers/gpu/nvgpu/common/pmu/pmu_fw.c +++ b/drivers/gpu/nvgpu/common/pmu/pmu_fw.c | |||
@@ -2226,6 +2226,8 @@ static int nvgpu_init_pmu_fw_ver_ops(struct nvgpu_pmu *pmu) | |||
2226 | static void nvgpu_remove_pmu_support(struct nvgpu_pmu *pmu) | 2226 | static void nvgpu_remove_pmu_support(struct nvgpu_pmu *pmu) |
2227 | { | 2227 | { |
2228 | struct gk20a *g = gk20a_from_pmu(pmu); | 2228 | struct gk20a *g = gk20a_from_pmu(pmu); |
2229 | struct mm_gk20a *mm = &g->mm; | ||
2230 | struct vm_gk20a *vm = mm->pmu.vm; | ||
2229 | 2231 | ||
2230 | nvgpu_log_fn(g, " "); | 2232 | nvgpu_log_fn(g, " "); |
2231 | 2233 | ||
@@ -2247,6 +2249,11 @@ static void nvgpu_remove_pmu_support(struct nvgpu_pmu *pmu) | |||
2247 | if (g->acr.hsbl_fw) | 2249 | if (g->acr.hsbl_fw) |
2248 | nvgpu_release_firmware(g, g->acr.hsbl_fw); | 2250 | nvgpu_release_firmware(g, g->acr.hsbl_fw); |
2249 | 2251 | ||
2252 | nvgpu_dma_unmap_free(vm, &g->acr.acr_ucode); | ||
2253 | nvgpu_dma_unmap_free(vm, &g->acr.hsbl_ucode); | ||
2254 | |||
2255 | nvgpu_dma_unmap_free(vm, &pmu->seq_buf); | ||
2256 | |||
2250 | nvgpu_mutex_destroy(&pmu->elpg_mutex); | 2257 | nvgpu_mutex_destroy(&pmu->elpg_mutex); |
2251 | nvgpu_mutex_destroy(&pmu->pg_mutex); | 2258 | nvgpu_mutex_destroy(&pmu->pg_mutex); |
2252 | nvgpu_mutex_destroy(&pmu->isr_mutex); | 2259 | nvgpu_mutex_destroy(&pmu->isr_mutex); |