diff options
author | Philip Elcan <pelcan@nvidia.com> | 2018-08-29 15:46:12 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-09-07 00:33:50 -0400 |
commit | 7f8226887c28267d3c2351692d4429ead1e17695 (patch) | |
tree | aa09c45e496b058044c9d9a94c94d9922c572285 /drivers/gpu/nvgpu/volt/volt_rail.c | |
parent | 0e58ebaae13dd59b6aba5297f898e7c89fcd2742 (diff) |
gpu: nvgpu: cleanup return types for MISRA 10.3
This is a big cleanup of return types across a number of modules in the
nvgpu driver. Many functions were returning u32 but using negative
return codes. This is a MISRA 10.3 violation by assigning signed values
to a u32.
JIRA NVGPU-647
Change-Id: I59ee66706321f5b5b1a07ed8c24b81583e9ba28c
Signed-off-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1810743
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/volt/volt_rail.c')
-rw-r--r-- | drivers/gpu/nvgpu/volt/volt_rail.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/drivers/gpu/nvgpu/volt/volt_rail.c b/drivers/gpu/nvgpu/volt/volt_rail.c index e44d8973..c8dc25f2 100644 --- a/drivers/gpu/nvgpu/volt/volt_rail.c +++ b/drivers/gpu/nvgpu/volt/volt_rail.c | |||
@@ -128,10 +128,10 @@ static u32 volt_rail_state_init(struct gk20a *g, | |||
128 | return status; | 128 | return status; |
129 | } | 129 | } |
130 | 130 | ||
131 | static u32 volt_rail_init_pmudata_super(struct gk20a *g, | 131 | static int volt_rail_init_pmudata_super(struct gk20a *g, |
132 | struct boardobj *board_obj_ptr, struct nv_pmu_boardobj *ppmudata) | 132 | struct boardobj *board_obj_ptr, struct nv_pmu_boardobj *ppmudata) |
133 | { | 133 | { |
134 | u32 status = 0; | 134 | int status = 0; |
135 | struct voltage_rail *prail; | 135 | struct voltage_rail *prail; |
136 | struct nv_pmu_volt_volt_rail_boardobj_set *rail_pmu_data; | 136 | struct nv_pmu_volt_volt_rail_boardobj_set *rail_pmu_data; |
137 | u32 i; | 137 | u32 i; |
@@ -183,7 +183,7 @@ static struct voltage_rail *construct_volt_rail(struct gk20a *g, void *pargs) | |||
183 | struct boardobj *board_obj_ptr = NULL; | 183 | struct boardobj *board_obj_ptr = NULL; |
184 | struct voltage_rail *ptemp_rail = (struct voltage_rail *)pargs; | 184 | struct voltage_rail *ptemp_rail = (struct voltage_rail *)pargs; |
185 | struct voltage_rail *board_obj_volt_rail_ptr = NULL; | 185 | struct voltage_rail *board_obj_volt_rail_ptr = NULL; |
186 | u32 status; | 186 | int status; |
187 | 187 | ||
188 | nvgpu_log_info(g, " "); | 188 | nvgpu_log_info(g, " "); |
189 | status = boardobj_construct_super(g, &board_obj_ptr, | 189 | status = boardobj_construct_super(g, &board_obj_ptr, |
@@ -242,9 +242,9 @@ u8 volt_rail_vbios_volt_domain_convert_to_internal(struct gk20a *g, | |||
242 | return CTRL_VOLT_DOMAIN_INVALID; | 242 | return CTRL_VOLT_DOMAIN_INVALID; |
243 | } | 243 | } |
244 | 244 | ||
245 | u32 volt_rail_pmu_setup(struct gk20a *g) | 245 | int volt_rail_pmu_setup(struct gk20a *g) |
246 | { | 246 | { |
247 | u32 status; | 247 | int status; |
248 | struct boardobjgrp *pboardobjgrp = NULL; | 248 | struct boardobjgrp *pboardobjgrp = NULL; |
249 | 249 | ||
250 | nvgpu_log_info(g, " "); | 250 | nvgpu_log_info(g, " "); |
@@ -261,10 +261,10 @@ u32 volt_rail_pmu_setup(struct gk20a *g) | |||
261 | return status; | 261 | return status; |
262 | } | 262 | } |
263 | 263 | ||
264 | static u32 volt_get_volt_rail_table(struct gk20a *g, | 264 | static int volt_get_volt_rail_table(struct gk20a *g, |
265 | struct voltage_rail_metadata *pvolt_rail_metadata) | 265 | struct voltage_rail_metadata *pvolt_rail_metadata) |
266 | { | 266 | { |
267 | u32 status = 0; | 267 | int status = 0; |
268 | u8 *volt_rail_table_ptr = NULL; | 268 | u8 *volt_rail_table_ptr = NULL; |
269 | struct voltage_rail *prail = NULL; | 269 | struct voltage_rail *prail = NULL; |
270 | struct vbios_voltage_rail_table_1x_header header = { 0 }; | 270 | struct vbios_voltage_rail_table_1x_header header = { 0 }; |
@@ -370,7 +370,7 @@ done: | |||
370 | return status; | 370 | return status; |
371 | } | 371 | } |
372 | 372 | ||
373 | static u32 _volt_rail_devgrp_pmudata_instget(struct gk20a *g, | 373 | static int _volt_rail_devgrp_pmudata_instget(struct gk20a *g, |
374 | struct nv_pmu_boardobjgrp *pmuboardobjgrp, struct nv_pmu_boardobj | 374 | struct nv_pmu_boardobjgrp *pmuboardobjgrp, struct nv_pmu_boardobj |
375 | **ppboardobjpmudata, u8 idx) | 375 | **ppboardobjpmudata, u8 idx) |
376 | { | 376 | { |
@@ -392,7 +392,7 @@ static u32 _volt_rail_devgrp_pmudata_instget(struct gk20a *g, | |||
392 | return 0; | 392 | return 0; |
393 | } | 393 | } |
394 | 394 | ||
395 | static u32 _volt_rail_devgrp_pmustatus_instget(struct gk20a *g, | 395 | static int _volt_rail_devgrp_pmustatus_instget(struct gk20a *g, |
396 | void *pboardobjgrppmu, struct nv_pmu_boardobj_query | 396 | void *pboardobjgrppmu, struct nv_pmu_boardobj_query |
397 | **ppboardobjpmustatus, u8 idx) | 397 | **ppboardobjpmustatus, u8 idx) |
398 | { | 398 | { |
@@ -411,9 +411,9 @@ static u32 _volt_rail_devgrp_pmustatus_instget(struct gk20a *g, | |||
411 | return 0; | 411 | return 0; |
412 | } | 412 | } |
413 | 413 | ||
414 | u32 volt_rail_sw_setup(struct gk20a *g) | 414 | int volt_rail_sw_setup(struct gk20a *g) |
415 | { | 415 | { |
416 | u32 status = 0; | 416 | int status = 0; |
417 | struct boardobjgrp *pboardobjgrp = NULL; | 417 | struct boardobjgrp *pboardobjgrp = NULL; |
418 | struct voltage_rail *pvolt_rail; | 418 | struct voltage_rail *pvolt_rail; |
419 | u8 i; | 419 | u8 i; |