diff options
author | Nicolas Benech <nbenech@nvidia.com> | 2018-08-23 16:23:52 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-09-05 23:39:08 -0400 |
commit | 2eface802a4aea417206bcdda689a65cf47d300b (patch) | |
tree | 502af9d48004af4edf8f02a2a7cf751ef5a11325 /drivers/gpu/nvgpu/include | |
parent | b44c7fdb114a63ab98fffc0f246776b56399ff64 (diff) |
gpu: nvgpu: Fix mutex MISRA 17.7 violations
MISRA Rule-17.7 requires the return value of all functions to be used.
Fix is either to use the return value or change the function to return
void. This patch contains fix for calls to nvgpu_mutex_init and
improves related error handling.
JIRA NVGPU-677
Change-Id: I609fa138520cc7ccfdd5aa0e7fd28c8ca0b3a21c
Signed-off-by: Nicolas Benech <nbenech@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1805598
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/include')
-rw-r--r-- | drivers/gpu/nvgpu/include/nvgpu/falcon.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/gpu/nvgpu/include/nvgpu/falcon.h b/drivers/gpu/nvgpu/include/nvgpu/falcon.h index 2920e281..55dca035 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/falcon.h +++ b/drivers/gpu/nvgpu/include/nvgpu/falcon.h | |||
@@ -29,12 +29,12 @@ | |||
29 | /* | 29 | /* |
30 | * Falcon Id Defines | 30 | * Falcon Id Defines |
31 | */ | 31 | */ |
32 | #define FALCON_ID_PMU (0) | 32 | #define FALCON_ID_PMU (0U) |
33 | #define FALCON_ID_FECS (2) | 33 | #define FALCON_ID_FECS (2U) |
34 | #define FALCON_ID_GPCCS (3) | 34 | #define FALCON_ID_GPCCS (3U) |
35 | #define FALCON_ID_NVDEC (4) | 35 | #define FALCON_ID_NVDEC (4U) |
36 | #define FALCON_ID_SEC2 (7) | 36 | #define FALCON_ID_SEC2 (7U) |
37 | #define FALCON_ID_MINION (10) | 37 | #define FALCON_ID_MINION (10U) |
38 | 38 | ||
39 | /* | 39 | /* |
40 | * Falcon Base address Defines | 40 | * Falcon Base address Defines |
@@ -317,6 +317,6 @@ int nvgpu_flcn_queue_push(struct nvgpu_falcon *flcn, | |||
317 | void nvgpu_flcn_queue_free(struct nvgpu_falcon *flcn, | 317 | void nvgpu_flcn_queue_free(struct nvgpu_falcon *flcn, |
318 | struct nvgpu_falcon_queue *queue); | 318 | struct nvgpu_falcon_queue *queue); |
319 | 319 | ||
320 | void nvgpu_flcn_sw_init(struct gk20a *g, u32 flcn_id); | 320 | int nvgpu_flcn_sw_init(struct gk20a *g, u32 flcn_id); |
321 | 321 | ||
322 | #endif /* __FALCON_H__ */ | 322 | #endif /* __FALCON_H__ */ |