gpu: nvgpu: commonize errs in *get_litter_value()

No one is checking return values for the *get_litter_value()
functions in the 100s of references, and some of the *get_litter_value()
functions were already doing a BUG(), we'll just call BUG() in all them.

And since we don't return in the error case, and there's no guarantee
that an errno won't collide with the litter values, we'll just
initialize the local ret value to 0 to avoid problems and confusion.

JIRA NVGPU-647

Change-Id: Id974c904a142c4b3abf1ab940121c270208b0b83
Signed-off-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1830582
GVS: Gerrit_Virtual_Submit
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Scott Long <scottl@nvidia.com>
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>

1 files changed, 3 insertions, 1 deletions

diff --git a/drivers/gpu/nvgpu/gv100/hal_gv100.c b/drivers/gpu/nvgpu/gv100/hal_gv100.c
index aecebf79..041422e0 100644
--- a/drivers/gpu/nvgpu/gv100/hal_gv100.c
+++ b/drivers/gpu/nvgpu/gv100/hal_gv100.c
@@ -127,7 +127,7 @@
 
 static u32 gv100_get_litter_value(struct gk20a *g, int value)
 {
-        u32 ret = EINVAL;
+        u32 ret = 0;
         switch (value) {
         case GPU_LIT_NUM_GPCS:
                 ret = proj_scal_litter_num_gpcs_v();
@@ -244,6 +244,8 @@ static u32 gv100_get_litter_value(struct gk20a *g, int value)
                 ret = proj_gpc_priv_stride_v();
                 break;
         default:
+                nvgpu_err(g, "Missing definition %d", value);
+                BUG();
                 break;
         }