gpu: nvgpu: Fix mutex MISRA 17.7 violations

MISRA Rule-17.7 requires the return value of all functions to be used.
Fix is either to use the return value or change the function to return
void. This patch contains fix for calls to nvgpu_mutex_init and
improves related error handling.

JIRA NVGPU-677

Change-Id: I609fa138520cc7ccfdd5aa0e7fd28c8ca0b3a21c
Signed-off-by: Nicolas Benech <nbenech@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1805598
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>

1 files changed, 12 insertions, 10 deletions

diff --git a/drivers/gpu/nvgpu/gv100/flcn_gv100.c b/drivers/gpu/nvgpu/gv100/flcn_gv100.c
index 5820d6c9..5167e3f0 100644
--- a/drivers/gpu/nvgpu/gv100/flcn_gv100.c
+++ b/drivers/gpu/nvgpu/gv100/flcn_gv100.c
@@ -29,27 +29,29 @@
 
 #include <nvgpu/hw/gv100/hw_falcon_gv100.h>
 
-void gv100_falcon_hal_sw_init(struct nvgpu_falcon *flcn)
+int gv100_falcon_hal_sw_init(struct nvgpu_falcon *flcn)
 {
         struct gk20a *g = flcn->g;
+        int err = 0;
 
-        switch (flcn->flcn_id) {
-        case FALCON_ID_MINION:
+        if (flcn->flcn_id == FALCON_ID_MINION) {
                 flcn->flcn_base = g->nvlink.minion_base;
                 flcn->is_falcon_supported = true;
                 flcn->is_interrupt_enabled = true;
-                break;
-        default:
-                break;
-        }
 
-        if (flcn->is_falcon_supported) {
-                nvgpu_mutex_init(&flcn->copy_lock);
+                err = nvgpu_mutex_init(&flcn->copy_lock);
+                if (err != 0) {
+                        nvgpu_err(g, "Error in flcn.copy_lock mutex initialization");
+                        return err;
+                }
+
                 gk20a_falcon_ops(flcn);
         } else {
                 /*
                  * Fall back
                  */
-                gp106_falcon_hal_sw_init(flcn);
+                err = gp106_falcon_hal_sw_init(flcn);
         }
+
+        return err;
 }