summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/gp10b
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2017-05-22 14:27:40 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2017-05-26 06:34:30 -0400
commit2e338c77eac4edffb94c8c9480dbd72712c7696f (patch)
tree9d5da6355bc653ef2ba9014ea696ad0391c523a1 /drivers/gpu/nvgpu/gp10b
parent726900b8433294fd89a6d730d2fec9de8e33afda (diff)
gpu: nvgpu: remove duplicate \n from log messages
nvgpu_log/info/warn/err() internally add a \n to the end of the message. Hence, callers should not include a \n at the end of the message. Doing so results in duplicate \n being printed, which ends up creating empty log messages. Remove the duplicate \n from all err/warn messages. Bug 1928311 Change-Id: I99362c5327f36146f28ba63d4e68181589735c39 Signed-off-by: Stephen Warren <swarren@nvidia.com> Reviewed-on: http://git-master/r/1487232 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gp10b')
-rw-r--r--drivers/gpu/nvgpu/gp10b/gp10b_sysfs.c4
-rw-r--r--drivers/gpu/nvgpu/gp10b/gr_gp10b.c4
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/nvgpu/gp10b/gp10b_sysfs.c b/drivers/gpu/nvgpu/gp10b/gp10b_sysfs.c
index 1bd95b40..5a242bb5 100644
--- a/drivers/gpu/nvgpu/gp10b/gp10b_sysfs.c
+++ b/drivers/gpu/nvgpu/gp10b/gp10b_sysfs.c
@@ -35,7 +35,7 @@ static ssize_t ecc_enable_store(struct device *dev,
35 err = g->ops.pmu.send_lrf_tex_ltc_dram_overide_en_dis_cmd 35 err = g->ops.pmu.send_lrf_tex_ltc_dram_overide_en_dis_cmd
36 (g, ecc_mask); 36 (g, ecc_mask);
37 if (err) 37 if (err)
38 nvgpu_err(g, "ECC override did not happen\n"); 38 nvgpu_err(g, "ECC override did not happen");
39 } else 39 } else
40 return -EINVAL; 40 return -EINVAL;
41 return count; 41 return count;
@@ -90,7 +90,7 @@ void gp10b_create_sysfs(struct device *dev)
90 error |= device_create_file(dev, &dev_attr_ecc_enable); 90 error |= device_create_file(dev, &dev_attr_ecc_enable);
91 error |= device_create_file(dev, &dev_attr_czf_bypass); 91 error |= device_create_file(dev, &dev_attr_czf_bypass);
92 if (error) 92 if (error)
93 nvgpu_err(g, "Failed to create sysfs attributes!\n"); 93 nvgpu_err(g, "Failed to create sysfs attributes!");
94} 94}
95 95
96void gp10b_remove_sysfs(struct device *dev) 96void gp10b_remove_sysfs(struct device *dev)
diff --git a/drivers/gpu/nvgpu/gp10b/gr_gp10b.c b/drivers/gpu/nvgpu/gp10b/gr_gp10b.c
index 2c85a667..98a8be2f 100644
--- a/drivers/gpu/nvgpu/gp10b/gr_gp10b.c
+++ b/drivers/gpu/nvgpu/gp10b/gr_gp10b.c
@@ -1631,7 +1631,7 @@ static int gr_gp10b_disable_channel_or_tsg(struct gk20a *g, struct channel_gk20a
1631 ret = gk20a_disable_channel_tsg(g, fault_ch); 1631 ret = gk20a_disable_channel_tsg(g, fault_ch);
1632 if (ret) { 1632 if (ret) {
1633 nvgpu_err(g, 1633 nvgpu_err(g,
1634 "CILP: failed to disable channel/TSG!\n"); 1634 "CILP: failed to disable channel/TSG!");
1635 return ret; 1635 return ret;
1636 } 1636 }
1637 1637
@@ -1833,7 +1833,7 @@ static int gr_gp10b_pre_process_sm_exception(struct gk20a *g,
1833 gk20a_dbg(gpu_dbg_fn | gpu_dbg_gpu_dbg, "CILP: Setting CILP preempt pending\n"); 1833 gk20a_dbg(gpu_dbg_fn | gpu_dbg_gpu_dbg, "CILP: Setting CILP preempt pending\n");
1834 ret = gr_gp10b_set_cilp_preempt_pending(g, fault_ch); 1834 ret = gr_gp10b_set_cilp_preempt_pending(g, fault_ch);
1835 if (ret) { 1835 if (ret) {
1836 nvgpu_err(g, "CILP: error while setting CILP preempt pending!\n"); 1836 nvgpu_err(g, "CILP: error while setting CILP preempt pending!");
1837 return ret; 1837 return ret;
1838 } 1838 }
1839 1839