summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/gp10b
diff options
context:
space:
mode:
authorPhilip Elcan <pelcan@nvidia.com>2018-09-18 10:14:05 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2018-09-26 19:44:59 -0400
commit07e5bd817a23913d120b945ced5c96951716886c (patch)
treee8654264bba5a5f5a318c587758b7a476b83c0f2 /drivers/gpu/nvgpu/gp10b
parent1a3d75790db3effe6f461ca4923cac7e7d2202c4 (diff)
gpu: nvgpu: fix return type of *get_litter_value()
All callers for the *get_litter_value() functions were expecting u32, but the functions were declared to return int's. This is a violation of MISRA 10.3 which prohibits implicit assignment between essential types (signed int and unsigned long int, in this case). The litter values are all u32's anyway. JIRA NVGPU-647 Change-Id: I853d2abee372488e5d12e355050cbeaf1e53a42c Signed-off-by: Philip Elcan <pelcan@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1830581 Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Scott Long <scottl@nvidia.com> Reviewed-by: Alex Waterman <alexw@nvidia.com> Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gp10b')
-rw-r--r--drivers/gpu/nvgpu/gp10b/hal_gp10b.c4
-rw-r--r--drivers/gpu/nvgpu/gp10b/hal_gp10b.h2
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/nvgpu/gp10b/hal_gp10b.c b/drivers/gpu/nvgpu/gp10b/hal_gp10b.c
index 68dfcfe4..1050c89f 100644
--- a/drivers/gpu/nvgpu/gp10b/hal_gp10b.c
+++ b/drivers/gpu/nvgpu/gp10b/hal_gp10b.c
@@ -88,9 +88,9 @@
88#include <nvgpu/hw/gp10b/hw_pwr_gp10b.h> 88#include <nvgpu/hw/gp10b/hw_pwr_gp10b.h>
89#include <nvgpu/hw/gp10b/hw_gr_gp10b.h> 89#include <nvgpu/hw/gp10b/hw_gr_gp10b.h>
90 90
91int gp10b_get_litter_value(struct gk20a *g, int value) 91u32 gp10b_get_litter_value(struct gk20a *g, int value)
92{ 92{
93 int ret = EINVAL; 93 u32 ret = EINVAL;
94 switch (value) { 94 switch (value) {
95 case GPU_LIT_NUM_GPCS: 95 case GPU_LIT_NUM_GPCS:
96 ret = proj_scal_litter_num_gpcs_v(); 96 ret = proj_scal_litter_num_gpcs_v();
diff --git a/drivers/gpu/nvgpu/gp10b/hal_gp10b.h b/drivers/gpu/nvgpu/gp10b/hal_gp10b.h
index 6ba80b88..13103c17 100644
--- a/drivers/gpu/nvgpu/gp10b/hal_gp10b.h
+++ b/drivers/gpu/nvgpu/gp10b/hal_gp10b.h
@@ -27,5 +27,5 @@
27struct gk20a; 27struct gk20a;
28 28
29int gp10b_init_hal(struct gk20a *gops); 29int gp10b_init_hal(struct gk20a *gops);
30int gp10b_get_litter_value(struct gk20a *g, int value); 30u32 gp10b_get_litter_value(struct gk20a *g, int value);
31#endif /* NVGPU_HAL_GP10B_H */ 31#endif /* NVGPU_HAL_GP10B_H */