summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/gp106/mclk_gp106.c
diff options
context:
space:
mode:
authorSrirangan <smadhavan@nvidia.com>2018-08-27 01:59:01 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2018-08-29 11:59:35 -0400
commite3710e5431d8f14f1b8c2812f5c1aeeb7bdaac1c (patch)
tree8a6498b12e10f6b391d3c5dd7c6ac7b340ca60b4 /drivers/gpu/nvgpu/gp106/mclk_gp106.c
parent2f97e683feed3c3ba3c8722c4f6ab7466bcef0c0 (diff)
gpu: nvgpu: gp106: Fix MISRA 15.6 violations
MISRA Rule-15.6 requires that all if-else blocks be enclosed in braces, including single statement blocks. Fix errors due to single statement if blocks without braces, introducing the braces. JIRA NVGPU-671 Change-Id: I8493274995ed8de526902dd0ca0808b2972e28aa Signed-off-by: Srirangan <smadhavan@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1796806 Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com> Reviewed-by: Konsta Holtta <kholtta@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gp106/mclk_gp106.c')
-rw-r--r--drivers/gpu/nvgpu/gp106/mclk_gp106.c30
1 files changed, 20 insertions, 10 deletions
diff --git a/drivers/gpu/nvgpu/gp106/mclk_gp106.c b/drivers/gpu/nvgpu/gp106/mclk_gp106.c
index 108eed56..36092a1a 100644
--- a/drivers/gpu/nvgpu/gp106/mclk_gp106.c
+++ b/drivers/gpu/nvgpu/gp106/mclk_gp106.c
@@ -3079,8 +3079,9 @@ static int mclk_get_memclk_table(struct gk20a *g)
3079 3079
3080 memcpy(&memclock_base_entry, mem_entry_ptr, 3080 memcpy(&memclock_base_entry, mem_entry_ptr,
3081 memclock_table_header.base_entry_size); 3081 memclock_table_header.base_entry_size);
3082 if (memclock_base_entry.maximum == 0) 3082 if (memclock_base_entry.maximum == 0) {
3083 continue; 3083 continue;
3084 }
3084 3085
3085 script_index = BIOS_GET_FIELD(memclock_base_entry.flags1, 3086 script_index = BIOS_GET_FIELD(memclock_base_entry.flags1,
3086 VBIOS_MEMORY_CLOCK_BASE_ENTRY_11_FLAGS1_SCRIPT_INDEX); 3087 VBIOS_MEMORY_CLOCK_BASE_ENTRY_11_FLAGS1_SCRIPT_INDEX);
@@ -3089,8 +3090,9 @@ static int mclk_get_memclk_table(struct gk20a *g)
3089 memclock_table_header.script_list_ptr + 3090 memclock_table_header.script_list_ptr +
3090 script_index * sizeof(u32)); 3091 script_index * sizeof(u32));
3091 3092
3092 if (!script_ptr) 3093 if (!script_ptr) {
3093 continue; 3094 continue;
3095 }
3094 3096
3095 /* Link and execute shadow scripts */ 3097 /* Link and execute shadow scripts */
3096 3098
@@ -3107,8 +3109,9 @@ static int mclk_get_memclk_table(struct gk20a *g)
3107 for (shadow_idx = 0; shadow_idx < 3109 for (shadow_idx = 0; shadow_idx <
3108 fb_fbpa_fbio_delay_priv_max_v(); 3110 fb_fbpa_fbio_delay_priv_max_v();
3109 ++shadow_idx) { 3111 ++shadow_idx) {
3110 if (idx_to_ptr_tbl[shadow_idx] == 0) 3112 if (idx_to_ptr_tbl[shadow_idx] == 0) {
3111 break; 3113 break;
3114 }
3112 } 3115 }
3113 3116
3114 if (shadow_idx > fb_fbpa_fbio_delay_priv_max_v()) { 3117 if (shadow_idx > fb_fbpa_fbio_delay_priv_max_v()) {
@@ -3142,14 +3145,16 @@ static int mclk_get_memclk_table(struct gk20a *g)
3142 memclock_table_header.cmd_script_list_ptr + 3145 memclock_table_header.cmd_script_list_ptr +
3143 cmd_script_index * sizeof(u32)); 3146 cmd_script_index * sizeof(u32));
3144 3147
3145 if (!cmd_script_ptr) 3148 if (!cmd_script_ptr) {
3146 continue; 3149 continue;
3150 }
3147 3151
3148 /* Link and execute cmd shadow scripts */ 3152 /* Link and execute cmd shadow scripts */
3149 for (cmd_idx = 0; cmd_idx <= fb_fbpa_fbio_cmd_delay_cmd_priv_max_v(); 3153 for (cmd_idx = 0; cmd_idx <= fb_fbpa_fbio_cmd_delay_cmd_priv_max_v();
3150 ++cmd_idx) { 3154 ++cmd_idx) {
3151 if (cmd_script_ptr == idx_to_cmd_ptr_tbl[cmd_idx]) 3155 if (cmd_script_ptr == idx_to_cmd_ptr_tbl[cmd_idx]) {
3152 break; 3156 break;
3157 }
3153 } 3158 }
3154 3159
3155 /* script has not been executed before */ 3160 /* script has not been executed before */
@@ -3158,8 +3163,9 @@ static int mclk_get_memclk_table(struct gk20a *g)
3158 for (cmd_idx = 0; cmd_idx < 3163 for (cmd_idx = 0; cmd_idx <
3159 fb_fbpa_fbio_cmd_delay_cmd_priv_max_v(); 3164 fb_fbpa_fbio_cmd_delay_cmd_priv_max_v();
3160 ++cmd_idx) { 3165 ++cmd_idx) {
3161 if (idx_to_cmd_ptr_tbl[cmd_idx] == 0) 3166 if (idx_to_cmd_ptr_tbl[cmd_idx] == 0) {
3162 break; 3167 break;
3168 }
3163 } 3169 }
3164 3170
3165 if (cmd_idx > fb_fbpa_fbio_cmd_delay_cmd_priv_max_v()) { 3171 if (cmd_idx > fb_fbpa_fbio_cmd_delay_cmd_priv_max_v()) {
@@ -3220,12 +3226,14 @@ int gp106_mclk_init(struct gk20a *g)
3220 mclk = &g->clk_pmu.clk_mclk; 3226 mclk = &g->clk_pmu.clk_mclk;
3221 3227
3222 err = nvgpu_mutex_init(&mclk->mclk_lock); 3228 err = nvgpu_mutex_init(&mclk->mclk_lock);
3223 if (err) 3229 if (err) {
3224 return err; 3230 return err;
3231 }
3225 3232
3226 err = nvgpu_mutex_init(&mclk->data_lock); 3233 err = nvgpu_mutex_init(&mclk->data_lock);
3227 if (err) 3234 if (err) {
3228 goto fail_mclk_mutex; 3235 goto fail_mclk_mutex;
3236 }
3229 3237
3230 /* FBPA gain WAR */ 3238 /* FBPA gain WAR */
3231 gk20a_writel(g, fb_fbpa_fbio_iref_byte_rx_ctrl_r(), 0x22222222); 3239 gk20a_writel(g, fb_fbpa_fbio_iref_byte_rx_ctrl_r(), 0x22222222);
@@ -3326,15 +3334,17 @@ int gp106_mclk_change(struct gk20a *g, u16 val)
3326 3334
3327 nvgpu_mutex_acquire(&mclk->mclk_lock); 3335 nvgpu_mutex_acquire(&mclk->mclk_lock);
3328 3336
3329 if (!mclk->init) 3337 if (!mclk->init) {
3330 goto exit_status; 3338 goto exit_status;
3339 }
3331 3340
3332 speed = (val < mclk->p5_min) ? GP106_MCLK_LOW_SPEED : 3341 speed = (val < mclk->p5_min) ? GP106_MCLK_LOW_SPEED :
3333 (val < mclk->p0_min) ? GP106_MCLK_MID_SPEED : 3342 (val < mclk->p0_min) ? GP106_MCLK_MID_SPEED :
3334 GP106_MCLK_HIGH_SPEED; 3343 GP106_MCLK_HIGH_SPEED;
3335 3344
3336 if (speed == mclk->speed) 3345 if (speed == mclk->speed) {
3337 goto exit_status; 3346 goto exit_status;
3347 }
3338 3348
3339 seq_script_ptr = m->scripts[mclk->speed][speed].addr; 3349 seq_script_ptr = m->scripts[mclk->speed][speed].addr;
3340 seq_script_size = m->scripts[mclk->speed][speed].size; 3350 seq_script_size = m->scripts[mclk->speed][speed].size;