summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/gp106/hal_gp106.c
diff options
context:
space:
mode:
authorPhilip Elcan <pelcan@nvidia.com>2018-09-18 10:14:05 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2018-09-26 19:44:59 -0400
commit07e5bd817a23913d120b945ced5c96951716886c (patch)
treee8654264bba5a5f5a318c587758b7a476b83c0f2 /drivers/gpu/nvgpu/gp106/hal_gp106.c
parent1a3d75790db3effe6f461ca4923cac7e7d2202c4 (diff)
gpu: nvgpu: fix return type of *get_litter_value()
All callers for the *get_litter_value() functions were expecting u32, but the functions were declared to return int's. This is a violation of MISRA 10.3 which prohibits implicit assignment between essential types (signed int and unsigned long int, in this case). The litter values are all u32's anyway. JIRA NVGPU-647 Change-Id: I853d2abee372488e5d12e355050cbeaf1e53a42c Signed-off-by: Philip Elcan <pelcan@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1830581 Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Scott Long <scottl@nvidia.com> Reviewed-by: Alex Waterman <alexw@nvidia.com> Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gp106/hal_gp106.c')
-rw-r--r--drivers/gpu/nvgpu/gp106/hal_gp106.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/nvgpu/gp106/hal_gp106.c b/drivers/gpu/nvgpu/gp106/hal_gp106.c
index c0f2fd57..3786b588 100644
--- a/drivers/gpu/nvgpu/gp106/hal_gp106.c
+++ b/drivers/gpu/nvgpu/gp106/hal_gp106.c
@@ -106,9 +106,9 @@
106#include <nvgpu/hw/gp106/hw_gr_gp106.h> 106#include <nvgpu/hw/gp106/hw_gr_gp106.h>
107 107
108 108
109static int gp106_get_litter_value(struct gk20a *g, int value) 109static u32 gp106_get_litter_value(struct gk20a *g, int value)
110{ 110{
111 int ret = -EINVAL; 111 u32 ret = EINVAL;
112 112
113 switch (value) { 113 switch (value) {
114 case GPU_LIT_NUM_GPCS: 114 case GPU_LIT_NUM_GPCS: