diff options
author | Richard Zhao <rizhao@nvidia.com> | 2018-01-26 14:44:12 -0500 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-01-31 05:40:48 -0500 |
commit | b386768d323c95f530dd28b695927426e52fe0dc (patch) | |
tree | b6facabb206b8d7e5dbc471512c71db2eb35f245 /drivers/gpu/nvgpu/gk20a | |
parent | a9644aa4435a72e5c7e768f85ffb98802940cab4 (diff) |
gpu: nvgpu: make .tsg_unbind_channel one layer lower
The message to tell RM server to unbind channel has to be sent after
client unbinds the channel and before client calls tsg release. The
channel has to belong to a tsg on RM server before client submit a
runlist to remove the channel. Or there's a bare channel problem.
By moving .tsg_unbind_channl one layer lower, gk20a_tsg_unbind_channel()
will be common functions for all chip, and it'll call tsg release after
call .tsg_unbind_channel. So vgpu won't need to worry about tsg was
released before sending msg to RM server.
Bug 200382695
Bug 200382785
Change-Id: I32acc122f3f9d5d0628049ccf673225f9e90c87a
Signed-off-by: Richard Zhao <rizhao@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1645383
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Konsta Holtta <kholtta@nvidia.com>
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gk20a')
-rw-r--r-- | drivers/gpu/nvgpu/gk20a/channel_gk20a.c | 2 | ||||
-rw-r--r-- | drivers/gpu/nvgpu/gk20a/tsg_gk20a.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/nvgpu/gk20a/channel_gk20a.c b/drivers/gpu/nvgpu/gk20a/channel_gk20a.c index 2949c426..07863ac7 100644 --- a/drivers/gpu/nvgpu/gk20a/channel_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/channel_gk20a.c | |||
@@ -349,7 +349,7 @@ static void gk20a_free_channel(struct channel_gk20a *ch, bool force) | |||
349 | if (!nvgpu_is_enabled(g, NVGPU_DRIVER_IS_DYING)) { | 349 | if (!nvgpu_is_enabled(g, NVGPU_DRIVER_IS_DYING)) { |
350 | /* abort channel and remove from runlist */ | 350 | /* abort channel and remove from runlist */ |
351 | if (gk20a_is_channel_marked_as_tsg(ch)) { | 351 | if (gk20a_is_channel_marked_as_tsg(ch)) { |
352 | err = g->ops.fifo.tsg_unbind_channel(ch); | 352 | err = gk20a_tsg_unbind_channel(ch); |
353 | if (err) | 353 | if (err) |
354 | nvgpu_err(g, | 354 | nvgpu_err(g, |
355 | "failed to unbind channel %d from TSG", | 355 | "failed to unbind channel %d from TSG", |
diff --git a/drivers/gpu/nvgpu/gk20a/tsg_gk20a.c b/drivers/gpu/nvgpu/gk20a/tsg_gk20a.c index 19d0ecce..ccb456cf 100644 --- a/drivers/gpu/nvgpu/gk20a/tsg_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/tsg_gk20a.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (c) 2014-2017, NVIDIA CORPORATION. All rights reserved. | 2 | * Copyright (c) 2014-2018, NVIDIA CORPORATION. All rights reserved. |
3 | * | 3 | * |
4 | * Permission is hereby granted, free of charge, to any person obtaining a | 4 | * Permission is hereby granted, free of charge, to any person obtaining a |
5 | * copy of this software and associated documentation files (the "Software"), | 5 | * copy of this software and associated documentation files (the "Software"), |
@@ -150,7 +150,7 @@ int gk20a_tsg_unbind_channel(struct channel_gk20a *ch) | |||
150 | struct tsg_gk20a *tsg = &g->fifo.tsg[ch->tsgid]; | 150 | struct tsg_gk20a *tsg = &g->fifo.tsg[ch->tsgid]; |
151 | int err; | 151 | int err; |
152 | 152 | ||
153 | err = gk20a_fifo_tsg_unbind_channel(ch); | 153 | err = g->ops.fifo.tsg_unbind_channel(ch); |
154 | if (err) { | 154 | if (err) { |
155 | nvgpu_err(g, "Channel %d unbind failed, tearing down TSG %d", | 155 | nvgpu_err(g, "Channel %d unbind failed, tearing down TSG %d", |
156 | ch->chid, tsg->tsgid); | 156 | ch->chid, tsg->tsgid); |