diff options
author | seshendra Gadagottu <sgadagottu@nvidia.com> | 2018-03-20 15:28:04 -0400 |
---|---|---|
committer | Tejal Kudav <tkudav@nvidia.com> | 2018-06-14 09:44:06 -0400 |
commit | 40cefb666f3767059383052346d4c0faa9195a48 (patch) | |
tree | 36c848f78eabae4117ca2c7acc01da6f9479dd3c /drivers/gpu/nvgpu/gk20a/gk20a.c | |
parent | 054546525571dde1117376176f00511f13168f07 (diff) |
gpu: nvgpu: gpu railgate handling with runtime pm
Earlier implementation of railgate disable config is disabling
runtime pm during pm_init. This is causing multiple issues:
1. gpu rail will be on as soon as nvgpu driver probe is called.
Actual gpu hw init may happen at much later point of time.
2. This is breaking railgate_enable sysfs node functionality.
railgate_enable is not working if runtime pm is disabled.
To avoid all these issues for railgate disable, enable runtime pm
during pm_init and set auto-suspend delay to negative (-1), which
will disable runtime pm suspend calls.
Also fixed following issues along with this:
1. Updated railgate_enable debugfs implementation to use auto-suspend delay.
To disable railgating:
Set auto-suspend delay with negative value(-1) which will disable runtime
pm suspend.
To enable railgating:
Set auto-suspend delay with railgate_delay value.
Also removed redundant user_railgate_disabled gk20a device data and
replaced with can_railgate, where ever it is applicable.
2. Initialized default railgate_delay to 500msec to avoid railgate
on/off transitions with railigate enable from disabled state.
3. Created railgate_residency debug fs node irrespective of can_railgate
initial state. This is helping with the case, where initial state of
railgate state off and then railgate enable is done through sysfs node.
Bug 2073029
Change-Id: I531da6d93ba8907e806f65a1de2a447c1ec2665c
Signed-off-by: seshendra Gadagottu <sgadagottu@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1694944
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gk20a/gk20a.c')
-rw-r--r-- | drivers/gpu/nvgpu/gk20a/gk20a.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/gpu/nvgpu/gk20a/gk20a.c b/drivers/gpu/nvgpu/gk20a/gk20a.c index 9ce2ef53..b502ef02 100644 --- a/drivers/gpu/nvgpu/gk20a/gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/gk20a.c | |||
@@ -370,9 +370,6 @@ int gk20a_wait_for_idle(struct gk20a *g) | |||
370 | if (!g) | 370 | if (!g) |
371 | return -ENODEV; | 371 | return -ENODEV; |
372 | 372 | ||
373 | if (g->user_railgate_disabled) | ||
374 | target_usage_count = 1; | ||
375 | |||
376 | while ((nvgpu_atomic_read(&g->usage_count) != target_usage_count) | 373 | while ((nvgpu_atomic_read(&g->usage_count) != target_usage_count) |
377 | && (wait_length-- >= 0)) | 374 | && (wait_length-- >= 0)) |
378 | nvgpu_msleep(20); | 375 | nvgpu_msleep(20); |