gpu: nvgpu: add per-channel refcounting

Add reference counting for channels, and wait for reference count to
get to 0 in gk20a_channel_free() before actually freeing the channel.
Also, change free channel tracking a bit by employing a list of free
channels, which simplifies the procedure of finding available channels
with reference counting.

Each use of a channel must have a reference taken before use or held
by the caller. Taking a reference of a wild channel pointer may fail, if
the channel is either not opened or in a process of being closed. Also,
add safeguards for protecting accidental use of closed channels,
specifically, by setting ch->g = NULL in channel free. This will make it
obvious if freed channel is attempted to be used.

The last user of a channel might be the deferred interrupt handler,
so wait for deferred interrupts to be processed twice in the channel
free procedure: once for providing last notifications to the channel
and once to make sure there are no stale pointers left after referencing
to the channel has been denied.

Finally, fix some races in channel and TSG force reset IOCTL path,
by pausing the channel scheduler in gk20a_fifo_recover_ch() and
gk20a_fifo_recover_tsg(), while the affected engines have been identified,
the appropriate MMU faults triggered, and the MMU faults handled. In this
case, make sure that the MMU fault does not attempt to query the hardware
about the failing channel or TSG ids. This should make channel recovery
more safe also in the regular (i.e., not in the interrupt handler) context.

Bug 1530226
Bug 1597493
Bug 1625901
Bug 200076344
Bug 200071810

Change-Id: Ib274876908e18219c64ea41e50ca443df81d957b
Signed-off-by: Terje Bergstrom <tbergstrom@nvidia.com>
Signed-off-by: Konsta Holtta <kholtta@nvidia.com>
Signed-off-by: Sami Kiminki <skiminki@nvidia.com>
Reviewed-on: http://git-master/r/448463
(cherry picked from commit 3f03aeae64ef2af4829e06f5f63062e8ebd21353)
Reviewed-on: http://git-master/r/755147
Reviewed-by: Automatic_Commit_Validation_User

1 files changed, 25 insertions, 9 deletions

diff --git a/drivers/gpu/nvgpu/gk20a/debug_gk20a.c b/drivers/gpu/nvgpu/gk20a/debug_gk20a.c
index 0f1c31dd..bda0dab0 100644
--- a/drivers/gpu/nvgpu/gk20a/debug_gk20a.c
+++ b/drivers/gpu/nvgpu/gk20a/debug_gk20a.c
@@ -36,6 +36,7 @@ static struct platform_device *gk20a_device;
 
 struct ch_state {
         int pid;
+        int refs;
         u8 inst_block[0];
 };
 
@@ -118,9 +119,10 @@ static void gk20a_debug_show_channel(struct gk20a *g,
         syncpointa = gk20a_mem_rd32(inst_ptr, ram_fc_syncpointa_w());
         syncpointb = gk20a_mem_rd32(inst_ptr, ram_fc_syncpointb_w());
 
-        gk20a_debug_output(o, "%d-%s, pid %d: ", hw_chid,
+        gk20a_debug_output(o, "%d-%s, pid %d, refs: %d: ", hw_chid,
                         g->dev->name,
-                        ch_state->pid);
+                        ch_state->pid,
+                        ch_state->refs);
         gk20a_debug_output(o, "%s in use %s %s\n",
                         ccsr_channel_enable_v(channel) ? "" : "not",
                         ccsr_chan_status_str[status],
@@ -231,16 +233,30 @@ void gk20a_debug_show_dump(struct gk20a *g, struct gk20a_debug_output *o)
         }
 
         for (chid = 0; chid < f->num_channels; chid++) {
-                if (f->channel[chid].in_use)
-                        ch_state[chid] = kmalloc(sizeof(struct ch_state) + ram_in_alloc_size_v(), GFP_KERNEL);
+                struct channel_gk20a *ch = &f->channel[chid];
+                if (gk20a_channel_get(ch)) {
+                        ch_state[chid] =
+                                kmalloc(sizeof(struct ch_state) +
+                                        ram_in_alloc_size_v(), GFP_KERNEL);
+                        /* ref taken stays to below loop with
+                         * successful allocs */
+                        if (!ch_state[chid])
+                                gk20a_channel_put(ch);
+                }
         }
 
         for (chid = 0; chid < f->num_channels; chid++) {
-                if (ch_state[chid] && f->channel[chid].inst_block.cpu_va) {
-                        ch_state[chid]->pid = f->channel[chid].pid;
-                        memcpy(&ch_state[chid]->inst_block[0],
-                               f->channel[chid].inst_block.cpu_va,
-                               ram_in_alloc_size_v());
+                struct channel_gk20a *ch = &f->channel[chid];
+                if (ch_state[chid]) {
+                        if (ch->inst_block.cpu_va) {
+                                ch_state[chid]->pid = ch->pid;
+                                ch_state[chid]->refs =
+                                        atomic_read(&ch->ref_count);
+                                memcpy(&ch_state[chid]->inst_block[0],
+                                                ch->inst_block.cpu_va,
+                                                ram_in_alloc_size_v());
+                        }
+                        gk20a_channel_put(ch);
                 }
         }
         for (chid = 0; chid < f->num_channels; chid++) {