diff options
author | Srirangan <smadhavan@nvidia.com> | 2018-08-31 03:50:52 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-09-05 07:51:32 -0400 |
commit | 43851d41b187c92f5ea9c2f503a882277f661d7e (patch) | |
tree | 964a76c136c8c0dc14ec95358d27f930532b7dcb /drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c | |
parent | 0f97bd4d44c8bcedf298f725fe0b6cfc70fa81ff (diff) |
gpu: nvgpu: gk20a: Fix MISRA 15.6 violations
MISRA Rule-15.6 requires that all if-else blocks be enclosed in braces,
including single statement blocks. Fix errors due to single statement
if blocks without braces by introducing the braces.
JIRA NVGPU-671
Change-Id: Iedac7d50aa2ebd409434eea5fda902b16d9c6fea
Signed-off-by: Srirangan <smadhavan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1797695
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vijayakumar Subbu <vsubbu@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c')
-rw-r--r-- | drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c | 54 |
1 files changed, 30 insertions, 24 deletions
diff --git a/drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c b/drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c index 3be08865..e7f95245 100644 --- a/drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c | |||
@@ -229,21 +229,25 @@ int dbg_set_powergate(struct dbg_session_gk20a *dbg_s, bool disable_powergate) | |||
229 | nvgpu_log(g, gpu_dbg_gpu_dbg | gpu_dbg_fn, | 229 | nvgpu_log(g, gpu_dbg_gpu_dbg | gpu_dbg_fn, |
230 | "module busy"); | 230 | "module busy"); |
231 | err = gk20a_busy(g); | 231 | err = gk20a_busy(g); |
232 | if (err) | 232 | if (err) { |
233 | return err; | 233 | return err; |
234 | } | ||
234 | 235 | ||
235 | /*do elpg disable before clock gating */ | 236 | /*do elpg disable before clock gating */ |
236 | nvgpu_pmu_pg_global_enable(g, false); | 237 | nvgpu_pmu_pg_global_enable(g, false); |
237 | 238 | ||
238 | if (g->ops.clock_gating.slcg_gr_load_gating_prod) | 239 | if (g->ops.clock_gating.slcg_gr_load_gating_prod) { |
239 | g->ops.clock_gating.slcg_gr_load_gating_prod(g, | 240 | g->ops.clock_gating.slcg_gr_load_gating_prod(g, |
240 | false); | 241 | false); |
241 | if (g->ops.clock_gating.slcg_perf_load_gating_prod) | 242 | } |
243 | if (g->ops.clock_gating.slcg_perf_load_gating_prod) { | ||
242 | g->ops.clock_gating.slcg_perf_load_gating_prod(g, | 244 | g->ops.clock_gating.slcg_perf_load_gating_prod(g, |
243 | false); | 245 | false); |
244 | if (g->ops.clock_gating.slcg_ltc_load_gating_prod) | 246 | } |
247 | if (g->ops.clock_gating.slcg_ltc_load_gating_prod) { | ||
245 | g->ops.clock_gating.slcg_ltc_load_gating_prod(g, | 248 | g->ops.clock_gating.slcg_ltc_load_gating_prod(g, |
246 | false); | 249 | false); |
250 | } | ||
247 | 251 | ||
248 | gr_gk20a_init_cg_mode(g, BLCG_MODE, BLCG_RUN); | 252 | gr_gk20a_init_cg_mode(g, BLCG_MODE, BLCG_RUN); |
249 | gr_gk20a_init_cg_mode(g, ELCG_MODE, ELCG_RUN); | 253 | gr_gk20a_init_cg_mode(g, ELCG_MODE, ELCG_RUN); |
@@ -254,28 +258,27 @@ int dbg_set_powergate(struct dbg_session_gk20a *dbg_s, bool disable_powergate) | |||
254 | /* release pending exceptions to fault/be handled as usual */ | 258 | /* release pending exceptions to fault/be handled as usual */ |
255 | /*TBD: ordering of these? */ | 259 | /*TBD: ordering of these? */ |
256 | 260 | ||
257 | if (g->elcg_enabled) | 261 | if (g->elcg_enabled) { |
258 | gr_gk20a_init_cg_mode(g, ELCG_MODE, ELCG_AUTO); | 262 | gr_gk20a_init_cg_mode(g, ELCG_MODE, ELCG_AUTO); |
263 | } | ||
259 | 264 | ||
260 | if (g->blcg_enabled) | 265 | if (g->blcg_enabled) { |
261 | gr_gk20a_init_cg_mode(g, BLCG_MODE, BLCG_AUTO); | 266 | gr_gk20a_init_cg_mode(g, BLCG_MODE, BLCG_AUTO); |
267 | } | ||
262 | 268 | ||
263 | if (g->slcg_enabled) { | 269 | if (g->slcg_enabled) { |
264 | if (g->ops.clock_gating. | 270 | if (g->ops.clock_gating.slcg_ltc_load_gating_prod) { |
265 | slcg_ltc_load_gating_prod) | 271 | g->ops.clock_gating.slcg_ltc_load_gating_prod(g, |
266 | g->ops.clock_gating. | 272 | g->slcg_enabled); |
267 | slcg_ltc_load_gating_prod(g, | 273 | } |
268 | g->slcg_enabled); | 274 | if (g->ops.clock_gating.slcg_perf_load_gating_prod) { |
269 | if (g->ops.clock_gating. | 275 | g->ops.clock_gating.slcg_perf_load_gating_prod(g, |
270 | slcg_perf_load_gating_prod) | 276 | g->slcg_enabled); |
271 | g->ops.clock_gating. | 277 | } |
272 | slcg_perf_load_gating_prod(g, | 278 | if (g->ops.clock_gating.slcg_gr_load_gating_prod) { |
273 | g->slcg_enabled); | 279 | g->ops.clock_gating.slcg_gr_load_gating_prod(g, |
274 | if (g->ops.clock_gating. | 280 | g->slcg_enabled); |
275 | slcg_gr_load_gating_prod) | 281 | } |
276 | g->ops.clock_gating. | ||
277 | slcg_gr_load_gating_prod(g, | ||
278 | g->slcg_enabled); | ||
279 | } | 282 | } |
280 | nvgpu_pmu_pg_global_enable(g, true); | 283 | nvgpu_pmu_pg_global_enable(g, true); |
281 | 284 | ||
@@ -328,12 +331,14 @@ void nvgpu_release_profiler_reservation(struct dbg_session_gk20a *dbg_s, | |||
328 | struct gk20a *g = dbg_s->g; | 331 | struct gk20a *g = dbg_s->g; |
329 | 332 | ||
330 | g->profiler_reservation_count--; | 333 | g->profiler_reservation_count--; |
331 | if (g->profiler_reservation_count < 0) | 334 | if (g->profiler_reservation_count < 0) { |
332 | nvgpu_err(g, "Negative reservation count!"); | 335 | nvgpu_err(g, "Negative reservation count!"); |
336 | } | ||
333 | dbg_s->has_profiler_reservation = false; | 337 | dbg_s->has_profiler_reservation = false; |
334 | prof_obj->has_reservation = false; | 338 | prof_obj->has_reservation = false; |
335 | if (prof_obj->ch == NULL) | 339 | if (prof_obj->ch == NULL) { |
336 | g->global_profiler_reservation_held = false; | 340 | g->global_profiler_reservation_held = false; |
341 | } | ||
337 | } | 342 | } |
338 | 343 | ||
339 | int gk20a_perfbuf_enable_locked(struct gk20a *g, u64 offset, u32 size) | 344 | int gk20a_perfbuf_enable_locked(struct gk20a *g, u64 offset, u32 size) |
@@ -351,8 +356,9 @@ int gk20a_perfbuf_enable_locked(struct gk20a *g, u64 offset, u32 size) | |||
351 | } | 356 | } |
352 | 357 | ||
353 | err = g->ops.mm.alloc_inst_block(g, &mm->perfbuf.inst_block); | 358 | err = g->ops.mm.alloc_inst_block(g, &mm->perfbuf.inst_block); |
354 | if (err) | 359 | if (err) { |
355 | return err; | 360 | return err; |
361 | } | ||
356 | 362 | ||
357 | g->ops.mm.init_inst_block(&mm->perfbuf.inst_block, mm->perfbuf.vm, 0); | 363 | g->ops.mm.init_inst_block(&mm->perfbuf.inst_block, mm->perfbuf.vm, 0); |
358 | 364 | ||