summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/gk20a/channel_gk20a.c
diff options
context:
space:
mode:
authorPeter Daifuku <pdaifuku@nvidia.com>2017-08-17 14:49:21 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2017-08-17 19:45:05 -0400
commita0be159e69d5bfdb31fa87943151437d03736683 (patch)
tree3ee16bd90b01580ae072e12e1a24dae16cd427b9 /drivers/gpu/nvgpu/gk20a/channel_gk20a.c
parent7a4b9487b663a5dbc69ada49d8382c899682129d (diff)
gpu: nvgpu: channel_worker_enqueue: warn to info
gk20a_channel_worker_enqueue currently WARNS if the call to gk20a_channel_get fails. But in fact a failure here is legitimate, in particular if the channel is in the process of being freed, and the referenceable flag changed between the time the caller grabbed a reference to the channel and the time this function tries to grab its own reference. Instead, turn the warning into an info message. Bug 200329971 Change-Id: Iab4ca6b32bb98f42f05b12b7971538db962b9795 Signed-off-by: Peter Daifuku <pdaifuku@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1540458 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gk20a/channel_gk20a.c')
-rw-r--r--drivers/gpu/nvgpu/gk20a/channel_gk20a.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/gpu/nvgpu/gk20a/channel_gk20a.c b/drivers/gpu/nvgpu/gk20a/channel_gk20a.c
index d96872f3..5f81b441 100644
--- a/drivers/gpu/nvgpu/gk20a/channel_gk20a.c
+++ b/drivers/gpu/nvgpu/gk20a/channel_gk20a.c
@@ -1903,10 +1903,13 @@ static void gk20a_channel_worker_enqueue(struct channel_gk20a *ch)
1903 1903
1904 /* 1904 /*
1905 * Ref released when this item gets processed. The caller should hold 1905 * Ref released when this item gets processed. The caller should hold
1906 * one ref already, so can't fail. 1906 * one ref already, so normally shouldn't fail, but the channel could
1907 * end up being freed between the time the caller got its reference and
1908 * the time we end up here (e.g., if the client got killed); if so, just
1909 * return.
1907 */ 1910 */
1908 if (WARN_ON(!gk20a_channel_get(ch))) { 1911 if (!gk20a_channel_get(ch)) {
1909 nvgpu_warn(g, "cannot get ch ref for worker!"); 1912 nvgpu_info(g, "cannot get ch ref for worker!");
1910 return; 1913 return;
1911 } 1914 }
1912 1915